Re: winex11: Don't trace a garbage value or read past end of caller's array in X11DRV_wglChoosePixelFormatARB().

2013-09-20 Thread Ken Thomases
On Sep 20, 2013, at 9:44 AM, Roderick Colenbrander wrote: > That change looks suspicious. If switching to i+1 fixes a problem, the real > problem is that the if-statement in question gets entered in the first > place. Some bounds checking on the outer for-loop (the one which loops > through nCfgs

Re: D3D command stream patches for testing

2013-09-20 Thread Forest
Stefan, are these patches already present in the wine 1.7.2 release? Now that the official 1.7.2 Ubuntu packages have been published, I'm trying to figure out how to get your CSMT changes into the PPA that I maintain.

Re: [PATCH 2/6] wined3d: Add support for converted volumes.

2013-09-20 Thread Henri Verbeet
On 20 September 2013 13:04, Stefan Dösinger wrote: > +static BOOL wined3d_volume_can_evict(const struct wined3d_volume *volume) > +{ > +if (volume->resource.pool != WINED3D_POOL_MANAGED) > +return FALSE; > +if (volume->download_count < 10) > +return FALSE; That doesn't look

Re: [PATCH 6/6] wined3d: Use GL_APPLE_client_storage for volumes if available.

2013-09-20 Thread Henri Verbeet
On 20 September 2013 13:04, Stefan Dösinger wrote: > -volume->flags &= ~(WINED3D_VFLAG_ALLOCATED | > WINED3D_VFLAG_SRGB_ALLOCATED); > +volume->flags &= ~(WINED3D_VFLAG_ALLOCATED | WINED3D_VFLAG_SRGB_ALLOCATED > +| WINED3D_VFLAG_CLIENT_STORAGE); > Indentation looks a bit off here.

Re: winex11: Don't trace a garbage value or read past end of caller's array in X11DRV_wglChoosePixelFormatARB().

2013-09-20 Thread Roderick Colenbrander
That change looks suspicious. If switching to i+1 fixes a problem, the real problem is that the if-statement in question gets entered in the first place. Some bounds checking on the outer for-loop (the one which loops through nCfgs and nMaxFormats), is probably wrong then. I had issues with this pa

Re: (resend)[3/4] imm32: use thread data from target HWND

2013-09-20 Thread Alexandre Julliard
Aric Stewart writes: > @@ -507,7 +524,7 @@ HIMC WINAPI ImmAssociateContext(HWND hWnd, HIMC hIMC) > LeaveCriticalSection(&threaddata_cs); > defaultContext = ImmCreateContext(); > ((InputContextData*)defaultContext)->threadDefault = TRUE; > -thread_data = IMM_GetT

Re: [1/2] oledb32: Correct DataLinks interface for win64

2013-09-20 Thread Alexandre Julliard
Alistair Leslie-Hughes writes: > @@ -26,6 +26,20 @@ import "oledb.idl"; > #define vi_progid(str) > #endif > > +#ifdef _WIN64 > +cpp_quote("#ifdef _WIN64") > +typedef LONGLONG COMPATIBLE_LONG; > +cpp_quote("#else") > +cpp_quote("typedef LONG COMPATIBLE_LONG;") > +cpp_quote("#endif") >