On 9/13/2013 22:26, André Hentschel wrote:
+if (!pCreateFile2)
+{
+win_skip("CreateFile2 is missing\n");
+return;
+}
Should be skip() so it'll show up when running with wine. Not sure how
important it is though.
On 9/13/2013 22:26, André Hentschel wrote:
Sorry, ignore my comment. I missed that we actually have this call
already in wine.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2158
Your paranoid andr
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2155
Your paranoid andr
Hi Nikolay,
2013/9/13 Nikolay Sivov
>
> On 9/13/2013 15:05, Jactry Zeng wrote:
>>
>> bUnicode = !bRtf && pStruct->codepage == CP_UNICODE;
>> +bUTF8 = (lParam && (!strncmp((char *)lParam, utf8_bom, 3)));
>
> What will happen if both of these are true? This needs a test with BOM
and 'codep
On 9/13/2013 15:05, Jactry Zeng wrote:
bUnicode = !bRtf && pStruct->codepage == CP_UNICODE;
+bUTF8 = (lParam && (!strncmp((char *)lParam, utf8_bom, 3)));
What will happen if both of these are true? This needs a test with BOM
and 'codepage' set to 1200.
On 9/13/2013 13:27, Jactry Zeng wrote:
Re-based to latest git.
Does it actually accept any other value besides CP_ACP or 1200?
Documentation is unclear here, and makes impression that only two these
values are valid.
2013/9/13 Alexandre Julliard
>
> > @@ -3313,6 +3315,10 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor,
UINT msg, WPARAM wParam,
> > len = lParam ? strlen((char *)lParam) : 0;
> >}
> > } else {
> > + if(bUTF8) {
> > +lParam = lParam + 3;
> > +pStruct->c
On Fri, Sep 13, 2013 at 11:07:19AM +0100, Huw Davies wrote:
> ---
> fonts/wingding.sfd | 86 +
Please ignore this one and use 'try 2'.
I had the points of one glyph selected in the outline editor which
apparently gets saved to the .sfd .
Huw.
Jactry Zeng writes:
> @@ -3313,6 +3315,10 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT
> msg, WPARAM wParam,
> len = lParam ? strlen((char *)lParam) : 0;
>}
> } else {
> + if(bUTF8) {
> +lParam = lParam + 3;
> +pStruct->codepage = CP_UTF8;
>
Dmitry Timoshkov writes:
> Nikolay Sivov wrote:
>
>> >> It looks like it belongs to kernel32/tests.
>> > Since actual access checks are done by ntdll APIs I believe that
>> > ntdll/tests
>> > is appropriate place, kernel32 file APIs are just wrappers around the
>> > tested
>> > functionality.
Francois Gouget wrote:
> That tree was a bit out of date causing the patch to fail to apply. I
> updated it and rediffed.
I'd appreciate if you could postpone sending this sort of patches
when they could conflict with other pending patches in that area.
Thanks.
--
Dmitry.
Nikolay Sivov wrote:
> >> It looks like it belongs to kernel32/tests.
> > Since actual access checks are done by ntdll APIs I believe that ntdll/tests
> > is appropriate place, kernel32 file APIs are just wrappers around the tested
> > functionality.
> >
> It doesn't matter what it uses internall
Dmitry Timoshkov writes:
> This matches what NtWriteFile does.
>
> I assume that this patch is in 'pending' state because of a test failure
> caused
> by 2/2, if the reason is different - please let me know.
It would need some test cases for other file types.
--
Alexandre Julliard
julli...@wi
On 9/13/2013 12:16, Dmitry Timoshkov wrote:
Nikolay Sivov wrote:
It looks like it belongs to kernel32/tests.
Since actual access checks are done by ntdll APIs I believe that ntdll/tests
is appropriate place, kernel32 file APIs are just wrappers around the tested
functionality.
It doesn't ma
Nikolay Sivov wrote:
> It looks like it belongs to kernel32/tests.
Since actual access checks are done by ntdll APIs I believe that ntdll/tests
is appropriate place, kernel32 file APIs are just wrappers around the tested
functionality.
--
Dmitry.
On 9/13/2013 11:20, Dmitry Timoshkov wrote:
This test passes under Wine and shows that ReadFile after
CreateFile(GENERIC_WRITE)
is really supposed to fail.
---
dlls/ntdll/tests/file.c | 82 +
1 file changed, 82 insertions(+)
It looks like it b
17 matches
Mail list logo
