Re: ntdll/tests: Fix compilation on systems that don't support nameless unions.

2013-09-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2144 Your paranoid andr

Re: [PATCH 3/6] user32: Export WINPOS_GetMinMaxInfo() as __wine_get_min_max_info() so it can be called by drivers.

2013-09-12 Thread Dmitry Timoshkov
Ken Thomases wrote: > >> +@ cdecl __wine_get_min_max_info(long ptr ptr ptr ptr) WINPOS_GetMinMaxInfo > > > > What's wrong with calling SendMessage(WM_GETMINMAXINFO) from the driver? > > Because I would have to duplicate all of the rest of the logic in > WINPOS_GetMinMaxInfo(), too. Do you rea

Re: [try3] gdi32: abc values remain the same despite any changes in layout direction or Viewport

2013-09-12 Thread Alexandre Julliard
Aric Stewart writes: > @@ -1262,6 +1290,70 @@ static void test_GetCharABCWidths(void) > } > > ReleaseDC(NULL, hdc); > + > +memset(&lf, 0, sizeof(lf)); > +strcpy(lf.lfFaceName, "Tahoma"); > +lf.lfHeight = 20; > + > +#define helper_ABC(a) (winetest_set_location(__FILE__,__LI

Re: [PATCH 3/6] user32: Export WINPOS_GetMinMaxInfo() as __wine_get_min_max_info() so it can be called by drivers.

2013-09-12 Thread Ken Thomases
On Sep 12, 2013, at 10:48 AM, Dmitry Timoshkov wrote: > Ken Thomases wrote: > +@ cdecl __wine_get_min_max_info(long ptr ptr ptr ptr) WINPOS_GetMinMaxInfo >>> >>> What's wrong with calling SendMessage(WM_GETMINMAXINFO) from the driver? >> >> Because I would have to duplicate all of the res

Re: d3d9/tests: D3DCMP_GREATER is broken on r500 (try 2).

2013-09-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2136 Your paranoid andr

Re: [PATCH 3/6] user32: Export WINPOS_GetMinMaxInfo() as __wine_get_min_max_info() so it can be called by drivers.

2013-09-12 Thread Ken Thomases
On Sep 12, 2013, at 12:23 AM, Dmitry Timoshkov wrote: > Ken Thomases wrote: > >> +@ cdecl __wine_get_min_max_info(long ptr ptr ptr ptr) WINPOS_GetMinMaxInfo > > What's wrong with calling SendMessage(WM_GETMINMAXINFO) from the driver? Because I would have to duplicate all of the rest of the log

Re: [PATCH 5/5] d3d9/tests: D3DCMP_GREATER is broken on r500.

2013-09-12 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-12 13:36, schrieb Henri Verbeet: > I really just meant the typo in the comment. Ah yes, that should be "distorted". -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmai

Re: [PATCH 5/5] d3d9/tests: D3DCMP_GREATER is broken on r500.

2013-09-12 Thread Henri Verbeet
On 12 September 2013 13:33, Stefan Dösinger wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 2013-09-12 12:44, schrieb Henri Verbeet: >> On 12 September 2013 12:23, Stefan Dösinger >> wrote: >>> + * On the r500 driver on Windows D3DCMP_GREATER and >>> D3DCMP_GREATEREQUAL are br

Re: [PATCH 5/5] d3d9/tests: D3DCMP_GREATER is broken on r500.

2013-09-12 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-12 12:44, schrieb Henri Verbeet: > On 12 September 2013 12:23, Stefan Dösinger > wrote: >> + * On the r500 driver on Windows D3DCMP_GREATER and >> D3DCMP_GREATEREQUAL are broken for depth + * values > 0.5. >> The range appears to be

Re: [2/2] kernel32: Remove a 0-length read optimization from ReadFile.

2013-09-12 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> > This matches WriteFile behaviour and ensures that invalid parameters are >> > properly handled and fields in the OVERLAPPED structure are initialized. >> >> This is again causing test failures. Please do a full test run before >> sendi

Re: [2/2] kernel32: Remove a 0-length read optimization from ReadFile.

2013-09-12 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > This matches WriteFile behaviour and ensures that invalid parameters are > > properly handled and fields in the OVERLAPPED structure are initialized. > > This is again causing test failures. Please do a full test run before > sending patches. Could you please list

Re: [2/2] kernel32: Remove a 0-length read optimization from ReadFile.

2013-09-12 Thread Alexandre Julliard
Dmitry Timoshkov writes: > This matches WriteFile behaviour and ensures that invalid parameters are > properly handled and fields in the OVERLAPPED structure are initialized. This is again causing test failures. Please do a full test run before sending patches. -- Alexandre Julliard julli...@w

Re: [PATCH 5/5] d3d9/tests: D3DCMP_GREATER is broken on r500.

2013-09-12 Thread Henri Verbeet
On 12 September 2013 12:23, Stefan Dösinger wrote: > + * On the r500 driver on Windows D3DCMP_GREATER and D3DCMP_GREATEREQUAL > are broken for depth > + * values > 0.5. The range appears to be distored, apparently an > incoming value of ~0.875 is "distorted"?