Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 5)

2013-09-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2084 Your paranoid andr

Re: winemac: Don't return characters for Ctrl-(non-letter symbol) keypresses from ToUnicodeEx() as X11 driver already does (try 2)

2013-09-09 Thread Ken Thomases
Hi, On Sep 9, 2013, at 7:38 PM, Phil Krylov wrote: > Sorry, my first try had wrong patch attached > > -- Ph. > <0001-winemac-Don-t-return-characters-for-Ctrl-non-letter-try2.patch.txt> Is there a specific problem that you're trying to fix? The Mac driver's ToUnicodeEx() implementation started

Re: [1/5] ntdll: Add support to NtWriteFile for special offset -1. Take 2.

2013-09-09 Thread Alexandre Julliard
Dmitry Timoshkov writes: > --- > dlls/ntdll/file.c | 13 ++--- > dlls/ntdll/tests/file.c | 15 --- > 2 files changed, 10 insertions(+), 18 deletions(-) This is causing test failures all over the place. -- Alexandre Julliard julli...@winehq.org

Re: D3D command stream patches for testing

2013-09-09 Thread LOMBARD Maxime
Hi Stefan, I've tested two games "FarCry3" and "Splinter Cell Blacklist" with : - Wine 1.7.1 + CS patch + CSMT On/Off - Wine 1.7.1 clean - CSMT On = CSMT enabled + StrictDrawOrdering disabled - CSMT Off = CSMT disabled + StrictDrawOrdering enabled I run the game by *WINEDEBUG=fps,err-all,fixme-a

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

2013-09-09 Thread Wolfgang Walter
Am Sonntag, 8. September 2013, 11:32:26 schrieb Francois Gouget: > On Thu, 5 Sep 2013, Wolfgang Walter wrote: > [...] > > > To see that my later patches are needed you must modify the test a little > > bit: > > > > - dlls/kernel32/tests/comm.c.old 2013-09-05 13:40:10.275757373 +0200 > > +++ dlls

Re: server: Add a serial event mask change counter.

2013-09-09 Thread Alexandre Julliard
Dmitry Timoshkov writes: > @@ -209,7 +211,7 @@ DECL_HANDLER(get_serial_info) > reply->writemult= serial->writemult; > > /* event mask */ > -reply->eventmask= serial->eventmask; > +reply->eventmask= serial->eventmask | (serial->generation << 16); It

Re: [PATCH 3/6] ws2_32: Fix parameters checking in WSADuplicateSocket

2013-09-09 Thread Alexandre Julliard
Bruno Jesus <00cp...@gmail.com> writes: > On Mon, Sep 9, 2013 at 6:39 AM, Alexandre Julliard > wrote: >> Bruno Jesus <00cp...@gmail.com> writes: >> >>> +fd = get_sock_fd( s, FILE_READ_DATA, NULL ); >>> +if (fd == -1) >>> +{ >>> +SetLastError(WSAENOTSOCK); >>> +return

Re: [PATCH 3/6] ws2_32: Fix parameters checking in WSADuplicateSocket

2013-09-09 Thread Bruno Jesus
On Mon, Sep 9, 2013 at 6:39 AM, Alexandre Julliard wrote: > Bruno Jesus <00cp...@gmail.com> writes: > >> +fd = get_sock_fd( s, FILE_READ_DATA, NULL ); >> +if (fd == -1) >> +{ >> +SetLastError(WSAENOTSOCK); >> +return SOCKET_ERROR; >> +} >> +release_sock_fd( s, f

Re: [PATCH 4/5] wined3d: Move the decoded stream info into the context

2013-09-09 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-09 13:55, schrieb Henri Verbeet: > Not strictly, but I think it helps with keeping track of how much > bits are left and avoiding silly things like holes in the > structure. Fair enough. Please ignore patches 4 and 5 for today, I'll take m

Re: [PATCH 4/5] wined3d: Move the decoded stream info into the context

2013-09-09 Thread Henri Verbeet
On 9 September 2013 13:49, Stefan Dösinger wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 2013-09-09 13:42, schrieb Henri Verbeet: >> I think that's an unfortunate place to insert the field, and you >> should update the padding. >> @@ -1880,9 +1889,7 @@ struct wined3d_device

Re: [PATCH 4/5] wined3d: Move the decoded stream info into the context

2013-09-09 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-09 13:42, schrieb Henri Verbeet: > I think that's an unfortunate place to insert the field, and you > should update the padding. > >>> @@ -1880,9 +1889,7 @@ struct wined3d_device WORD >>> d3d_initialized : 1; WORD inScene : 1;

Re: [PATCH 5/5] wined3d: Explicitly pass the state information to buffer_internal_preload

2013-09-09 Thread Henri Verbeet
On 9 September 2013 12:56, Stefan Dösinger wrote: > -static BOOL buffer_find_decl(struct wined3d_buffer *This, const struct > wined3d_context *context) > +static BOOL buffer_find_decl(struct wined3d_buffer *This, const struct > wined3d_context *context, > +const struct wined3d_state *sta

Re: [PATCH 4/5] wined3d: Move the decoded stream info into the context

2013-09-09 Thread Henri Verbeet
On 9 September 2013 12:56, Stefan Dösinger wrote: > --- I think this patch does a couple of things at once, and would probably benefit from being broken up. > static struct arb_vs_compiled_shader *find_arb_vshader(struct wined3d_shader > *shader, > -const struct arb_vs_compile_args *arg

Re: [PATCH 1/5] wined3d: Don't mess with the device in buffer_create_buffer_object

2013-09-09 Thread Henri Verbeet
On 9 September 2013 12:56, Stefan Dösinger wrote: > @@ -148,7 +149,7 @@ static void buffer_create_buffer_object(struct > wined3d_buffer *This, const struc > } > > if (This->buffer_type_hint == GL_ELEMENT_ARRAY_BUFFER_ARB) > -device_invalidate_state(This->resource.device, STATE_I

Re: [PATCH 3/6] ws2_32: Fix parameters checking in WSADuplicateSocket

2013-09-09 Thread Alexandre Julliard
Bruno Jesus <00cp...@gmail.com> writes: > +fd = get_sock_fd( s, FILE_READ_DATA, NULL ); > +if (fd == -1) > +{ > +SetLastError(WSAENOTSOCK); > +return SOCKET_ERROR; > +} > +release_sock_fd( s, fd ); You should avoid retrieving the fd if you are not using it. The