Re: [PATCH 5/6] ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 4)

2013-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2064 Your paranoid andr

Re: [PATCH 6/6] ws2_32: Fill WSAPROTOCOL_INFO struct in WSADuplicateSocket

2013-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2065 Your paranoid andr

Implementation of ITextDocument_fnOpen needs some advice

2013-09-07 Thread Jactry Zeng
Hi folks, I need your advice or comment! Implement ITextDocument_fnOpen[0] (riched20) is a part of work to my GSoC. The 'pencils down' date is coming. And I think it is time to clear the code up. This series of patches is the implementation of ITextDocument_fnOpen. I would like to improve

Re: [PATCH 4/6] ws2_32: Add more WSADuplicateSocket tests

2013-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2063 Your paranoid andr

Re: [PATCH 3/6] ws2_32: Fix parameters checking in WSADuplicateSocket

2013-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2062 Your paranoid andr

Re: [PATCH 1/6] ws2_32: Mark WinNT result as broken

2013-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2061 Your paranoid andr

Re: Patch for bug 34388

2013-09-07 Thread Juan Lang
On Fri, Sep 6, 2013 at 9:17 PM, Charles Davis wrote: > > On Sep 6, 2013, at 5:01 PM, Juan Lang wrote: > > On Fri, Sep 6, 2013 at 3:54 PM, Charles Davis wrote: > >> Maybe then the real fix is to make Wine accept either a constructor SET >> or the custom tag (ASN_CONTEXT | ASN_CONSTRUCTOR) it curr

Re: ntdll: Implement job objects. (try 3)

2013-09-07 Thread Alexandre Julliard
Andrew Cook writes: > This will be my last submission for this piece of code, i want to work > on other things and it's been almost 2 weeks with zero comments on my > previous submission. It's clearly not ready, and you already know that since you've added TODOs all over the place. -- Alexandr