Re: Patch for bug 34388

2013-09-06 Thread Charles Davis
On Sep 6, 2013, at 5:01 PM, Juan Lang wrote: > On Fri, Sep 6, 2013 at 3:54 PM, Charles Davis wrote: > Maybe then the real fix is to make Wine accept either a constructor SET or > the custom tag (ASN_CONTEXT | ASN_CONSTRUCTOR) it currently accepts, for > either attribute set. I should come up w

Re: Patch for bug 34388

2013-09-06 Thread Juan Lang
On Fri, Sep 6, 2013 at 3:54 PM, Charles Davis wrote: > Maybe then the real fix is to make Wine accept either a constructor SET or > the custom tag (ASN_CONTEXT | ASN_CONSTRUCTOR) it currently accepts, for > either attribute set. I should come up with a test case first, though, to > see if that's

Re: Patch for bug 34388

2013-09-06 Thread Charles Davis
On Sep 6, 2013, at 1:10 PM, Juan Lang wrote: > Hiya Chip, > > I don't have an answer off the top of my head. But let's see if we can unpack > that ASN.1 a bit. > > First, with the type, notice that crypt32_private.h defines a few useful > types that Microsoft omitted for some reason from thei

RFC: Completely revised SIO_ADDRESS_LIST_CHANGE patches

2013-09-06 Thread Erich E. Hoover
As some of you know I've been working on fixing SIO_ADDRESS_LIST_CHANGE in order to fix some problems with Silverlight on a variety of streaming sites. Due to some feedback I've received I've gone to the effort to completely revise these patches to work inside of the server instead of using iphlpa

Re: Patch for bug 34388

2013-09-06 Thread Juan Lang
Hiya Chip, I don't have an answer off the top of my head. But let's see if we can unpack that ASN.1 a bit. First, with the type, notice that crypt32_private.h defines a few useful types that Microsoft omitted for some reason from their public header, including: #define ASN_SETOF (ASN_UN

Re: aclui: Remove some unneeded header inclusions. (IWYU)

2013-09-06 Thread Alexandre Julliard
Amine Khaldi writes: > On 06/09/2013 16:28, Alexandre Julliard wrote: >> Amine Khaldi writes: >> >>> @@ -18,15 +18,7 @@ >>> * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, >>> USA >>> */ >>> >>> -#include "config.h" >>> - >>> -#include >>> - >>> #include "initgui

Re: aclui: Remove some unneeded header inclusions. (IWYU)

2013-09-06 Thread Amine Khaldi
On 06/09/2013 16:28, Alexandre Julliard wrote: > Amine Khaldi writes: > >> @@ -18,15 +18,7 @@ >> * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA >> */ >> >> -#include "config.h" >> - >> -#include >> - >> #include "initguid.h" >> -#include "windef.h" >> -#include

Re: aclui: Remove some unneeded header inclusions. (IWYU)

2013-09-06 Thread Alexandre Julliard
Amine Khaldi writes: > @@ -18,15 +18,7 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > */ > > -#include "config.h" > - > -#include > - > #include "initguid.h" > -#include "windef.h" > -#include "winbase.h" > -#include "winuser.h" > -#include "winnt.h" >

Re: [2/6] ntdll: Add support to NtWriteFile for special offset -1.

2013-09-06 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > +if (offset && offset->QuadPart == (LONGLONG)-1 /* > > FILE_WRITE_TO_END_OF_FILE */) > > +offset->QuadPart = lseek( unix_handle, 0, SEEK_END ); > > + > > This looks very wrong, offset belongs to the caller. Of course you are correct, thanks. -

Re: [PATCH 2/3] ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 3)

2013-09-06 Thread Bruno Jesus
On Fri, Sep 6, 2013 at 7:16 AM, Alexandre Julliard wrote: > Bruno Jesus <00cp...@gmail.com> writes: > >> +static int ws_protocol_info(SOCKET s, int unicode, WSAPROTOCOL_INFOW >> *buffer) >> +{ >> +int size; >> +union _info >> +{ >> +WSAPROTOCOL_INFOA *a; >> +WSAPROTOCO

Re: [PATCH 2/3] ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 3)

2013-09-06 Thread Alexandre Julliard
Bruno Jesus <00cp...@gmail.com> writes: > +static int ws_protocol_info(SOCKET s, int unicode, WSAPROTOCOL_INFOW *buffer) > +{ > +int size; > +union _info > +{ > +WSAPROTOCOL_INFOA *a; > +WSAPROTOCOL_INFOW *w; > +} info; > +info.w = buffer; > + > +size = unic

Re: [2/6] ntdll: Add support to NtWriteFile for special offset -1.

2013-09-06 Thread Alexandre Julliard
Dmitry Timoshkov writes: > --- > dlls/ntdll/file.c | 3 +++ > dlls/ntdll/tests/file.c | 15 --- > 2 files changed, 3 insertions(+), 15 deletions(-) > > diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c > index 9420df5..9d5b02a 100644 > --- a/dlls/ntdll/file.c > +++ b/dlls/ntd

Re: crypt32 patch review

2013-09-06 Thread Jacek Caban
On 09/05/13 18:53, Juan Lang wrote: > [+wine-devel] > > Hi Jacek, > I've added the list so the discussion can take place in public. > > On Tue, Sep 3, 2013 at 8:50 AM, Jacek Caban > wrote: > > I have a patch for crypt32. I'd appreciate your review before I submit

Re: ntdll/tests: Add tests for job objects. (try 2)

2013-09-06 Thread Andrew Cook
On 06/09/13 17:12, Frédéric Delanoy wrote: > On Fri, Sep 6, 2013 at 5:41 AM, Andrew Cook wrote: >> --- >> dlls/ntdll/tests/Makefile.in | 1 + >> dlls/ntdll/tests/job.c | 151 >> +++ >> include/winnt.h | 5 ++ >> 3 files changed, 157 i

Re: ntdll/tests: Add tests for job objects. (try 2)

2013-09-06 Thread Frédéric Delanoy
On Fri, Sep 6, 2013 at 5:41 AM, Andrew Cook wrote: > --- > dlls/ntdll/tests/Makefile.in | 1 + > dlls/ntdll/tests/job.c | 151 > +++ > include/winnt.h | 5 ++ > 3 files changed, 157 insertions(+) > create mode 100644 dlls/ntdll/tests