Patch for bug 34388

Hi Juan, I need some advice. Attached is a patch to fix bug 34388, where an app that tries to verify its code signature fails because Wine, while parsing the certificates embedded within the signature, encounters an item in the CMS signer info (tag 0x31, i.e. ASN_UNIVERSAL | ASN_CONSTRUCTOR |

Re: [PATCH 1/3] riched20: Use codepage in ME_ToUnicode. (try 2)

On 9/4/2013 21:16, Jactry Zeng wrote: Hi Nikolay, 2013/9/5 Nikolay Sivov > > > On 9/4/2013 07:17, Jactry Zeng wrote: >> >> -ME_EndToUnicode(unicode, wszText); >> +ME_EndToUnicode(unicode ? 1200 : CP_ACP, wszText); > > It's still ugly to use magic num

Re: [PATCH 2/3] ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 3)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2035 Your paranoid andr

Re: crypt32 patch review

[+wine-devel] Hi Jacek, I've added the list so the discussion can take place in public. On Tue, Sep 3, 2013 at 8:50 AM, Jacek Caban wrote: > I have a patch for crypt32. I'd appreciate your review before I submit > it to Wine. It has high potential to be insecure... This should fix Wine bug 280

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

On 05 Sep 2013, at 16:58, Dmitry Timoshkov wrote: > Jonas Maebe wrote: > >> So either >> * you add code in between that resets the state so that test2 can be run >> independently of whether test1 failed (as Wolfgang proposes), or >> * you put the tests in completely different executables so th

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

Am Donnerstag, 5. September 2013, 23:58:57 schrieb Dmitry Timoshkov: > Jonas Maebe wrote: > > > The tests must pass under Wine without any additional "fixes" as they do > > > currently under Windows. If you add some code to the tests which > > > suddenly > > > makes them pass under Wine - that's n

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

Am Donnerstag, 5. September 2013, 23:32:00 schrieben Sie: > Wolfgang Walter wrote: > > > > > > With my patches 1/2 and 2/2 I get: > > > > > > > > > > > > fixme:iphlpapi:NotifyAddrChange (Handle 0x10ee8e0, overlapped > > > > > > 0x10ee8ec): > > > > > > stub wine: configuration in '/home/walterw/.w

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

Jonas Maebe wrote: > > The tests must pass under Wine without any additional "fixes" as they do > > currently under Windows. If you add some code to the tests which suddenly > > makes them pass under Wine - that's not a fix, Wine implementation should > > be fixed instead. > > What I understood

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

Wolfgang Walter wrote: > > > > No, the source of the failures is still there. > > > > > > What do you mean with that? The tests indeed do succeed now and there is a > > > reason they do: when you call WaitCommEvent() while the tx buffer is not > > > empty > > > yet the wine code will detect tha

D3D command stream patches for testing

I've tested some games (wine 1.7.1 64-bit for Guild Wars 2 and SCII, 32-bit for Skyrim, no wined3d/d3d patch except the patchset for CSMT). I have a GTX660 (slightly overclocked, +10 Mhz or so) with the 325.15 Nvidia blob and an Intel i5 2500K (overclocked to 4.2 Ghz). #Guild Wars 2(in the Lion's

Re: [PATCH 6/6] kernel32/tests: remove several todos in test_waittxempty

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2023 Your paranoid andr

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

On 05 Sep 2013, at 16:32, Dmitry Timoshkov wrote: > The tests must pass under Wine without any additional "fixes" as they do > currently under Windows. If you add some code to the tests which suddenly > makes them pass under Wine - that's not a fix, Wine implementation should > be fixed instead.

Re: iphlpapi: Add AllocateAndGetTcpExTableFromStack() (try 6)

Ralf Habacker writes: > +/** > + * test api function AllocateAndGetTcpExTableFromStack() > + * > + * Only specific tests required because the function is based > + * on build_tcp_table() which is covered by test_GetExtendedTcpTabl

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

Wolfgang Walter wrote: > > > With my patches 1/2 and 2/2 I get: > > > > > > fixme:iphlpapi:NotifyAddrChange (Handle 0x10ee8e0, overlapped 0x10ee8ec): > > > stub wine: configuration in '/home/walterw/.wine' has been updated. > > > fixme:comm:set_queue_size insize 1024 outsize 1024 unimplemented s

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

Wolfgang Walter wrote: > > > > > With my patches 1/2 and 2/2 I get: > > > > > > > > > > fixme:iphlpapi:NotifyAddrChange (Handle 0x10ee8e0, overlapped > > > > > 0x10ee8ec): > > > > > stub wine: configuration in '/home/walterw/.wine' has been updated. > > > > > fixme:comm:set_queue_size insize 102

Re: ntdll/tests: Add tests for job objects.

Andrew Cook writes: > diff --git a/dlls/ntdll/tests/Makefile.in b/dlls/ntdll/tests/Makefile.in > index 10d6674..1903d10 100644 > --- a/dlls/ntdll/tests/Makefile.in > +++ b/dlls/ntdll/tests/Makefile.in > @@ -11,6 +11,7 @@ C_SRCS = \ > file.c \ > generated.c \ > info.c \ > + j

Re: ws2_32: Cope with invalid protocols in WSAEnumProtocols

On Thu, Sep 5, 2013 at 9:44 AM, Dmitry Timoshkov wrote: > Bruno Jesus <00cp...@gmail.com> wrote: > >> +INT validprotocols[] = { WS_IPPROTO_TCP, >> + WS_IPPROTO_UDP, >> + NSPROTO_IPX, >> + NSPROTO_SPX, >> +

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

Am Donnerstag, 5. September 2013, 21:12:37 schrieb Dmitry Timoshkov: > Wolfgang Walter wrote: > > > Does 'make test' pass without failures for you? > > > > Without patch 1/2 and 2/2 I get for > > > > $ ../../../tools/runtest -P wine -M kernel32.dll -T ../../.. -q -p > > kernel32_test.exe.so comm

Re: ws2_32: Cope with invalid protocols in WSAEnumProtocols

Bruno Jesus <00cp...@gmail.com> wrote: > +INT validprotocols[] = { WS_IPPROTO_TCP, > + WS_IPPROTO_UDP, > + NSPROTO_IPX, > + NSPROTO_SPX, > + NSPROTO_SPXII, > + 0 }; This should

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

Wolfgang Walter wrote: > > Does 'make test' pass without failures for you? > > > Without patch 1/2 and 2/2 I get for > > $ ../../../tools/runtest -P wine -M kernel32.dll -T ../../.. -q -p > kernel32_test.exe.so comm.c > > fixme:comm:set_queue_size insize 1024 outsize 1024 unimplemented stub

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

Am Donnerstag, 5. September 2013, 19:40:13 schrieb Dmitry Timoshkov: > Wolfgang Walter wrote: > > This is not a work around. > > > > todo_wine will not magically undo sending the bytes. > > Please explain why you think that there will be now pending > > bytes in the tx buffer if the tests fails.

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

Wolfgang Walter wrote: > This is not a work around. > > todo_wine will not magically undo sending the bytes. > Please explain why you think that there will be now pending > bytes in the tx buffer if the tests fails. > > And why it does not make the next tests fail even if wine would > behave co

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

Am Donnerstag, 5. September 2013, 18:55:55 schrieben Sie: > Wolfgang Walter wrote: > > > > > > +if (res || (!res && GetLastError() == ERROR_IO_PENDING)) > > > > > > +/* if data has been sent: wait for termination */ > > > > > > +Sleep(timeout); > > > > > > > > > > I don't see

Re: [PATCH 5/5] ddraw: Enumerate DXT2 and DXT4

My understanding is that we should do rgb *= a in the shader. Writing tests for this is on my todo list, but very close to the bottom. (Sorry for the top post. Stupid android mail program) Henri Verbeet schrieb: >On 5 September 2013 10:42, Stefan Dösinger >wrote: >> Yes, we don't actually

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

Wolfgang Walter wrote: > > > > > +if (res || (!res && GetLastError() == ERROR_IO_PENDING)) > > > > > +/* if data has been sent: wait for termination */ > > > > > +Sleep(timeout); > > > > > > > > I don't see such a problem with real COM-port and serial-USB cable > > > > under

Re: [PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

Wolfgang Walter wrote: > > > > WaitCommEvent always returns FALSE when device is opened in overlapped > > > > mode.> > > > Not according to MSN documentation of WaitCommEvent(): > > > > > > "If the overlapped operation cannot be completed immediately, the function > > > returns FALSE and the Ge

Re: [PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

Am Donnerstag, 5. September 2013, 18:31:45 schrieb Dmitry Timoshkov: > Wolfgang Walter wrote: > > > WaitCommEvent always returns FALSE when device is opened in overlapped > > > mode.> > > Not according to MSN documentation of WaitCommEvent(): > > > > "If the overlapped operation cannot be comple

Re: [PATCH 3/5] ddraw/tests: Test DDCAPS2_TEXTUREMANAGE compatibility with other flags

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2016 Your paranoid andr

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

Am Donnerstag, 5. September 2013, 17:54:58 schrieb Dmitry Timoshkov: > Wolfgang Walter wrote: > > > > +if (res || (!res && GetLastError() == ERROR_IO_PENDING)) > > > > +/* if data has been sent: wait for termination */ > > > > +Sleep(timeout); > > > > > > I don't see such a pr

Re: [PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

Wolfgang Walter wrote: > > WaitCommEvent always returns FALSE when device is opened in overlapped mode. > > Not according to MSN documentation of WaitCommEvent(): > > "If the overlapped operation cannot be completed immediately, the function > returns FALSE and the GetLastError function return

Re: [PATCH 3/5] ddraw/tests: Test DDCAPS2_TEXTUREMANAGE compatibility with other flags

Oops, will resend later. Henri Verbeet schrieb: >On 5 September 2013 10:42, Stefan Dösinger >wrote: >> +if(DDSD->ddsCaps.dwCaps2 & DDSCAPS2_TEXTUREMANAGE) >Minor formatting error here. -- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

Re: [PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

Am Donnerstag, 5. September 2013, 17:52:42 schrieb Dmitry Timoshkov: > Wolfgang Walter wrote: > > On Thursday 05 September 2013 10:42:40 you wrote: > > > Wolfgang Walter wrote: > > > > -ok(!res && GetLastError() == ERROR_IO_PENDING, "%d: > > > > WaitCommEvent > > > > error %d\n", i, GetLa

Re: [PATCH 1/5] use a correct timeout in test_waittxempty

Am Donnerstag, 5. September 2013, 17:51:18 schrieb Dmitry Timoshkov: > Wolfgang Walter wrote: > > > > When we send 17 bytes with 150 baud, no parity, one stop bit then > > > > we need to wait at least 17*10/150 seconds > 1000 ms > > > > > > Under Windows with both real COM-port and USB-serial cab

Re: [PATCH 5/5] ddraw: Enumerate DXT2 and DXT4

On 5 September 2013 10:42, Stefan Dösinger wrote: > Yes, we don't actually support those, but that's wined3d's problem, not > ddraw's. We do. The difference between DXT2/DXT3 and DXT4/DXT5 is just a convention wrt. storing pre-multiplied alpha or not, there's no difference in the actual encoding.

Re: [PATCH 3/5] ddraw/tests: Test DDCAPS2_TEXTUREMANAGE compatibility with other flags

On 5 September 2013 10:42, Stefan Dösinger wrote: > +if(DDSD->ddsCaps.dwCaps2 & DDSCAPS2_TEXTUREMANAGE) Minor formatting error here.

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

Wolfgang Walter wrote: > > > +if (res || (!res && GetLastError() == ERROR_IO_PENDING)) > > > +/* if data has been sent: wait for termination */ > > > +Sleep(timeout); > > > > I don't see such a problem with real COM-port and serial-USB cable > > under Windows or Linux here an

Re: [PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

Wolfgang Walter wrote: > On Thursday 05 September 2013 10:42:40 you wrote: > > Wolfgang Walter wrote: > > > -ok(!res && GetLastError() == ERROR_IO_PENDING, "%d: WaitCommEvent > > > error %d\n", i, GetLastError()); +ok(res || (!res && > > > GetLastError() == ERROR_IO_PENDING), "%d

Re: [PATCH 1/5] use a correct timeout in test_waittxempty

Wolfgang Walter wrote: > > > When we send 17 bytes with 150 baud, no parity, one stop bit then > > > we need to wait at least 17*10/150 seconds > 1000 ms > > > > Under Windows with both real COM-port and USB-serial cable this test takes > > no longer than 890 ms, usually it's even shorter like 8

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

On Thursday 05 September 2013 10:37:22 you wrote: > Wolfgang Walter wrote: > > +if (res || (!res && GetLastError() == ERROR_IO_PENDING)) > > +/* if data has been sent: wait for termination */ > > +Sleep(timeout); > > I don't see such a problem with real COM-port and serial-USB

Re: [PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

On Thursday 05 September 2013 10:42:40 you wrote: > Wolfgang Walter wrote: > > -ok(!res && GetLastError() == ERROR_IO_PENDING, "%d: WaitCommEvent > > error %d\n", i, GetLastError()); +ok(res || (!res && > > GetLastError() == ERROR_IO_PENDING), "%d: WaitCommEvent error %d\n", i, > >

Re: [PATCH 1/5] use a correct timeout in test_waittxempty

On Thursday 05 September 2013 10:32:15 Dmitry Timoshkov wrote: > Wolfgang Walter wrote: > > When we send 17 bytes with 150 baud, no parity, one stop bit then > > we need to wait at least 17*10/150 seconds > 1000 ms > > Under Windows with both real COM-port and USB-serial cable this test takes > n

Re: D3D command stream patches for testing

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-04 20:11, schrieb Prot Secret: > Hi, I am interested in your work, but after patching wine171 of > this patch and enabled csmt, i have seen this in SC2 > http://postimg.org/gallery/1w8y6jbg I use nvidia GTX 680 with > proprietary i386 nvidi