Re: gdi32: Fixed Rectangle() rotation problem with GM_ADVANCED graphics mode.

2013-09-03 Thread Ralf Habacker
On 29.08.2013 19:58, Alexandre Julliard wrote: Ralf Habacker writes: see http://bugs.winehq.org/show_bug.cgi?id=34381 --- dlls/gdi32/painting.c | 18 -- 1 Datei geändert, 16 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) This would have to be done in the drivers. done. Any

Re: [PATCH 1/3] riched20: Use codepage in ME_ToUnicode.

2013-09-03 Thread Jactry Zeng
Hi Phil, 2013/9/4 Phil Krylov > > Hello, > > >-ME_EndToUnicode(unicode, wszText); > >+unicode ? ME_EndToUnicode(1200, wszText) : ME_EndToUnicode(CP_ACP, wszText); > > Personally I dislike this stuff in C code. Especially when you could > make it shorter: > > ME_EndToUnicode(unicod

Re: Adding an appcompat/appshim bugzilla keyword

2013-09-03 Thread Dmitry Timoshkov
Austin English wrote: > Anastasius mentioned at > http://bugs.winehq.org/show_bug.cgi?id=32673#c6 that a keyword for > bugs that are caused by applications using broken/deprecated behavior > might be useful. I'm in favor of it, but wanted some more opinions > (and potentially a better naming sche

Adding an appcompat/appshim bugzilla keyword

2013-09-03 Thread Austin English
Anastasius mentioned at http://bugs.winehq.org/show_bug.cgi?id=32673#c6 that a keyword for bugs that are caused by applications using broken/deprecated behavior might be useful. I'm in favor of it, but wanted some more opinions (and potentially a better naming scheme). Comments/opinions? -- -Aus

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Charles Davis
On Sep 3, 2013, at 1:30 PM, Bruno Jesus wrote: > On Tue, Sep 3, 2013 at 4:26 PM, Charles Davis wrote: >>> You mean removing protocol.c and adding all content to socket.c? If >>> yes I would appreciate if you could do that because I don't have the >>> git skills and wouldn't now how to sort the f

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Bruno Jesus
On Tue, Sep 3, 2013 at 4:26 PM, Charles Davis wrote: >> You mean removing protocol.c and adding all content to socket.c? If >> yes I would appreciate if you could do that because I don't have the >> git skills and wouldn't now how to sort the functions inside socket.c. > It's not that hard. Just c

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Charles Davis
On Sep 3, 2013, at 12:37 PM, Bruno Jesus wrote: > On Tue, Sep 3, 2013 at 3:34 PM, Alexandre Julliard > wrote: >> Bruno Jesus <00cp...@gmail.com> writes: >> >>> On Tue, Sep 3, 2013 at 3:16 PM, Bruno Jesus <00cp...@gmail.com> wrote: On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard

Re: [PATCH 2/5] d3d9: Check for support before creating textures

2013-09-03 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-03 17:54, schrieb Henri Verbeet: > If that's the main issue, I could tell you that it will most > likely end up being renamed WINED3D_BIND_SHADER_RESOURCE at some > point, equivalent to the d3d10+ bind flags. That works for the name. The oth

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Bruno Jesus
On Tue, Sep 3, 2013 at 4:57 PM, Charles Davis wrote: > > On Sep 3, 2013, at 1:30 PM, Bruno Jesus wrote: > >> On Tue, Sep 3, 2013 at 4:26 PM, Charles Davis wrote: You mean removing protocol.c and adding all content to socket.c? If yes I would appreciate if you could do that because I don

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Bruno Jesus
On Tue, Sep 3, 2013 at 3:34 PM, Alexandre Julliard wrote: > Bruno Jesus <00cp...@gmail.com> writes: > >> On Tue, Sep 3, 2013 at 3:16 PM, Bruno Jesus <00cp...@gmail.com> wrote: >>> On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard >>> wrote: Bruno Jesus <00cp...@gmail.com> writes:

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Alexandre Julliard
Bruno Jesus <00cp...@gmail.com> writes: > On Tue, Sep 3, 2013 at 3:16 PM, Bruno Jesus <00cp...@gmail.com> wrote: >> On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard >> wrote: >>> Bruno Jesus <00cp...@gmail.com> writes: >>> try 2: Narrow the loop for the specified protocol Add a

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Bruno Jesus
On Tue, Sep 3, 2013 at 3:16 PM, Bruno Jesus <00cp...@gmail.com> wrote: > On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard > wrote: >> Bruno Jesus <00cp...@gmail.com> writes: >> >>> try 2: >>> Narrow the loop for the specified protocol >>> Add a new test for invalid sockets >> >> Considering wha

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Bruno Jesus
On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard wrote: > Bruno Jesus <00cp...@gmail.com> writes: > >> try 2: >> Narrow the loop for the specified protocol >> Add a new test for invalid sockets > > Considering what WSAEnumProtocols does, the loop doesn't seem necessary > at all. It will when WS

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Alexandre Julliard
Bruno Jesus <00cp...@gmail.com> writes: > try 2: > Narrow the loop for the specified protocol > Add a new test for invalid sockets Considering what WSAEnumProtocols does, the loop doesn't seem necessary at all. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 1/3] riched20: Use codepage in ME_ToUnicode.

2013-09-03 Thread Phil Krylov
Hello, >-ME_EndToUnicode(unicode, wszText); >+unicode ? ME_EndToUnicode(1200, wszText) : ME_EndToUnicode(CP_ACP, >wszText); Personally I dislike this stuff in C code. Especially when you could make it shorter: ME_EndToUnicode(unicode ? 1200 : CP_ACP, wszText) -- Ph.

Re: [PATCH 2/5] d3d9: Check for support before creating textures

2013-09-03 Thread Henri Verbeet
On 3 September 2013 14:07, Stefan Dösinger wrote: > I'm checking this in d3d9/d3d8/ddraw because we create textures for > everything nowadays, even stand-alone surfaces. For ddraw that's not true yet, but I think my preferred way to handle this would be to introduce a WINED3DUSAGE_TEXTURE usage fl

Re: [PATCH 2/5] d3d9: Check for support before creating textures

2013-09-03 Thread Henri Verbeet
On 3 September 2013 17:45, Stefan Dösinger wrote: > My main issue with a WINED3DUSAGE_TEXTURE flag is that > create_texture(USAGE_TEXTURE) seems a bit weird - we might as well > call it create_texture(USAGE_I_REALLY_MEAN_IT). > If that's the main issue, I could tell you that it will most likely en

Re: [PATCH 2/5] d3d9: Check for support before creating textures

2013-09-03 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-03 17:33, schrieb Henri Verbeet: > On 3 September 2013 14:07, Stefan Dösinger > wrote: >> I'm checking this in d3d9/d3d8/ddraw because we create textures >> for everything nowadays, even stand-alone surfaces. > For ddraw that's not true yet

Re: D3D command stream patches for testing

2013-09-03 Thread Rosanne DiMesio
On Tue, 3 Sep 2013 08:57:48 -0500 Rosanne DiMesio wrote: > Third patch doesn't apply: Nevermind. I figured out my mistake (overlooked the part about applying to 1.7.1). -- Rosanne DiMesio

Re: [PATCH 1/5] d3d8/tests: Add cnd instruction test.

2013-09-03 Thread Matteo Bruni
2013/9/3 Henri Verbeet : > On 2 September 2013 23:04, Matteo Bruni wrote: >> +float quad1[] = { >> +-1.0, -1.0, 0.1, 0.0,0.0,1.0, >> + 0.0, -1.0, 0.1, 1.0,0.0,1.0, >> +-1.0,0.0, 0.1, 0.0,1.0,0.0, >> + 0.0,0.0

Re: D3D command stream patches for testing

2013-09-03 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-03 15:57, schrieb Rosanne DiMesio: > On Mon, 02 Sep 2013 15:55:18 +0200 Stefan Dösinger > wrote: > > >> You can test the attached patches by applying them (git am >> /path/to/patches/*) > > Third patch doesn't apply: They are against Wi

Re: D3D command stream patches for testing

2013-09-03 Thread Rosanne DiMesio
On Mon, 02 Sep 2013 15:55:18 +0200 Stefan Dösinger wrote: > You can test the attached patches by applying them (git am > /path/to/patches/*) Third patch doesn't apply: Applying: wined3d: Don't mess with the device in buffer_create_buffer_object Applying: wined3d: Don't mess with the device in

Re: [PATCH 3/5] wined3d: Don't clamp texture lookups in the GLSL fixed function fragment pipe.

2013-09-03 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-03 13:41, schrieb Henri Verbeet:> It ends up being a performance bottleneck in some cases. This is > particularly visible in the 3DMark03 multi-texture fill-rate test, > in other cases the impact is usually a bit more modest. That's interest

Re: [PATCH try3] atl110: Added new DLL.

2013-09-03 Thread Qian Hong
On Tue, Sep 3, 2013 at 7:42 PM, Jacek Caban wrote: > Not really, good catch. We should make them consistent. Honestly, I'm > not sure which one is better. Both have their problems. Some functions > are forwarded, others are not, so having one debug channel would be > guarantee that we don't miss s

Re: [PATCH 3/5] wined3d: Don't clamp texture lookups in the GLSL fixed function fragment pipe.

2013-09-03 Thread Henri Verbeet
On 3 September 2013 13:31, Stefan Dösinger wrote: > The idea behind the clamps is that the fixed function pipeline is > generally limited to the [0.0;1.0] range. bbf313e7 added a test for > that, and there was e.g. 14706 (which doesn't contain much info tbh). > Yes, but that's for stage operations

Re: [PATCH try3] atl110: Added new DLL.

2013-09-03 Thread Jacek Caban
On 09/03/13 13:28, Qian Hong wrote: > On Tue, Sep 3, 2013 at 7:27 PM, Qian Hong wrote: >> Hi Jacek, we already have a debug channel atl100 for atl100.dll, but >> we currently use atl for both atl.dll and atl80.dll, do you think it >> is better to use atl for all, or one debug channel per each dll?

Re: [PATCH 3/5] wined3d: Don't clamp texture lookups in the GLSL fixed function fragment pipe.

2013-09-03 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-03 09:47, schrieb Henri Verbeet: > This originally came from the ARB fragment program implementation, > but I don't see a justification for clamping there either. For the > texture formats typically used with the fixed function pipe > clampi

Re: [PATCH try3] atl110: Added new DLL.

2013-09-03 Thread Qian Hong
On Tue, Sep 3, 2013 at 7:27 PM, Qian Hong wrote: > Hi Jacek, we already have a debug channel atl100 for atl100.dll, but > we currently use atl for both atl.dll and atl80.dll, do you think it > is better to use atl for all, or one debug channel per each dll? Oh, I just found dlls/atl100/atl_ax.c

Re: [PATCH try3] atl110: Added new DLL.

2013-09-03 Thread Qian Hong
> +WINE_DEFAULT_DEBUG_CHANNEL(atl); Hi Jacek, we already have a debug channel atl100 for atl100.dll, but we currently use atl for both atl.dll and atl80.dll, do you think it is better to use atl for all, or one debug channel per each dll?

Re: [PATCH 1/5] d3d8/tests: Add cnd instruction test.

2013-09-03 Thread Henri Verbeet
On 2 September 2013 23:04, Matteo Bruni wrote: > +float quad1[] = { > +-1.0, -1.0, 0.1, 0.0,0.0,1.0, > + 0.0, -1.0, 0.1, 1.0,0.0,1.0, > +-1.0,0.0, 0.1, 0.0,1.0,0.0, > + 0.0,0.0, 0.1, 1.0,1.0,0.0