Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=1970 Your paranoid andr

Re: Sort the AUTHORS file by their last names.

2013-09-02 Thread Tae Wong
Hentschel said: you would need to fix the generation and wanted to change the order of the AUTHORS file. The message you posted in Mon, Sep 2, 2013 at 3:24 PM has a text file (AUTHORS) containing all authors sorted alphabetically by their last names. -- Tae Wong

Re: [docs 2/2] winedev: Don't recommend a preprocessor check to comment out code

2013-09-02 Thread Frédéric Delanoy
On Mon, Sep 2, 2013 at 10:34 PM, André Hentschel wrote: > --- > en/winedev-coding.sgml | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) There's a typo in -block of code. +block of code and it makes sure the code get's maintained. get's => gets -- Frédéric Delanoy

Re: Sort the AUTHORS file by their last names.

2013-09-02 Thread André Hentschel
Am 02.09.2013 08:24, schrieb Tae Wong: > Add more authors from the GIT log. > > Commit this patch. > > > It seems you have some need to change the order of the AUTHORS file, but it's autogenerated, so you would need to fix the generation. And Michael already pointed out that this non-trivial p

Re: [PATCH 3/3] ws2_32: Implement get socket option SO_PROTOCOL_INFO

2013-09-02 Thread Alexandre Julliard
Bruno Jesus <00cp...@gmail.com> writes: > +items = WSAEnumProtocolsW(NULL, NULL, &listsize); > +if (items == SOCKET_ERROR && WSAGetLastError() == WSAENOBUFS && > + (buffer = HeapAlloc(GetProcessHeap(), 0, listsize))) > +{ > +items = WSAEnumProtocolsW(NULL, buffer, &listsi

Re: [2/2] kernel32/tests: Add a test to show that WaitCommEvent should fail if there is a pending wait.

2013-09-02 Thread Dmitry Timoshkov
Marvin wrote: > === w7pro64 (32 bit comm) === > comm.c:850: Test failed: WaitCommEvent failed with a timeout > comm.c:862: recovering after WAIT_TIMEOUT... > comm.c:874: Test failed: WaitCommEvent error 0 > comm.c:876: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 > comm.c:880: WaitCommE

Re: [2/2] kernel32/tests: Add a test to show that WaitCommEvent should fail if there is a pending wait.

2013-09-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=1957 Your paranoid andr

Re: [3/3] d3d9/tests: Test if IDirect3DSwapChain9Ex is available without IDirect3D9Ex

2013-09-02 Thread Henri Verbeet
On 30 August 2013 17:09, Michael Müller wrote: > > +/* Get the implicit swapchain */ > +hr = IDirect3DDevice9_GetSwapChain(device, 0, &swapchain); > +ok(SUCCEEDED(hr), "Failed to get the implicit swapchain (%08x)\n", hr); > +if (SUCCEEDED(hr)) > +{ > +hr = IDirect3DSwap

Re: [2/3] d3d9: Partial implementation of IDirect3DSwapChain9Ex (try 2)

2013-09-02 Thread Henri Verbeet
On 30 August 2013 17:09, Michael Müller wrote: > +static HRESULT WINAPI > d3d9_swapchain_GetLastPresentCount(IDirect3DSwapChain9Ex *iface, > +UINT *pLastPresentCount) > +{ > +FIXME("iface %p, pLastPresentCount %p, stub!\n", iface, > pLastPresentCount); > + > +if(pLastPresentCount