Re: [2/2] ntdll: Store full line status register in the internal structure, not just the TIOCSER_TEMT bit.

2013-08-29 Thread Dmitry Timoshkov
Dmitry Timoshkov wrote: > Printing complete lsr value in the log may help with diagnosing > test failures on Alexandre's machine. This patch is marked as 'Build failure' in the tracker, but I've checked it once again and compiles just fine here. What kind of build failure is that? -- Dmitry.

Re: Help to create a server request

2013-08-29 Thread Charles Davis
On Aug 29, 2013, at 6:43 PM, Bruno Jesus wrote: > Hi all, I need some help to continue my current wine work. > > In order to implement SO_PROTOCOL_INFO for getsockopt I need to > retrieve some information from the socket like its family and > protocol. > > I have searched for a few days and end

Help to create a server request

2013-08-29 Thread Bruno Jesus
Hi all, I need some help to continue my current wine work. In order to implement SO_PROTOCOL_INFO for getsockopt I need to retrieve some information from the socket like its family and protocol. I have searched for a few days and ended up with a solution I dislike so I had a better idea (at least

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-29 Thread Alexandre Julliard
André Hentschel writes: > Am 29.08.2013 23:15, schrieb Alexandre Julliard: >> André Hentschel writes: >> >>> Am 29.08.2013 19:52, schrieb André Hentschel: Hi, thank you both for the comments, i'll see what i can do. >>> >>> How about that? >> >> I don't see the point at all. There's

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-29 Thread André Hentschel
Am 29.08.2013 23:15, schrieb Alexandre Julliard: > André Hentschel writes: > >> Am 29.08.2013 19:52, schrieb André Hentschel: >>> Hi, >>> thank you both for the comments, i'll see what i can do. >> >> How about that? > > I don't see the point at all. There's no reason to add all that > complexit

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-29 Thread Alexandre Julliard
André Hentschel writes: > Am 29.08.2013 19:52, schrieb André Hentschel: >> Hi, >> thank you both for the comments, i'll see what i can do. > > How about that? I don't see the point at all. There's no reason to add all that complexity for a purely cosmetic detail. -- Alexandre Julliard julli...

Re: Embedding a HWND window into an X11 window

2013-08-29 Thread Vincent Povirk
> This solutions implies to modify wine, so do you think that this patch > or an improved version could be merged into wine? > Because I don't want to require a custom version of wine. Even if it were merged, that would not give you the ability to use it from within a Windows or winelib program. F

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-29 Thread André Hentschel
Am 29.08.2013 22:46, schrieb Charles Davis: > > On Aug 29, 2013, at 2:35 PM, André Hentschel wrote: > >> Am 29.08.2013 19:52, schrieb André Hentschel: >>> Hi, >>> thank you both for the comments, i'll see what i can do. >> >> How about that? > Much better, but... >> >> diff --git a/programs/wined

Re: Embedding a HWND window into an X11 window

2013-08-29 Thread Erich E. Hoover
On Thu, Aug 29, 2013 at 2:43 PM, André Hentschel wrote: > Am 29.08.2013 21:58, schrieb Erich E. Hoover: >> The "pipelight" guys put together a patch to support XEmbed: >> http://www.compholio.com/wine-compholio/download.php?file=0008-winex11-Add-minimal-XEmbed-client-support.patch >> >> That might

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-29 Thread Charles Davis
On Aug 29, 2013, at 2:35 PM, André Hentschel wrote: > Am 29.08.2013 19:52, schrieb André Hentschel: >> Hi, >> thank you both for the comments, i'll see what i can do. > > How about that? Much better, but... > > diff --git a/programs/winedbg/info.c b/programs/winedbg/info.c > index c0b86ba..0667

Re: Embedding a HWND window into an X11 window

2013-08-29 Thread André Hentschel
Am 29.08.2013 21:58, schrieb Erich E. Hoover: > The "pipelight" guys put together a patch to support XEmbed: > http://www.compholio.com/wine-compholio/download.php?file=0008-winex11-Add-minimal-XEmbed-client-support.patch > > That might do what he wants. might be interesting to clean/fix it up an

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-29 Thread André Hentschel
Am 29.08.2013 19:52, schrieb André Hentschel: > Hi, > thank you both for the comments, i'll see what i can do. How about that? diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/module.c index 6bea436..ed1d9c0 100644 --- a/dlls/dbghelp/module.c +++ b/dlls/dbghelp/module.c @@ -33,6 +33,7 @@ WINE_

Re: Embedding a HWND window into an X11 window

2013-08-29 Thread Erich E. Hoover
The "pipelight" guys put together a patch to support XEmbed: http://www.compholio.com/wine-compholio/download.php?file=0008-winex11-Add-minimal-XEmbed-client-support.patch That might do what he wants. Best, Erich On Thu, Aug 29, 2013 at 1:33 PM, Vincent Povirk wrote: > The systray/notification

Re: Embedding a HWND window into an X11 window

2013-08-29 Thread Vincent Povirk
The systray/notification area code has to do that: http://source.winehq.org/source/dlls/winex11.drv/systray.c#L620 I don't think it can be done without modifying winex11.drv.

Re: patch:kernel32

2013-08-29 Thread Charles Davis
On Aug 29, 2013, at 8:15 AM, matyapiro31 wrote: > > <0001-kernel32-change-for-loop-to-optimize.patch><0002-kernel32-change-for-loop-to-optimize.patch> One patch per email, please. Also, the subject should be more descriptive. The first one doesn't look much better than the second one (which was

Re: gdi32: Fixed Rectangle() rotation problem with GM_ADVANCED graphics mode.

2013-08-29 Thread Alexandre Julliard
Ralf Habacker writes: > see http://bugs.winehq.org/show_bug.cgi?id=34381 > --- > dlls/gdi32/painting.c | 18 -- > 1 Datei geändert, 16 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) This would have to be done in the drivers. -- Alexandre Julliard julli...@winehq.org

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-29 Thread André Hentschel
Hi, thank you both for the comments, i'll see what i can do.

Re: [PATCH 2/2] ddraw/tests: Test WM_ACTIVATEAPP messages generated by SetCooperativeLevel

2013-08-29 Thread Henri Verbeet
On 29 August 2013 11:14, Stefan Dösinger wrote: > +BOOL activateapp_received; > +IDirectDraw *activateapp_ddraw; > +HWND activateapp_window; > +DWORD activateapp_coop_level; > + I think those should be static, and you'll probably want to put them in a structure.

Re: my patch was wrong at dlls/kernel32/computernames.c

2013-08-29 Thread Marcus Meissner
On Thu, Aug 29, 2013 at 11:31:06PM +0900, matyapiro31 wrote: > From > if ( isalnumW ( wc ) ) return wc; > for ( i = 0; i < 17; i++ ) > To > if ( isalnumW ( wc ) ) return wc; > for ( i = 0; i < 16; i++ ) > and the original version was wrong,too. > It counts the NULL of the end. Thats why you should

my patch was wrong at dlls/kernel32/computernames.c

2013-08-29 Thread matyapiro31
From if ( isalnumW ( wc ) ) return wc; for ( i = 0; i < 17; i++ ) To if ( isalnumW ( wc ) ) return wc; for ( i = 0; i < 16; i++ ) and the original version was wrong,too. It counts the NULL of the end.

Re: patch:kernel32

2013-08-29 Thread Bruno Jesus
On Thu, Aug 29, 2013 at 11:15 AM, matyapiro31 wrote: The patch could have a better subject =) > +unix_len=sizeof(unix_vars)/sizeof(unix_vars[0]; Missing the closing ) ? Will this compile? > -for ( i = 0; i < sizeof (special) / sizeof (WCHAR); i++ ) > +for ( i = 0; i < 17; i++ ) I gu

Re: patch:try 2 of adding wine ja mannual

2013-08-29 Thread Akihiro Sagawa
On Wed, 28 Aug 2013 20:29:43 +0900, �� wrote: > diff --git a/loader/Makefile.in b/loader/Makefile.in > index a7ab893..bc11378 100644 > --- a/loader/Makefile.in > +++ b/loader/Makefile.in > @@ -20,14 +20,16 @@ MANPAGE = wine.man > EXTRA_MANPAGES = \ > wine.de.man \ > wine.fr.man \ >

Re: wininet: Replacing a header with an empty value deletes it.

2013-08-29 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://newtestbot.winehq.org/JobDetails.pl?Key=1918 Your paranoid andro

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-29 Thread Ralf Habacker
On 28.08.2013 12:54, Hans Leidekker wrote: On Wed, 2013-08-28 at 12:21 +0200, Ralf Habacker wrote: diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec index 36ba13f..1eed5ae 100644 --- a/dlls/iphlpapi/iphlpapi.spec +++ b/dlls/iphlpapi/iphlpapi.spec @@ -6,6 +6,7 @@ @ stdcall

Embedding a HWND window into an X11 window

2013-08-29 Thread Alexandre Bique
Hi, How could I embed a HWND window created with CreateWindow() into an X11 window? Thanks! :-) -- Alexandre Bique

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-29 Thread Wolfgang Walter
Am Donnerstag, 29. August 2013, 10:47:46 schrieb Dmitry Timoshkov: > Wolfgang Walter wrote: > > I think that happens: > > > > * application writes data to com port. > > * all is written, serial buffer is empty > > * application calls WaitCommEvent() > > * wait_on() is called > > * wait_on() call

Re: [1/2] server: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port. Take 2.

2013-08-29 Thread Dmitry Timoshkov
Dmitry Timoshkov wrote: > Based on a patch of Wolfgang Walter. Is there anything wrong with this patch? -- Dmitry.