Re: ntdll: Store all 'comClass' attributes

2013-08-26 Thread Nikolay Sivov
On 8/26/2013 19:04, Alexandre Julliard wrote: Nikolay Sivov writes: +while (min <= max) +{ +int n, c; + +n = (min+max)/2; + +c = strncmpW(olemisc_values[n].name, str, len); strncmp isn't enough. Right, thanks.

RE: Does auto-apt work to get wine dependencies in source code?

2013-08-26 Thread Hugh McMaster
On Monday, 26 August 2013 5:20 AM, Maarten Lankhorst wrote: >Op 25-08-13 14:09, Susan Cragin schreef: >> Was thinking of running some tests but the list of dependencies on the >> website seems outdated, apt-get build-dep does not work. >Is that with the ubuntu-wine ppa enabled? The Wine PPA isn'

Re: [PATCH 1/3] ws2_32: Implement SIO_ADDRESS_LIST_CHANGE with NotifyAddrChange (try 2).

2013-08-26 Thread Bruno Jesus
On Mon, Aug 5, 2013 at 1:24 AM, Erich E. Hoover wrote: > The attached patch is the next step in the series of fixes for > Silverlight/PlayReady under Wine. This particular patch does not > impact Netflix, but it does impact a number of other PlayReady > streaming services (and a variety of non-str

Re: Does auto-apt work to get wine dependencies in source code?

2013-08-26 Thread Susan Cragin
>> Was thinking of running some tests but the list of dependencies on the website seems outdated, apt-get build-dep does not work.>Is that with the ubuntu-wine ppa enabled?There are two answers to that question, surprisingly. (1) bitboxIn the instructions it looks like the wine ppa repository can b

Re: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.

2013-08-26 Thread Wolfgang Walter
Am Montag, 26. August 2013, 19:55:04 schrieben Sie: > Wolfgang Walter writes: > > Am Montag, 26. August 2013, 17:13:46 schrieb Alexandre Julliard: > >> You probably don't want to fail just because there's no unix fd. > > > > What is the correct behaviour if there ist no such handle? Should I only

Re: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.

2013-08-26 Thread Alexandre Julliard
Wolfgang Walter writes: > Am Montag, 26. August 2013, 17:13:46 schrieb Alexandre Julliard: >> >> You probably don't want to fail just because there's no unix fd. > > What is the correct behaviour if there ist no such handle? Should I only fail > in the case FD_FILE_SERIAL ? You'd want to still

Re: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.

2013-08-26 Thread Wolfgang Walter
Am Montag, 26. August 2013, 17:13:46 schrieb Alexandre Julliard: > Wolfgang Walter writes: > > @@ -2749,19 +2752,46 @@ NTSTATUS WINAPI NtFlushBuffersFile( HANDLE hFile, > > IO_STATUS_BLOCK* IoStatusBlock> > > { > > > > NTSTATUS ret; > > HANDLE hEvent = NULL; > > > > - > > -SERVE

Re: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.

2013-08-26 Thread Alexandre Julliard
Wolfgang Walter writes: > @@ -2749,19 +2752,46 @@ NTSTATUS WINAPI NtFlushBuffersFile( HANDLE hFile, > IO_STATUS_BLOCK* IoStatusBlock > { > NTSTATUS ret; > HANDLE hEvent = NULL; > - > -SERVER_START_REQ( flush_file ) > -{ > -req->handle = wine_server_obj_handle( hFile );

Re: ntdll: Store all 'comClass' attributes

2013-08-26 Thread Alexandre Julliard
Nikolay Sivov writes: > +while (min <= max) > +{ > +int n, c; > + > +n = (min+max)/2; > + > +c = strncmpW(olemisc_values[n].name, str, len); strncmp isn't enough. -- Alexandre Julliard julli...@winehq.org

Re: questions to your commit "wineps.drv: Allow for vertical text printing!"

2013-08-26 Thread Aric Stewart
Hello Wolfgang, Thanks for the review. On 8/24/13 2:16 PM, Wolfgang Walter wrote: > Hello Aric, > > I read commit 745e7c93c9042f62460f181daaa1f05645560b41 (wineps.drv: Allow for > vertical text printing.) and I have some questions: > > > 1) You added the parameter vertical to PSDRV_WriteSetFon

Re: [PATCH 2/7] wined3d: Use PBOs for dynamic volumes (try 2)

2013-08-26 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-26 16:16, schrieb Matteo Bruni: > 2013/8/26 Stefan Dösinger : >> Try 2: *) Require only GPU access for buffers *) Reduce number of >> checkGLcall invocations *) Remove a return from an ERR case --- >> dlls/wined3d/utils.c | 1 +

Re: [PATCH 2/7] wined3d: Use PBOs for dynamic volumes (try 2)

2013-08-26 Thread Matteo Bruni
2013/8/26 Stefan Dösinger : > Try 2: > *) Require only GPU access for buffers > *) Reduce number of checkGLcall invocations > *) Remove a return from an ERR case > --- > dlls/wined3d/utils.c | 1 + > dlls/wined3d/volume.c | 168 > - > d

Re: [patch fix]for 98152 and 98151,the encoding type was wrong.

2013-08-26 Thread Akihiro Sagawa
On Sun, 25 Aug 2013 23:13:53 +0900, matyapiro31 wrote: > The first one is > 0001-add-japanese-man-page-of-wine.patch > the second one is > 0001-last-change-of-my-translation-of-man-page.patch > Please cancel 98152 and 98151and try those two. These translations are outdated. The file seems to be ba

Re: Does auto-apt work to get wine dependencies in source code?

2013-08-26 Thread Maarten Lankhorst
Op 25-08-13 14:09, Susan Cragin schreef: > Hello, > Was thinking of running some tests but the list of dependencies on the > website seems outdated, apt-get build-dep does not work. Is that with the ubuntu-wine ppa enabled?

Re: [2/3] server: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.

2013-08-26 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> It's a blocking call, you can't do that on the server side. > > Can then something like in the patch from Wolfgang Walter be done > instead? Something like that, yes. -- Alexandre Julliard julli...@winehq.org

Re: [2/3] server: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.

2013-08-26 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > It's a blocking call, you can't do that on the server side. Can then something like in the patch from Wolfgang Walter be done instead? -- Dmitry.

Re: [2/3] server: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.

2013-08-26 Thread Wolfgang Walter
Hello Dmitry, we had this problem, too. I sent a patch to wine-devel some time ago (I think 2008). It had the same flaw as yours. I sent a different patch after Alexandre gave me the same answer. I then posted 2009 an different one. It did not make it into wine, though. I don't know why as ther

Re: [2/3] server: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.

2013-08-26 Thread Alexandre Julliard
Dmitry Timoshkov writes: > MSDN for FlushFileBuffers says: > Flushes the buffers of a specified file and causes all buffered data to be > written to a file. > > Linux man page says: > tcdrain() waits until all output written to the object referred to by fd has > been transmitted. It's a blocking