Re: [4/6] kernel32: Make serial tests self-contained.

2013-08-20 Thread Saulius Krasuckas
* On Thu, 15 Aug 2013, Dmitry Timoshkov wrote: > dlls/kernel32/tests/comm.c | 284 > ++--- > 1 file changed, 167 insertions(+), 117 deletions(-) ... > --- a/dlls/kernel32/tests/comm.c > +++ b/dlls/kernel32/tests/comm.c > @@ -1486,7 +1588,7 @@ static void

Re: oledb32: Add IDataSourceLocator support (try 5)

2013-08-20 Thread Nikolay Sivov
On 8/21/2013 10:16, Alistair Leslie-Hughes wrote: Hi, Updated naming. You updated method names only, what's left : +typedef struct DataSourceImpl +HRESULT create_data_source(IUnknown *outer, void **obj) +static const IDataSourceLocatorVtbl DataSourceVtbl = Also you most likely don't need thes

Re: oledb32: Add IDataSourceLocator support (try 4)

2013-08-20 Thread Nikolay Sivov
On 8/21/2013 09:15, Alistair Leslie-Hughes wrote: Hi, Use helper functions for memory Changelog: oledb32: Add IDataSourceLocator support Best Regards Alistair Leslie-Hughes It looks okay, but I suggest to fix a naming: +typedef struct DataSourceImpl +{ +IDataSourceLocator

Re: Willing to join Wine

2013-08-20 Thread Austin English
On Tue, Aug 20, 2013 at 3:13 AM, Priyank Bhatt wrote: > I want to work for Wine . I'm a third year undergraduate Student , I > have done my elimentary course on machine learning algorithm . I am > also familiar with C/C++ and some what of Python . > Please suggest what all do I need to learn or re

Re: winmm: fix WOD_Open() WAVE_MAPPER no-device case.

2013-08-20 Thread Andrew Eikum
On Tue, Aug 20, 2013 at 07:06:13PM +0200, Fabrice Bauzac wrote: > +if (g_inmmdevices_count == 0) { > +return MMSYSERR_BADDEVICEID; > +} Looks like the indentation is bad here. Also please submit the patch to wine-patches. Patches aren't picked up from wine-devel. Thanks for t

Re: winmm: fix WOD_Open() WAVE_MAPPER no-device case.

2013-08-20 Thread Fabrice Bauzac
Hello, Indeed, WID_Open certainly suffers from the same problem. Here is the patch for both. >From 51cee06af9f5901ca7310aad1077d4b07472da1e Mon Sep 17 00:00:00 2001 From: Fabrice Bauzac Date: Tue, 20 Aug 2013 05:37:53 +0200 Subject: winmm: fix WOD_Open() and WID_Open() WAVE_MAPPER no-device cas

Re: [PATCH 2/4] oleaut32: Implement ICreateTypeInfo::SetTypeDescAlias

2013-08-20 Thread Piotr Caban
On 08/20/13 16:57, Andrew Eikum wrote: @@ -10530,8 +10541,28 @@ static HRESULT WINAPI ICreateTypeInfo2_fnSetTypeDescAlias(ICreateTypeInfo2 *ifac +This->cbSizeInstance = VARIANT_DataSize(This->tdescAlias->vt, This->pTypeLib->ptr_size); +if(!This->cbSizeInstance){ +FIXME("Wrong si

Re: Sort the AUTHORS file by their last names.

2013-08-20 Thread Tae Wong
Non-Dutch names like Van Buggenhaut can be placed under V instead. -- Tae Wong

Re: winmm: fix WOD_Open() WAVE_MAPPER no-device case.

2013-08-20 Thread Andrew Eikum
On Tue, Aug 20, 2013 at 05:57:34AM +0200, Fabrice Bauzac wrote: > Hello, > > This patch intends to fix the bug: > http://bugs.winehq.org/show_bug.cgi?id=34305 > > The bug: basically, when there is no sound device and the user tries > to WOD_Open() the WAVE_MAPPER pseudodevice, the code calls read

Re: [PATCH 1/5] wined3d: Add a function for allocating aligned resource memory (try 2)

2013-08-20 Thread Henri Verbeet
On 20 August 2013 13:16, Stefan Dösinger wrote: > Am 2013-08-20 13:12, schrieb Henri Verbeet: >> Somewhat related, I don't think there's really a reason to have >> both "allocatedMemory" and "heap_memory" anymore. It should >> probably just be called "sysmem". That's a cleanup that doesn't >> nece

Re: [PATCH 1/5] wined3d: Add a function for allocating aligned resource memory (try 2)

2013-08-20 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-20 13:12, schrieb Henri Verbeet: > I think this should either be called > wined3d_resource_allocate_sysmem() and live in resource.c, or > accept any np2 alignment and be called something along the lines of > wined3d_memalign(). The former

Re: [PATCH 1/5] wined3d: Add a function for allocating aligned resource memory (try 2)

2013-08-20 Thread Henri Verbeet
On 20 August 2013 12:07, Stefan Dösinger wrote: > +void *wined3d_alloc_resource_mem(SIZE_T size) > +{ > +void **p; > +SIZE_T align = RESOURCE_ALIGNMENT - 1 + sizeof(*p); > +void *mem; > + > +if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size + align))) > +return

Willing to join Wine

2013-08-20 Thread Priyank Bhatt
I want to work for Wine . I'm a third year undergraduate Student , I have done my elimentary course on machine learning algorithm . I am also familiar with C/C++ and some what of Python . Please suggest what all do I need to learn or read so as to start contributing to the open source community of

Re: kernel32: Fix required buffer length for locale values from registry

2013-08-20 Thread Alexandre Julliard
Nikolay Sivov writes: > http://bugs.winehq.org/show_bug.cgi?id=32169 > > Locale info to override is stored as REG_SZ and supposed to be > null-terminated, They are supposed to, but it's not guaranteed. The code should be able to cope with non-terminated strings. -- Alexandre Julliard julli...@

Re: oledb32: Implement IErrorRecord AddErrorRecord

2013-08-20 Thread Alistair Leslie-Hughes
On 20/08/2013 7:29 PM, Nikolay Sivov wrote: On 8/20/2013 13:21, Alistair Leslie-Hughes wrote: Hi, Yes we do just take the pointer (pErrorInfo) passed in. MSDN states that the caller responsible for this memory. It means caller could free it at any time (or it could be a stack variable), so you

Re: oledb32: Implement IErrorRecord AddErrorRecord

2013-08-20 Thread Nikolay Sivov
On 8/20/2013 13:21, Alistair Leslie-Hughes wrote: Hi, Yes we do just take the pointer (pErrorInfo) passed in. MSDN states that the caller responsible for this memory. It means caller could free it at any time (or it could be a stack variable), so you have to make a deep copy. Changelog:

Re: riched20: Use \ulnone instead of \ul0 for no underline.

2013-08-20 Thread Huw Davies
On Mon, Aug 19, 2013 at 05:38:13PM -0500, Vincent Povirk wrote: > Testing on Windows (by saving rtf documents with wordpad and viewing > them with notepad) shows that it uses \ulnone instead of \ul0 to end > underline. Wine and Windows are both able to read either one. I think these are symonyms a