Re: Re: [PATCH 1/6] msvcrt: Use LOCK_ENV locking in _chdrive and do validatation of input argument.

2013-08-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26722 Your paranoid android

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Tae Wong
Non-Dutch names starting with a last name of van can be placed under v and d can be placed under d. -- Tae Wong

Re: PLEASE add bug links!

2013-08-16 Thread Ken Sharp
On 16/08/13 22:02, Rosanne DiMesio wrote: Dan Kegel. http://kegel.com/wine/unlinked.html Good find! :-)

Re: PLEASE add bug links!

2013-08-16 Thread Rosanne DiMesio
On Fri, 16 Aug 2013 20:51:19 +0100 Ken Sharp wrote: > > I believe someone managed to run a script to find the unlinked bugs. I > can't remember who it was now, sadly, and I don't know if it was > server-side, which would obviously be quicker. > > Dan Kegel. http://kegel.com/wine/unlinked.htm

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Ken Sharp
This is clearly going nowhere.

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Tae Wong
Particles "van" and "de" can be parts of last name for non-Dutch persons. On 8/17/13, Michael Stefaniuc wrote: > On 08/16/2013 09:33 PM, Tae Wong wrote: >> You have to manually update it by adding all authors from the GIT log. >> >> The attachment is here at first message. > That one you did is n

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Michael Stefaniuc
On 08/16/2013 09:33 PM, Tae Wong wrote: > You have to manually update it by adding all authors from the GIT log. > > The attachment is here at first message. That one you did is not correct either: - I see some Spanish "double" last names sorted by the 2nd one instead of the first. - In Dutch th

Re: PLEASE add bug links!

2013-08-16 Thread Ken Sharp
On 16/08/13 19:15, Vincent Povirk wrote: If we really want the links to be up to date, we should figure out a way to make them show up on bugzilla, without clicking through to a search. Otherwise, the only time someone is likely to notice a bug that hasn't been linked is if they're looking for it

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Tae Wong
You have to manually update it by adding all authors from the GIT log. The attachment is here at first message. -- Tae Wong

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Frédéric Delanoy
On Fri, Aug 16, 2013 at 6:51 PM, Tae Wong wrote: > Older revisions sort them by last name instead of text line. > > Your file contains all of the names sorted on last name. > > The current revision contains all names sorted in first name, not last name. The old revisions were updated manually. Th

Re: [website] Added templates/zh-cn/cvs.template translation

2013-08-16 Thread Frédéric Delanoy
On Fri, Aug 16, 2013 at 6:31 PM, Hin-Tak Leung wrote: > > > I believe he did give his real name. "Xu" is a common surname in China (Not > sure about "Xin", probably also a less common one!). Most Chinese names > consist > of 3 syllables, a single-syllable surname and a double-syllable first nam

Re: [PATCH 1/6] msvcrt: Use LOCK_ENV locking in _chdrive and do validatation of input argument.

2013-08-16 Thread Alexandre Julliard
Kai Tietz writes: > 2013/8/16 Alexandre Julliard : >> Kai Tietz writes: >> >>> diff --git a/dlls/msvcrt/dir.c b/dlls/msvcrt/dir.c >>> index 44802b3..3b9e3c7 100644 >>> --- a/dlls/msvcrt/dir.c >>> +++ b/dlls/msvcrt/dir.c >>> @@ -365,14 +365,25 @@ int CDECL MSVCRT__chdrive(int newdrive) >>> { >>>

Re: PLEASE add bug links!

2013-08-16 Thread Vincent Povirk
If we really want the links to be up to date, we should figure out a way to make them show up on bugzilla, without clicking through to a search. Otherwise, the only time someone is likely to notice a bug that hasn't been linked is if they're looking for it specifically and happened to start their s

Re: [PATCH 1/6] msvcrt: Use LOCK_ENV locking in _chdrive and do validatation of input argument.

2013-08-16 Thread Kai Tietz
2013/8/16 Alexandre Julliard : > Kai Tietz writes: > >> diff --git a/dlls/msvcrt/dir.c b/dlls/msvcrt/dir.c >> index 44802b3..3b9e3c7 100644 >> --- a/dlls/msvcrt/dir.c >> +++ b/dlls/msvcrt/dir.c >> @@ -365,14 +365,25 @@ int CDECL MSVCRT__chdrive(int newdrive) >> { >>WCHAR buffer[] = {'A', ':',

Re: ntdll: empty APC queue before starting an application

2013-08-16 Thread Alexandre Julliard
Andrey Turkin writes: > --- > dlls/ntdll/loader.c | 3 +++ > dlls/ntdll/ntdll.spec | 2 +- > dlls/ntdll/sync.c | 16 > 3 files changed, 20 insertions(+), 1 deletion(-) > > diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c > index b3abad0..1eaa123 100644 > --- a/dlls

Re: [PATCH 1/6] msvcrt: Use LOCK_ENV locking in _chdrive and do validatation of input argument.

2013-08-16 Thread Alexandre Julliard
Kai Tietz writes: > diff --git a/dlls/msvcrt/dir.c b/dlls/msvcrt/dir.c > index 44802b3..3b9e3c7 100644 > --- a/dlls/msvcrt/dir.c > +++ b/dlls/msvcrt/dir.c > @@ -365,14 +365,25 @@ int CDECL MSVCRT__chdrive(int newdrive) > { >WCHAR buffer[] = {'A', ':', 0}; > > + if (newdrive < 1 || newdriv

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Tae Wong
Older revisions sort them by last name instead of text line. Your file contains all of the names sorted on last name. The current revision contains all names sorted in first name, not last name. -- Tae Wong

Re: [website] Added templates/zh-cn/cvs.template translation

2013-08-16 Thread Hin-Tak Leung
On Fri, 16/8/13, Frédéric Delanoy wrote: Subject: Re: [website] Added templates/zh-cn/cvs.template translation To: "xulixin" Cc: "Wine Devel" Date: Friday, 16 August, 2013, 10:59 On Fri, Aug 16, 2013 at 8:13 AM, xulixin wrote: > From 86026

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Michael Stefaniuc
On 08/16/2013 05:40 PM, Tae Wong wrote: > In the GIT tree, the AUTHORS file is sorted on first names. Wrong. It is sorted by the text line. The first word on the line can be the first or lastname, depending what the author used. bye michael

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Tae Wong
In the GIT tree, the AUTHORS file is sorted on first names. -- Tae Wong

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Michael Stefaniuc
On 08/16/2013 04:42 PM, Tae Wong wrote: > Julliard said that it should feel free to provide a script that sorts > by last name. > > You want to do this. Careful. It is a trap. He is fine with it if it is done *right*. Figuring out what the last name is is a hard problem. bye michael

Re: PLEASE add bug links!

2013-08-16 Thread Frédéric Delanoy
On Fri, Aug 16, 2013 at 2:46 PM, Ken Sharp wrote: > There's little point in my continually asking users to add bug links to the > AppDB if maintainers and/or administrators don't bother themselves. > > It takes longer to create a bug report than it does to link it to the > database. It really isn'

Re: [website] Update git URL

2013-08-16 Thread Frédéric Delanoy
On Fri, Aug 16, 2013 at 3:59 PM, Michael Stefaniuc wrote: > On 08/16/2013 03:32 PM, Frédéric Delanoy wrote: >> --- >> templates/en/cvs.template | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/templates/en/cvs.template b/templates/en/cvs.template >> index 202cf60..3

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Tae Wong
Julliard said that it should feel free to provide a script that sorts by last name. You want to do this. -- Tae Wong

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Alexandre Julliard
Tae Wong writes: > Wow! It is sorted on the first names, not on the last names... > > You want to apply the patch. When you sort developers in alphabetical > order, you must choose first names or last names. It's autogenerated, so it's simply sorted textually. Feel free to provide a script that

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Tae Wong
Wow! It is sorted on the first names, not on the last names... You want to apply the patch. When you sort developers in alphabetical order, you must choose first names or last names. You want to sort it by last names. This patch contains several names with particles (de Saedeleer, Van Assche...)

Re: [website] Update git URL

2013-08-16 Thread Michael Stefaniuc
On 08/16/2013 03:32 PM, Frédéric Delanoy wrote: > --- > templates/en/cvs.template | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/templates/en/cvs.template b/templates/en/cvs.template > index 202cf60..300b9e4 100644 > --- a/templates/en/cvs.template > +++ b/templates/

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Ken Sharp
On 16/08/13 14:46, Tae Wong wrote:> The AUTHORS file have all developers from the GIT log which were > sorted on their first names. > > This patch will switch the sort order from first to last names. This isn't how the AUTHORS file is generated. http://source.winehq.org/git/wine.git/commit/5da3

Re: [website] Added templates/zh-cn/cvs.template translation

2013-08-16 Thread Frédéric Delanoy
On Fri, Aug 16, 2013 at 3:21 PM, Frédéric Delanoy wrote: > On Fri, Aug 16, 2013 at 12:28 PM, GOUJON Alexandre > wrote: >> On 08/16/2013 11:59 AM, Frédéric Delanoy wrote: >>> Also, lxr.linux.no isn't used anymore, so the original file would need >>> to be updated beforehand. >>> >> Do you mean ht

Re: [website] Added templates/zh-cn/cvs.template translation

2013-08-16 Thread Frédéric Delanoy
On Fri, Aug 16, 2013 at 12:28 PM, GOUJON Alexandre wrote: > On 08/16/2013 11:59 AM, Frédéric Delanoy wrote: >> Also, lxr.linux.no isn't used anymore, so the original file would need >> to be updated beforehand. >> > Do you mean http://source.winehq.org/{source,ident,search,find} is not > accurate

PLEASE add bug links!

2013-08-16 Thread Ken Sharp
There's little point in my continually asking users to add bug links to the AppDB if maintainers and/or administrators don't bother themselves. It takes longer to create a bug report than it does to link it to the database. It really isn't that hard. I've added hundreds over the past few week

Re: [PATCH 01/11] widl: New option --rt for enabling rt's specific language extensions.

2013-08-16 Thread Kai Tietz
Hello, I attached adjusted patch (including man-page entry). Regards, Kai From ebb6cb67764e3a383edddb4b78e40dc8140736ba Mon Sep 17 00:00:00 2001 From: Kai Tietz Date: Thu, 8 Aug 2013 12:29:33 +0200 Subject: [PATCH 01/12] widl: New option --rt for enabling rt's specific language extensions. ---

Re: [1/3] apphelp: Add definitions

2013-08-16 Thread GOUJON Alexandre
On 08/16/2013 12:50 PM, Mislav Blazevic wrote: Pardon my ignorance... What does it mean to bottom post? I am new to mailing lists. GIYF : http://en.wikipedia.org/wiki/Posting_style#Bottom-posting

Re: comsvcs: Add dll comsvcs (resend)

2013-08-16 Thread André Hentschel
Am 16.08.2013 12:39, schrieb Alistair Leslie-Hughes: > Hi, > > > Changelog: > comsvcs: Add dll comsvcs > > > Best Regards > Alistair Leslie-Hughes you missed the configure.ac part?

Re: [PATCH 01/11] widl: New option --rt for enabling rt's specific language extensions.

2013-08-16 Thread Alexandre Julliard
Kai Tietz writes: > Due line wrap, I sent patch as attachment. > > Kai > > From 3fcedb770626535b56a789467951a4c9be5f08dc Mon Sep 17 00:00:00 2001 > From: Kai Tietz > Date: Thu, 8 Aug 2013 12:29:33 +0200 > Subject: [PATCH 01/11] widl: New option --rt for enabling rt's specific > language extensi

Re: [3/3] ntdll/tests: Add a bunch of overlapped IO tests for files.

2013-08-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26708 Your paranoid android

Re: [2/3] ntdll/tests: Use official path for temporary files instead of current directory.

2013-08-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26707 Your paranoid android

Re: [1/3] apphelp: Add definitions

2013-08-16 Thread Mislav Blazevic
Pardon my ignorance... What does it mean to bottom post? I am new to mailing lists. I thought you asked that because you knew why it won't work. I don't know how it will work until I do it. If there is reason why it cannot work, *please* tell me before I write any more code. On Fri, Aug 16, 2013

Re: [1/3] apphelp: Add definitions

2013-08-16 Thread Dmitry Timoshkov
Mislav Blazevic wrote: > Same way its used in windows, obviously... Does wine somehow explicitly > forbids applying binary patches on loaded executables? Can you please tell > me which feature of apphelp won't work on wine? You didn't actually answer the question and for some reason ignored > >

Re: [1/3] apphelp: Add definitions

2013-08-16 Thread Mislav Blazevic
Same way its used in windows, obviously... Does wine somehow explicitly forbids applying binary patches on loaded executables? Can you please tell me which feature of apphelp won't work on wine? On Fri, Aug 16, 2013 at 12:20 PM, Dmitry Timoshkov wrote: > [please bottom post when replying] > > M

Re: [3/3] ntdll/tests: Add a bunch of overlapped IO tests for files.

2013-08-16 Thread Dmitry Timoshkov
Marvin wrote: > === WXPX64 (64 bit file) === > file.c:1791: Test failed: expected STATUS_SUCCESS, got 0 > file.c:1817: Test failed: expected STATUS_SUCCESS, got 0 > file.c:1844: Test failed: expected STATUS_END_OF_FILE, got 0xc011 > file.c:1855: Test failed: expected STATUS_END_OF_FILE, got 0

Re: [website] Added templates/zh-cn/cvs.template translation

2013-08-16 Thread GOUJON Alexandre
On 08/16/2013 11:59 AM, Frédéric Delanoy wrote: On Fri, Aug 16, 2013 at 8:13 AM, xulixin wrote: From 860262aed3d58f42012e6dd5264eb29bd29deffb Mon Sep 17 00:00:00 2001 From: xulixin Date: Fri, 16 Aug 2013 13:56:36 +0800 Subject: add templates/zh-cn/cvs.template --- templates/zh-cn/cvs.templat

Re: [1/3] apphelp: Add definitions

2013-08-16 Thread Dmitry Timoshkov
[please bottom post when replying] Mislav Blazevic wrote: > It mostly comes from feeding SdbTagToString all valid inputs. Some > constants are from msdn. I do not know of a *real* program calling this API > other than winapi itself. kernel32 uses it for backwards compatibility. I > wrote plenty

Re: [website] Added templates/zh-cn/cvs.template translation

2013-08-16 Thread Frédéric Delanoy
On Fri, Aug 16, 2013 at 8:13 AM, xulixin wrote: > From 860262aed3d58f42012e6dd5264eb29bd29deffb Mon Sep 17 00:00:00 2001 > From: xulixin > Date: Fri, 16 Aug 2013 13:56:36 +0800 > Subject: add templates/zh-cn/cvs.template > > --- > templates/zh-cn/cvs.template | 6 +++--- > 1 file changed, 3 insert

Re: [1/3] apphelp: Add definitions

2013-08-16 Thread Mislav Blazevic
It mostly comes from feeding SdbTagToString all valid inputs. Some constants are from msdn. I do not know of a *real* program calling this API other than winapi itself. kernel32 uses it for backwards compatibility. I wrote plenty of tests[1], parsed shim database files (C:\windows\AppPatch\*.sdb) a

Re: [3/3] ntdll: Implement compatible typelib section

2013-08-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26698 Your paranoid android

Re: [2/3] ntdll: Added support for all typelib section attributes

2013-08-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26697 Your paranoid android

Re: [1/3] kernel32: Some tests for typelib sections

2013-08-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26696 Your paranoid android