Re: [2/2] wineserver: perform access check when creating event objects (try 2)

2013-08-08 Thread Andrew Cook
Actually ignore this patch, the problem was introduced by 92db6d2c back in 2007, server: Don't do access checks on the security descriptors of newly created objects which fixes sync.c:363 "CreateEventW with blank sd failed" i'll need to take another look at this, calling CreateEventEx with gener

Re: configure.ac: allow disabling winemac.drv

2013-08-08 Thread Ken Thomases
On Aug 8, 2013, at 5:56 PM, Austin English wrote: > +AC_ARG_WITH(winemac, AS_HELP_STRING([--without-winemac],[do not build > native Mac (Cocoa) driver]), > +[if test "x$withval" = "xno"; then > ac_cv_header_ApplicationServices_ApplicationServices_h=no; fi]) A switch to disable the

Re: Compiler warnings on Debian kfreebsd-i386

2013-08-08 Thread Charles Davis
On Aug 8, 2013, at 8:20 AM, Ken Sharp wrote: > Some interesting, some not: > > /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1898:24: warning: ‘get_pid_map’ > defined but not used [-Wunused-function] > /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1953:21: warning: > ‘find_owning_pid’ defined but no

Re: [PATCH 01/11] widl: New option --rt for enabling rt's specific language extensions.

2013-08-08 Thread Kai Tietz
2013/8/8 André Hentschel : > Am 08.08.2013 17:51, schrieb Kai Tietz: >> Hi, >> >> this patch adds new --rt option to widl. By it you can control, if >> RT's IDL-language-extension(?s) getting active. >> This initial patch just adds the option-scanning and the global >> flag-variable to widl. >> >>

Re: [PATCH 04/11] widl: Handle default value for public vs hidden attribute.

2013-08-08 Thread Kai Tietz
2013/8/8 André Hentschel : > Am 08.08.2013 17:57, schrieb Kai Tietz: >> -if (! is_attr(attrs, ATTR_PUBLIC)) >> +if (! is_attr(attrs, ATTR_PUBLIC) && ! is_attr (attrs, ATTR_HIDDEN)) > > style issue: space after ! Well, agreed. But I don't want to change by my patch style issues. This space

Re: [PATCH 04/11] widl: Handle default value for public vs hidden attribute.

2013-08-08 Thread André Hentschel
Am 08.08.2013 17:57, schrieb Kai Tietz: > -if (! is_attr(attrs, ATTR_PUBLIC)) > +if (! is_attr(attrs, ATTR_PUBLIC) && ! is_attr (attrs, ATTR_HIDDEN)) style issue: space after !

Re: [PATCH 09/11] widl: Handle LLP64 target same as LP64 one.

2013-08-08 Thread André Hentschel
Am 08.08.2013 18:07, schrieb Kai Tietz: > Hi, > > this thing here puzzles me most. I reject this patch, but would like > to get here some discussion to find the actual intended meaning of > this xstrtoul function. Then you should remove it from the patchset and send it as RFC to wine-devel

Re: [PATCH 01/11] widl: New option --rt for enabling rt's specific language extensions.

2013-08-08 Thread André Hentschel
Am 08.08.2013 17:51, schrieb Kai Tietz: > Hi, > > this patch adds new --rt option to widl. By it you can control, if > RT's IDL-language-extension(?s) getting active. > This initial patch just adds the option-scanning and the global > flag-variable to widl. > > Ok for apply? I'd say no, you are

Re: Synchronization-patches of widl

2013-08-08 Thread André Hentschel
Am 08.08.2013 10:56, schrieb Kai Tietz: > All these changes were necessary to support the VLC-people to begin > with their WinRT port. By this we began on mingw-w64 to improve - > thanks to Jacek - our IDL-generated header-sources. So you are on a good way with WinRT, nice. What about Windows RT,

Re: winetestbot question

2013-08-08 Thread Francois Gouget
On Wed, 7 Aug 2013, Stefan Leichter wrote: > Hello, > > i like to know why the WXPX64 VM of winetestbot does not have the 32 bit vc > runtime 2008. The other 64 bit VMs have the runtime installed. That VM is Windows XP SP1 and apparently that runtime only gets installed with SP3. The real pro

Re: [PATCH 1/1] msvcrt: Set ?: environment variable in _(w)chdir functions.

2013-08-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26639 Your paranoid android

Compiler warnings on Debian kfreebsd-i386

2013-08-08 Thread Ken Sharp
Some interesting, some not: /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1898:24: warning: ‘get_pid_map’ defined but not used [-Wunused-function] /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1953:21: warning: ‘find_owning_pid’ defined but not used [-Wunused-function] /home/ken/wine-git/dlls/jscri