re: msvcrt: strncpy doesn't compliant C standard (try 3)

2013-08-07 Thread Dan Kegel
Minor problem: +static void test_strncpy(void) +{ +size_t len = 10; +char *ret; +char dst[len + 1]; Hmm. That last line is a VLA, and might not compile in all C compilers because it's not allowed in C89. http://stackoverflow.com/questions/448844/variable-sized-arrays-in-c Wine seems

winetestbot question

2013-08-07 Thread Stefan Leichter
Hello, i like to know why the WXPX64 VM of winetestbot does not have the 32 bit vc runtime 2008. The other 64 bit VMs have the runtime installed. Because of the missing runtime each patch for the unit tests of the dlls msvcr90 and msvcp90 is marked as "Failed" at http://source.winehq.org/patche

Re: msvcrt: strncpy doesn't compliant C standard (try 3)

2013-08-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26638 Your paranoid android

Re: msvcp90/tests: Add dynamically loaded functions for ARM

2013-08-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26637 Your paranoid android

Re: Request to add wow64 keyword to bugzilla

2013-08-07 Thread Rosanne DiMesio
On Wed, 7 Aug 2013 21:07:29 +0200 Frédéric Delanoy wrote: > > There's no win32 keyword ; only win16 and win64 > > There wouldn't be any use anyway since it would be the default > I know; Ken pointed that out. I think I misread win16. Clearly I should not post before having coffee. -- Rosa

Re: msvcp90/tests: Skip tests on missing functions

2013-08-07 Thread André Hentschel
Am 07.08.2013 10:27, schrieb Piotr Caban: > On 08/06/13 23:00, André Hentschel wrote: >> @@ -749,6 +749,13 @@ static BOOL init(void) >> >> SET(p_basic_istream_char_read_uint64, >> >> "??5?$basic_istream@DU?$char_traits@D@std@@@std@@QAEAAV01@AA_K@Z"); >> + >> +if (!p

Re: Request to add wow64 keyword to bugzilla

2013-08-07 Thread Frédéric Delanoy
On Wed, Aug 7, 2013 at 4:30 PM, Ken Sharp wrote: > +1 from me. > > On 07/08/13 15:03, Rosanne DiMesio wrote: >> >> As to keyword usage, some of those bugs were tagged with the win64 >> keyword, some weren't. I know there is also a win32 keyword, and perhaps >> that is meant to be used for the kind

Re: Request to add wow64 keyword to bugzilla

2013-08-07 Thread Ken Sharp
+1 from me. On 07/08/13 15:03, Rosanne DiMesio wrote: On Wed, 07 Aug 2013 14:23:53 +0100 Ken Sharp wrote: Would I be right in assuming you would like to see bugs in 32-bit applications that are only present in a wow64 WINEPREFIX? Are there many? Yes. As to how many there are, I've been abl

Re: Request to add wow64 keyword to bugzilla

2013-08-07 Thread Ken Sharp
On 07/08/13 13:59, Rosanne DiMesio wrote: Can wow64 be added as a keyword to bugzilla? I know we already have win64 as a keyword, but that's being used for both 64 bit apps and 32 bit apps in a 64 bit wineprefix. I'm interested in being able to track the latter, as it's hitting increasing nu

Request to add wow64 keyword to bugzilla

2013-08-07 Thread Rosanne DiMesio
Can wow64 be added as a keyword to bugzilla? I know we already have win64 as a keyword, but that's being used for both 64 bit apps and 32 bit apps in a 64 bit wineprefix. I'm interested in being able to track the latter, as it's hitting increasing numbers of users. -- Rosanne DiMesio

Re: msvcp90/tests: Skip tests on missing functions

2013-08-07 Thread Piotr Caban
On 08/06/13 23:00, André Hentschel wrote: @@ -749,6 +749,13 @@ static BOOL init(void) SET(p_basic_istream_char_read_uint64, "??5?$basic_istream@DU?$char_traits@D@std@@@std@@QAEAAV01@AA_K@Z"); + +if (!p_basic_istream_char_read_uint64) +{ +skip(

Re: [PATCH] typo fixes (https://github.com/vlajos/misspell_fixer)

2013-08-07 Thread Frédéric Delanoy
On Mon, Aug 5, 2013 at 9:41 PM, Veres Lajos wrote: > > Signed-off-by: Veres Lajos > --- > dlls/comctl32/tests/trackbar.c |2 +- > documentation/ChangeLog.ALPHA | 80 > > documentation/ChangeLog.BETA | 44 +++--- > documentation

Re: msvcrt: strncpy doesn't compliant C standard (try 2)

2013-08-07 Thread Frédéric Delanoy
On Tue, Aug 6, 2013 at 10:44 PM, Álvaro Nieto wrote: > Remove strlen and implement some tests You should probably add tests for when the source string is not null-terminated. Frédéric Delanoy