Re: [PATCH 4/5] d3dx9/tests: Add ID3DXConstantTable struct test.

2013-08-01 Thread Rico Schüller
On 31.07.2013 00:14, Matteo Bruni wrote: 2013/7/30 Rico Schüller : Hi Matteo, please see the attached patch. On 25.07.2013 16:13, Matteo Bruni wrote: 2013/7/24 Rico Schüller : --- dlls/d3dx9_36/tests/shader.c | 308 +++ 1 file changed, 308 inse

Re: Wiki RFC: Redirects, swarm tactics, etc.

2013-08-01 Thread Austin English
On Thu, Aug 1, 2013 at 11:03 PM, Kyle Auble wrote: > So I've finished with pretty much all of the edits I had in mind for > the wiki, but before I ride off into the sunset for a while, I wanted > to toss out a few ideas. .. > 2. There's still a lot of old/missing content on the wiki, and much > of

Re: gdi32: Don't let the gdi32 driver allocate memory in the dplayx region.

2013-08-01 Thread Alexei Svitkine
On Fri, Jul 26, 2013 at 2:04 AM, Nikolay Sivov wrote: > Looks like dplay should be fixed to not depend on that reserved address > area. > I agree, that's the ideal solution. However, I'm not sufficiently familiar with what dplay is doing to need that block of memory at that address or what would

Wiki RFC: Redirects, swarm tactics, etc.

2013-08-01 Thread Kyle Auble
So I've finished with pretty much all of the edits I had in mind for the wiki, but before I ride off into the sunset for a while, I wanted to toss out a few ideas. 1. Do we want some kind of guideline on redirects for the wiki? Some stable "interface" pages to the main site might be good, but beyo

Clang warns on "wrong" header guard in "config.h"

2013-08-01 Thread Charles Davis
Hi, I've been building Wine with Clang, and it (apparently, unlike GCC) produces warnings like this: ../../include/config.h:4:9: warning: 'WINE_CROSSTEST' is used as a header guard here, followed by #define of a different macro [-Wheader-guard] #ifndef WINE_CROSSTEST ^~

Re: [11/11] apphelp: Add tests.

2013-08-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26579 Your paranoid android

Re: [PATCH 1/4] d3dx9: Track ID3DXEffect::Begin/End().

2013-08-01 Thread Rico Schüller
On 01.08.2013 15:58, Bruno Jesus wrote: On Thu, Aug 1, 2013 at 9:14 AM, Rico Schüller wrote: --- dlls/d3dx9_36/effect.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) +if (!This->started) +return D3D_OK; + +This->started = FALSE; + +return D3D_OK;

Re: d3dx9 [patch 1/2]: Implement D3DXCreatePolygon

2013-08-01 Thread Matteo Bruni
2013/8/1 Nozomi Kodama : > +vertices = HeapAlloc(GetProcessHeap(), 0, 2 * (sides + 1) * sizeof(D3DXVECTOR3)); +if (!vertices) +{ +TRACE("Not memory enough for vertex buffer\n"); +polygon->lpVtbl->Release(polygon); +return E_OUTOFMEMORY; +} + +hr = polygo

Re: [PATCH 1/11] apphelp: Add definitions.

2013-08-01 Thread Alexandre Julliard
Mislav Blazevic writes: > @@ -25,6 +26,209 @@ extern "C" { > > BOOL WINAPI ApphelpCheckShellObject(REFCLSID, BOOL, ULONGLONG *); > > +typedef enum _PATH_TYPE { > +DOS_PATH, > +NT_PATH > +} PATH_TYPE; > + > +typedef struct _DB { > +HANDLE file; > +DWORD size; > +PBYTE data; >

Re: [PATCH 4/5] d3dx9/tests: Add ID3DXConstantTable struct test.

2013-08-01 Thread Matteo Bruni
2013/8/1 Rico Schüller : > On 31.07.2013 00:14, Matteo Bruni wrote: >> >> 2013/7/30 Rico Schüller : >>> >>> Hi Matteo, >>> >>> please see the attached patch. >>> >>> >>> On 25.07.2013 16:13, Matteo Bruni wrote: 2013/7/24 Rico Schüller : > > > --- >dlls/d3dx9_36/te

Re: [PATCH 1/4] d3dx9: Track ID3DXEffect::Begin/End().

2013-08-01 Thread Bruno Jesus
On Thu, Aug 1, 2013 at 9:14 AM, Rico Schüller wrote: > --- > dlls/d3dx9_36/effect.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > +if (!This->started) > +return D3D_OK; > + > +This->started = FALSE; > + > +return D3D_OK; Sorry to bother but why no

Re: reg.exe: Add query function

2013-08-01 Thread Nikolay Sivov
On 8/1/2013 17:44, Hugh McMaster wrote: This patch builds significantly on the query function stub in programs/reg.exe. The patch includes recursion for subkeys. Some examples of usage: wine reg.exe query "HKCU" wine reg.exe query "HKCU\Console" wine reg.exe query "HKCU\Console" /v "ScreenSize

RE: reg.exe: Add query function

2013-08-01 Thread Hugh McMaster
On Thursday, 1 August 2013 11:43 PM, Bruno Jesus wrote: >The patch was sent to wine-devel. Yes, you're right. Apologies for that. I've now submitted the patch to wine-patches.

Re: reg.exe: Add query function

2013-08-01 Thread Bruno Jesus
On Thu, Aug 1, 2013 at 10:39 AM, Hugh McMaster wrote: > This patch significantly builds on the query function stub in > programs/reg.exe. The patch includes recursion for subkeys. The patch was sent to wine-devel. > Some examples of usage: > > wine reg.exe query "HKCU" > wine reg.exe query "HKC

reg.exe: Add query function

2013-08-01 Thread Hugh McMaster
This patch significantly builds on the query function stub in programs/reg.exe. The patch includes recursion for subkeys. Some examples of usage: wine reg.exe query "HKCU" wine reg.exe query "HKCU\Console" wine reg.exe query "HKCU\Console" /v "ScreenSize" wine reg.exe query "HKCU\Software" /s -

Re: [PATCH 2/2] ddraw: Fix double to float conversion warnings

2013-08-01 Thread Henri Verbeet
On 1 August 2013 12:25, Stefan Dösinger wrote: > diff --git a/dlls/ddraw/executebuffer.c b/dlls/ddraw/executebuffer.c > index 2925cfa..5c12272 100644 > --- a/dlls/ddraw/executebuffer.c > +++ b/dlls/ddraw/executebuffer.c > @@ -382,10 +382,10 @@ HRESULT d3d_execute_buffer_execute(struct > d3d_execu

RE: Possibility of adding a new patch status

2013-08-01 Thread Hugh McMaster
>>> * The patch is difficult to review, and he's putting it off. >> >> There are some statuses (e.g. 'needs splitting) to counteract this. But >> patches are/can be difficult to review. Again, a status such as 'Not yet >> reviewed' would help. >> >>> * He's travelling and does not have access t

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds. Take 3.

2013-08-01 Thread Alexandre Julliard
Dmitry Timoshkov writes: > @@ -208,9 +233,22 @@ static TIFF* tiff_open_stream(IStream *stream, const > char *mode) > zero.QuadPart = 0; > IStream_Seek(stream, zero, STREAM_SEEK_SET, NULL); > > +/* Workaround for broken libtiff 4.x headers on some 64-bit hosts which > + * defi

Re: oledb32: Add IDataSourceLocator support

2013-08-01 Thread Alistair Leslie-Hughes
Ignore this patch On 1/08/2013 6:36 PM, Alistair Leslie-Hughes wrote: Hi, Changelog: oledb32: Add IDataSourceLocator support Best Regards Alistair Leslie-Hughes

Re: Re: apphelp: Implement SdbTagToString.

2013-08-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26567 Your paranoid android