Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=26546
Your paranoid android
Caibin Chen writes:
> There are at least 3 more interfaces to be implemented, should I put
> them in richole.c as well?
For now, yes.
--
Alexandre Julliard
julli...@winehq.org
There are at least 3 more interfaces to be implemented, should I put
them in richole.c as well?
2013/7/31 Alexandre Julliard :
> Caibin Chen writes:
>
>> Hi Alexandre,
>>
>> I think it make sense to have a separate file for ITextDocument. It
>> will be used in txtsrv.c and richole.c (See patch 4)
Am 2013-07-31 16:01, schrieb Christian Costa:
> AFAIK no. My localization is french and I get english messages. Any
> idea how I can check that?
Should be ok then.
> The parsing code handles missing null byte as well as both
> unix/dos text formats but maybe I can just simplify it by using
> strto
Caibin Chen writes:
> Hi Alexandre,
>
> I think it make sense to have a separate file for ITextDocument. It
> will be used in txtsrv.c and richole.c (See patch 4). If it's WINE's
> convention to not have separate files for separate implementations, I
> can merge the txtrng.[ch] and txtsel.[ch] th
On Wed, Jul 31, 2013 at 10:21 AM, Thomas Faber wrote:
> On 2013-07-31 02:48, Bruno Jesus wrote:
>> +ok(!getsockopt(sock, SOL_SOCKET, SO_TYPE, (char *) &socktype, &size),
>> "getsockopt failed with %d\n",
>> + WSAGetLastError());
>
> It's not guaranteed that getsockopt is called before W
Hi Alexandre,
I think it make sense to have a separate file for ITextDocument. It
will be used in txtsrv.c and richole.c (See patch 4). If it's WINE's
convention to not have separate files for separate implementations, I
can merge the txtrng.[ch] and txtsel.[ch] that introduced in patch 2
and 3 in
Nozomi Kodama writes:
> What is the problem with patch:
> http://source.winehq.org/patches/data/97500
>
> M_PI is never used in D3DX (moreover it is deprecated in C99)
It's used all over the place, and we have portability macros for
it. There's no reason to avoid it.
--
Alexandre Julliard
jull
Bruno Jesus <00cp...@gmail.com> writes:
> @@ -1813,6 +1821,8 @@ BOOL WINAPI GetVolumePathNameW(LPCWSTR filename, LPWSTR
> volumepathname, DWORD bu
> volumepathname[3] = 0;
> return TRUE;
> }
> +
> +SetLastError(ERROR_FILENAME_EXCED_RANGE);
> return FALSE;
This doe
Caibin Chen writes:
> Thanks Jacek for reviewing. This time I send all the changes I have in
> 4 patches to make it clear that ReTxtDoc is reused between txtsrv.c
> and richole.c
> - Suppressed Patch 97331
> - Change log from try 2:
> - follow COM naming convention
> - move ReTxtDoc definition
> Wouldn't these two points simply earn a 'Rejected' status and/or some kind of
> comment on the wine-devel list?
Applying a "Rejected" status would require looking at the patch.
But it could be nice to have a status that means "I will not even read
a patch from this person to do this specific t
Hi Stefan,
2013/7/31 Stefan Dösinger
> Hi,
>
> Am 31.07.2013 um 09:10 schrieb Christian Costa :
>
> +if (!(strstr(line_out, "warning X3206:") &&
> strstr(line_out, "implicit truncation of vector type")))
> +line_out += line_size;
>
> msvc localizes compiler er
On 2013-07-31 02:48, Bruno Jesus wrote:
> +ok(!getsockopt(sock, SOL_SOCKET, SO_TYPE, (char *) &socktype, &size),
> "getsockopt failed with %d\n",
> + WSAGetLastError());
It's not guaranteed that getsockopt is called before WSAGetLastError
here. (in fact the latter will be evaluated firs
Please disregard this patch. I missed a couple of words and with those
corrected en_CA.po becomes identical to en.po (except that
"serialisation" is fuzzy) and Wine defaults to that anyway for Canadian
English.
Will re-submit if there are any changes (just noticed -able/-eable).
Will keep an
Hi,
Am 31.07.2013 um 09:10 schrieb Christian Costa :
> +if (!(strstr(line_out, "warning X3206:") && strstr(line_out,
> "implicit truncation of vector type")))
> +line_out += line_size;
msvc localizes compiler errors and warnings. Are you sure d3dcompiler.dll
Hi Vincent,
You raise some very good points.
On Wednesday, 31 July 2013 2:53 AM, Vincent Povirk wrote:
>I think I've seen patches stay in the "New" state in the following cases:
> * He's convinced you do not have the ability to write a patch he would
> accept. (There's a common pattern where pe
On Tuesday, 30 July 2013 9:04 PM, Ken Sharp wrote:
>There's also "Pending".
Hi Ken,
Yes, I know about the 'Pending' status. The patches page describes this status
in two ways:
1. The patch is not obviously correct at first glance. Making a more convincing
argument, preferably in the form of
17 matches
Mail list logo
