d3dx9: Replace M_PI by its D3DX equivalent

2013-07-30 Thread Nozomi Kodama
Hello What is the problem with patch http://source.winehq.org/patches/data/97500 M_PI is never used in D3DX. Nozomi

d3dx9: Replace M_PI by its D3DX equivalent

2013-07-30 Thread Nozomi Kodama
What is the problem with patch: http://source.winehq.org/patches/data/97500 M_PI is never used in D3DX (moreover it is deprecated in C99) Nozomi

Re: msxml3: Unescape '&' back to '&' in attribute value

2013-07-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26523 Your paranoid android

Re: ws2_32/tests: Test the precedence of parameters while creating a socket in WSASocket()

2013-07-30 Thread Austin English
On Tue, Jul 30, 2013 at 5:13 PM, Bruno Jesus <00cp...@gmail.com> wrote: > > You forgot the patch. -- -Austin

Re: kernel32/tests: Improve GetVolumePathNameA tests

2013-07-30 Thread Bruno Jesus
Please ignore this patch, I understand that as is it will not be commited. On Tue, Jul 30, 2013 at 3:30 AM, Bruno Jesus <00cp...@gmail.com> wrote: > Erich Hoover contacted me about a patch he sent months ago related to > GetVolumePathNameA. He developed a better test infrastructure using a > for l

Re: [PATCH 4/5] d3dx9/tests: Add ID3DXConstantTable struct test.

2013-07-30 Thread Matteo Bruni
2013/7/30 Rico Schüller : > Hi Matteo, > > please see the attached patch. > > > On 25.07.2013 16:13, Matteo Bruni wrote: >> >> 2013/7/24 Rico Schüller : >>> >>> --- >>> dlls/d3dx9_36/tests/shader.c | 308 >>> +++ >>> 1 file changed, 308 insertions(+) >>> >

Re: [PATCH 4/5] d3dx9/tests: Add ID3DXConstantTable struct test.

2013-07-30 Thread Rico Schüller
Hi Matteo, please see the attached patch. On 25.07.2013 16:13, Matteo Bruni wrote: 2013/7/24 Rico Schüller : --- dlls/d3dx9_36/tests/shader.c | 308 +++ 1 file changed, 308 insertions(+) This is okay, but as a followup can you add some tests with m

Re: Possibility of adding a new patch status

2013-07-30 Thread Vincent Povirk
I think I've seen patches stay in the "New" state in the following cases: * He's convinced you do not have the ability to write a patch he would accept. (There's a common pattern where people will take feedback and attempt to revise their patch to account for it, but not really understand the feed

Re: [PATCH] imm32: Fixed crashing in ImmGetIMCCSize.

2013-07-30 Thread Qian Hong
Hello Nikolay, On Wed, Jul 10, 2013 at 1:06 AM, Nikolay Sivov wrote: > This could be some a different bug, and putting exception handler around it > is not necessary a right solution. Good catch, I think you are right. I found ImmLockIMC()/ImmUnLockIMC()/etc are called even after ImmDestroyCont

Re: [PATCH] imm32: Fixed crashing in ImmGetIMCCSize.

2013-07-30 Thread Qian Hong
Forgot to say, as described in the last post, this patch doesn't kill the culprit, please reject the patch, thanks.

Call for Windows tests

2013-07-30 Thread Bruno Jesus
Hi, I'm looking for help to test WSAEnumProtocols, I need to collect more information about the values returned from different versions of windows, especially 7 and 8. If you can help please download the file below, unzip, run the .bat and send me back the result.txt file (sources included). http:

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds. Take 2.

2013-07-30 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> You shouldn't check the version, but the actual problem (i.e. the size >> of the offending type). Also please avoid unnecessary changes. > > The offending type is toff_t, it's size is either 32 or 64-bit depending > on whether it's libtif

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds. Take 2.

2013-07-30 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > You shouldn't check the version, but the actual problem (i.e. the size > of the offending type). Also please avoid unnecessary changes. The offending type is toff_t, it's size is either 32 or 64-bit depending on whether it's libtiff 3.0 or 4.0, or whether it's broken

Re: Possibility of adding a new patch status

2013-07-30 Thread Ken Sharp
There's also "Pending". On 30/07/13 04:16, Hugh McMaster wrote: Hi everyone, Wine patches currently have a status described in http://source.winehq.org/patches, yet for patches with the status of 'New', the status becomes confusing. The legend describes 'New' status as "Patch not even looked

Re: [1/2] msxml3: Implement IMXAttributes_removeAttributes()

2013-07-30 Thread Jacek Caban
Hi Nikolay, On 07/30/13 12:42, Nikolay Sivov wrote: > +dst = &This->attr[index]; > +src = &This->attr[index+1]; > + > +memmove(dst, src, This->length-index-1); *sizeof(*dst) Cheers, Jacek

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds. Take 2.

2013-07-30 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> >> TIFF_VERSION_CLASSIC reflects the TIFF format itself, it's defined >> >> to 42, TIFF_VERSION_BIG introduced in 4.x defined to 43. >> >> >> >> Unfortunately TIFFLIB_VERSION define reflects the date, not the real >> >> version. So for i

Re: [1/2] wininet: Ignore INTERNET_FLAG_NO_CACHE_WRITE only for GET requests.

2013-07-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26481 Your paranoid android

Re: [2/2] wininet: Handle NULL input string in str_to_buffer.

2013-07-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26482 Your paranoid android

Re: [2/2] iphlpapi: Add partial support for the module classes in GetExtendedTcpTable and GetExtendedUdpTable.

2013-07-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26480 Your paranoid android

Re: [1/2] iphlpapi: Add support for the listener and connection classes in GetExtendedTcpTable.

2013-07-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26479 Your paranoid android

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds. Take 2.

2013-07-30 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > >> TIFF_VERSION_CLASSIC reflects the TIFF format itself, it's defined > >> to 42, TIFF_VERSION_BIG introduced in 4.x defined to 43. > >> > >> Unfortunately TIFFLIB_VERSION define reflects the date, not the real > >> version. So for instance libtiff 3.9.7 has it define

Re: riched20: ITextDocument stubs for ITextServices (retry)

2013-07-30 Thread Jacek Caban
On 07/29/13 17:55, Caibin Chen wrote: >> +struct tagReTxtDoc { >> + IUnknown *outerObj; >> + ME_TextEditor *editor; >> + ITextDocument iTextDocumentIface; >> +}; >> >> Do you really need a separated structure for that? Wouldn't adding >> ITextDocument implementation to ITextServicesImpl be enou

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds. Take 2.

2013-07-30 Thread Alexandre Julliard
Dmitry Timoshkov writes: >> TIFF_VERSION_CLASSIC reflects the TIFF format itself, it's defined >> to 42, TIFF_VERSION_BIG introduced in 4.x defined to 43. >> >> Unfortunately TIFFLIB_VERSION define reflects the date, not the real >> version. So for instance libtiff 3.9.7 has it defined to 201209