Re: gdi32: Don't let the gdi32 driver allocate memory in the dplayx region.

2013-07-25 Thread Nikolay Sivov
On 7/26/2013 08:48, Alexei Svitkine wrote: On Mon, Jul 22, 2013 at 10:45 PM, Alexei Svitkine mailto:alexei.svitk...@gmail.com>> wrote: Don't let the gdi32 driver allocate memory in the dplayx region. Fixes bug: http://bugs.winehq.org/show_bug.cgi?id=34095 The issue is that the

Re: gdi32: Don't let the gdi32 driver allocate memory in the dplayx region.

2013-07-25 Thread Alexei Svitkine
On Mon, Jul 22, 2013 at 10:45 PM, Alexei Svitkine wrote: > Don't let the gdi32 driver allocate memory in the dplayx region. > > Fixes bug: http://bugs.winehq.org/show_bug.cgi?id=34095 > > The issue is that the dplayx code in wine needs to allocate some > memory at a static address (0x5000) an

Re: gdi32: Don't let the gdi32 driver allocate memory in the dplayx region.

2013-07-25 Thread Alexei Svitkine
On Mon, Jul 22, 2013 at 10:45 PM, Alexei Svitkine wrote: > Don't let the gdi32 driver allocate memory in the dplayx region. > > Fixes bug: http://bugs.winehq.org/show_bug.cgi?id=34095 > > The issue is that the dplayx code in wine needs to allocate some > memory at a static address (0x5000) an

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds.

2013-07-25 Thread Dmitry Timoshkov
Vincent Povirk wrote: > I have no opinion on this sort of work-around (it should work afaict, > and I haven't found any other places where we currently use toff_t), > but did you file a bug with whatever distro has such broken headers? As far as I can see it's not a distro problem, it's a libtif

Re: Need help with debugging a directx9 game crashing

2013-07-25 Thread Ken Thomases
On Jul 25, 2013, at 2:11 PM, Qian Hong wrote: > On Fri, Jul 26, 2013 at 2:52 AM, Ken Thomases wrote: >> I think your Valgrind results are telling us that there's a bug in the game >> where it's using an uninitialized stack variable. >> >> There's still a chance that it's something in Wine that'

Re: Need help with debugging a directx9 game crashing

2013-07-25 Thread Qian Hong
On Fri, Jul 26, 2013 at 2:52 AM, Ken Thomases wrote: > I think your Valgrind results are telling us that there's a bug in the game > where it's using an uninitialized stack variable. > > There's still a chance that it's something in Wine that's using the > uninitialized variable and passing a ga

Re: Need help with debugging a directx9 game crashing

2013-07-25 Thread Ken Thomases
Hi Qian, On Jul 25, 2013, at 11:53 AM, Qian Hong wrote: > On Thu, Jul 25, 2013 at 2:33 AM, Ken Thomases wrote: >> Hmm. You may need to mark the dummy array as volatile to prevent it from >> being optimized away. Worth trying. You might also increase the size of >> the array. > > You are ri

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds.

2013-07-25 Thread Austin English
I had filed a bug with Gentoo: https://bugs.gentoo.org/show_bug.cgi?id=459820 On Jul 25, 2013 5:31 PM, "Vincent Povirk" wrote: > I have no opinion on this sort of work-around (it should work afaict, > and I haven't found any other places where we currently use toff_t), > but did you file a bug

Re: Need help with debugging a directx9 game crashing

2013-07-25 Thread Qian Hong
Hi Ken, On Thu, Jul 25, 2013 at 2:33 AM, Ken Thomases wrote: > Hmm. You may need to mark the dummy array as volatile to prevent it from > being optimized away. Worth trying. You might also increase the size of the > array. You are right, thanks! Increasing the size of the array helps, the m

Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string. (try 3)

2013-07-25 Thread Ken Thomases
On Jul 25, 2013, at 10:49 AM, Charles Davis wrote: > Try 3: Don't advertise WGL_EXT_swap_control if vsync is disabled. Looks good. Thanks, Ken

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds.

2013-07-25 Thread Vincent Povirk
Actually, this will be a problem on libtiff 3.x, where toff_t really is supposed to be 32-bit.

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds.

2013-07-25 Thread Vincent Povirk
I have no opinion on this sort of work-around (it should work afaict, and I haven't found any other places where we currently use toff_t), but did you file a bug with whatever distro has such broken headers?

Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string. (try 2)

2013-07-25 Thread Ken Thomases
On Jul 25, 2013, at 9:57 AM, Ken Thomases wrote: > If vsync is disallowed, the corresponding functions are left as NULL in the > OpenGL function table, so clients may crash if WGL_EXT_swap_control is > advertised. Well, this part is wrong. They won't crash because opengl32 protects against th

Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string. (try 2)

2013-07-25 Thread Ken Thomases
On Jul 24, 2013, at 9:41 PM, Ken Thomases wrote: > On Jul 24, 2013, at 9:34 PM, Charles Davis wrote: > >> Try 2: Don't duplicate a constant string; we might need to add more legacy >> extensions. (Hopefully not. ;) > > Thanks for making that change. Looks good to me. Actually, on further

Re: [PATCH 3/5] d3dx9: Add support for structs to ID3DXConstantTable.

2013-07-25 Thread Matteo Bruni
2013/7/24 Rico Schüller : > --- > dlls/d3dx9_36/shader.c | 79 > -- > 1 file changed, 77 insertions(+), 2 deletions(-) > So there was actually a logic (an insane one, but yeah...). Have you found any game actually using this? Annoying question: hav

Re: [PATCH 4/5] d3dx9/tests: Add ID3DXConstantTable struct test.

2013-07-25 Thread Matteo Bruni
2013/7/24 Rico Schüller : > --- > dlls/d3dx9_36/tests/shader.c | 308 > +++ > 1 file changed, 308 insertions(+) > This is okay, but as a followup can you add some tests with mixed-type structs? Something like: struct { float f; int i; bool b; }

Re: [PATCH 1/6] scrrun: Store reference count inside IFileSystem3 object

2013-07-25 Thread Piotr Caban
On 07/25/13 14:36, Nikolay Sivov wrote: On 7/25/2013 16:35, Piotr Caban wrote: --- dlls/scrrun/filesystem.c | 163 +++ 1 file changed, 123 insertions(+), 40 deletions(-) Why do you need this? My bad, I was planning to store some kind of seed inside t

Re: [PATCH 1/6] scrrun: Store reference count inside IFileSystem3 object

2013-07-25 Thread Nikolay Sivov
On 7/25/2013 16:35, Piotr Caban wrote: --- dlls/scrrun/filesystem.c | 163 +++ 1 file changed, 123 insertions(+), 40 deletions(-) Why do you need this?