Re: riched20: Add tests for ITextRange interface.

2013-07-18 Thread Caibin Chen
Can you explain what benefits can we get from merging these two tests? To me it only make them hard to read. 2013/7/18 Nikolay Sivov : > On 7/19/2013 00:15, Caibin Chen wrote: >> >> What files do you mean to merge? txtsrv.c and richole.c or >> test/richole.c and test/richole.c? > > Tests of course

Re: riched20: Add tests for ITextRange interface.

2013-07-18 Thread Nikolay Sivov
On 7/19/2013 00:15, Caibin Chen wrote: What files do you mean to merge? txtsrv.c and richole.c or test/richole.c and test/richole.c? Tests of course. Another solution is to create ITextService instance in richole.c and run range tests or whatever tests you need on it. It's a couple of lines to

Another major milestone

2013-07-18 Thread Jeremy White
Alright folks, I have to confess that the 1.6 release came and I didn't immediately get up and dance. In fact, a new Wine release was almost...boring. I think we have to consider that a major milestone in of itself. New, useful releases are just a matter of course for us now. Woohoo! Now I'm d

Re: riched20: Add tests for ITextRange interface.

2013-07-18 Thread Caibin Chen
What files do you mean to merge? txtsrv.c and richole.c or test/richole.c and test/richole.c? 2013/7/18 Nikolay Sivov : > On 7/19/2013 00:04, Caibin Chen wrote: >> >> The ITextRange objects are returned by ITextDocument_Range() method. >> Both IRichEditOle and ITextService supports ITextDocument i

Re: riched20: Add tests for ITextRange interface.

2013-07-18 Thread Nikolay Sivov
On 7/19/2013 00:04, Caibin Chen wrote: The ITextRange objects are returned by ITextDocument_Range() method. Both IRichEditOle and ITextService supports ITextDocument interface. Currently we don't have ITextDocument support in ITextService. my another patch[1] is to add ITextDocument interface sup

Re: riched20: Add tests for ITextRange interface.

2013-07-18 Thread Caibin Chen
The ITextRange objects are returned by ITextDocument_Range() method. Both IRichEditOle and ITextService supports ITextDocument interface. Currently we don't have ITextDocument support in ITextService. my another patch[1] is to add ITextDocument interface support in ITextService. [1]. http://www.wi

Re: Patches I maintain

2013-07-18 Thread Nozomi Kodama
Hello for this one, I have a patch in my tree. I will send it after my patches for the spherical harmonics. Nozomi >Hi Roland, > >I'm not exactly sure what your goal is... but there is a rule one patch per >mail only! There is likely no chance to get something like that mixture >committed. >

Re: riched20: Add tests for ITextRange interface.

2013-07-18 Thread Nikolay Sivov
On 7/18/2013 23:36, Caibin Chen wrote: ITextRange will be used in both richole.c and txtsrv.c. I'm planning to add more tests in it. I think it makes more sense to have one test file for each interface, which improves the readability of tests. That's usually done for implementation, but not for t

Re: riched20: Add tests for ITextRange interface.

2013-07-18 Thread Caibin Chen
ITextRange will be used in both richole.c and txtsrv.c. I'm planning to add more tests in it. I think it makes more sense to have one test file for each interface, which improves the readability of tests. 2013/7/18 Nikolay Sivov : > On 7/18/2013 20:28, Caibin Chen wrote: >> >> Add tests for start

Re: riched20: Add tests for ITextRange interface.

2013-07-18 Thread Nikolay Sivov
On 7/18/2013 20:28, Caibin Chen wrote: Add tests for start and end point, setting and getting text. --- dlls/riched20/tests/Makefile.in | 3 +- dlls/riched20/tests/txtrng.c| 343 2 files changed, 345 insertions(+), 1 deletion(-) create mode 100

Re: riched20: ITextDocument stubs for ITextServices (retry)

2013-07-18 Thread Caibin Chen
Anybody reviewing this patch? It's almost all stubs, so although it's long, it shouldn't be hard to review 2013/7/15 Caibin Chen : > (Retry with real name in mail. The name in the patch is already my real name) > > This patch implements a standalone stub of ITextDocument. The stub is > currently u

Re: Patches I maintain

2013-07-18 Thread Rico Schüller
Hi Roland, I'm not exactly sure what your goal is... but there is a rule one patch per mail only! There is likely no chance to get something like that mixture committed. You may have a look here: http://wiki.winehq.org/SubmittingPatches On 18.07.2013 01:23, Roland Haeder wrote: +HRESULT D3