Re: wined3d: print the architecture when showing driver problems

2013-06-25 Thread Austin English
On Mon, Jun 24, 2013 at 12:20 AM, Henri Verbeet wrote: > On 23 June 2013 07:10, Austin English wrote: >> Please consider applying before the release of 1.6. It has no >> functional changes, but would really help when diagnosing user >> problems. >> > This is not really a wined3d patch. That said,

Re: widl: Do not generate empty Vtbl structure for empty interfaces.

2013-06-25 Thread Thomas Faber
On 2013-06-25 21:11, Alexandre Julliard wrote: > Thomas Faber writes: > >> An alternative solution would be not to generate a vtable structure at all, >> and instead add a dummy member to the class directly. That would be in line >> with what the defined(__cplusplus) && !defined(CINTERFACE) case

Re: widl: Do not generate empty Vtbl structure for empty interfaces.

2013-06-25 Thread Alexandre Julliard
Thomas Faber writes: > An alternative solution would be not to generate a vtable structure at all, > and instead add a dummy member to the class directly. That would be in line > with what the defined(__cplusplus) && !defined(CINTERFACE) case results in, > but require a slightly larger change to

Bug 24018 which appears to be a showstopper for running Cygwin on Wine

2013-06-25 Thread Alan W. Irwin
Andrey Turkin has stated at http://bugs.winehq.org/show_bug.cgi?id=24018 that this is really a Cygwin bug. I frankly don't understand the technical details but his current test (an infinite loop with Cygwin fork calls) may need some beefing up to convince the Cygwin developers they have introduce

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

2013-06-25 Thread Christian Costa
Thanks Stefan! No problem with me. I don't take it personnally. :) I'm not statisfied with the submission/review with some criterias which are sometimes rules, sometimes tastes, with patches (not necessarily mine) that remain in the new state without any comments while another with a missing dot wo

Re: server: Update German translation of manpage.

2013-06-25 Thread Alexandre Julliard
Julian Rüger writes: > I'm unsure about the second line. Is that supposed to be the "last > modified" date of the manpage, the wineserver or what? The English > version says October 2005. In general, it would be the last time there were changes to the program that required a manpage update. --

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

2013-06-25 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-06-25 18:08, schrieb Christian Costa: > Are we really discussing about a typo in the subject line? > "Implement" just comes naturally from the fixme when I create an > empty patch. It turned out after coding that "Fix" is more > appropriate. I

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

2013-06-25 Thread Christian Costa
2013/6/25 Henri Verbeet > On 25 June 2013 11:05, Christian Costa wrote: > > 2013/6/25 Henri Verbeet > >> At least try to pretend you put > >> some effort into making sure the patch is as good as it can be before > >> submitting it. > > > > > > I could have send the patch to wine-devel first but

Re: Czech language for Wine

2013-06-25 Thread Alexandre Julliard
Pavel Vlček writes: > @@ -1415,19 +1400,19 @@ > > #: crypt32.rc:74 > msgid "Title" > -msgstr "Titul" > +msgstr "" > > #: crypt32.rc:75 > msgid "Given Name" > -msgstr "Jm©no" > +msgstr "" > > #: crypt32.rc:76 > msgid "Initials" > -msgstr "Inici¡ly" > +msgstr "" > > #: crypt32.rc:77

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

2013-06-25 Thread Henri Verbeet
On 25 June 2013 11:05, Christian Costa wrote: > 2013/6/25 Henri Verbeet >> At least try to pretend you put >> some effort into making sure the patch is as good as it can be before >> submitting it. > > > I could have send the patch to wine-devel first but would I get something > longer that "seve

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

2013-06-25 Thread Christian Costa
2013/6/25 Henri Verbeet > On 24 June 2013 16:44, Matteo Bruni wrote: > > @@ -1673,6 +1673,8 @@ struct texture_stage_op > > unsignedaarg2 : 8; > > unsignedaarg0 : 8; > > > > +DWORD constant; > > + > > struct color_fixup_desc col

Re: [PATCH] ole32: LeaveCriticalSection in one exit case (Coverity)

2013-06-25 Thread Marcus Meissner
On Sun, Jun 23, 2013 at 08:43:18PM +0900, Dmitry Timoshkov wrote: > Marcus Meissner wrote: > > > > > --- a/dlls/ole32/ifs.c > > > > +++ b/dlls/ole32/ifs.c > > > > @@ -217,6 +217,8 @@ static LPVOID WINAPI IMalloc_fnRealloc(LPMALLOC > > > > iface,LPVOID pv,DWORD cb) { > > > > IMall