Re: oledb32: Correct DBPROP_INIT_PROVIDERSTRING and DBPROP_INIT_HWND types

2013-06-05 Thread Nikolay Sivov
On Thu, Jun 6, 2013 at 9:55 AM, Alistair Leslie-Hughes < leslie_alist...@hotmail.com> wrote: > Hi, > Corrects a spelling mistake too and > > Changelog: > oledb32: Correct DBPROP_INIT_PROVIDERSTRING and DBPROP_INIT_HWND types > > > Best Regards > Alistair Leslie-Hughes > > > > -{ extemdedW

Re: ntdll: Add stub for LdrResolveDelayLoadedAPI and reference it in kernel32

2013-06-05 Thread Austin English
On Wed, Jun 5, 2013 at 7:10 PM, Dmitry Timoshkov wrote: > André Hentschel wrote: > >> diff --git a/include/delayloadhandler.h b/include/delayloadhandler.h >> new file mode 100644 >> index 000..e48e415 >> --- /dev/null >> +++ b/include/delayloadhandler.h > > I don't see such file in PSDK 7.1,

Re: ntdll: Add stub for LdrResolveDelayLoadedAPI and reference it in kernel32

2013-06-05 Thread Dmitry Timoshkov
André Hentschel wrote: > diff --git a/include/delayloadhandler.h b/include/delayloadhandler.h > new file mode 100644 > index 000..e48e415 > --- /dev/null > +++ b/include/delayloadhandler.h I don't see such file in PSDK 7.1, where does it come from? > diff --git a/include/winnt.h b/include/w

Re: [PATCH 2/3] oleaut32/tests: Add save/load tests for created typelibs

2013-06-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25849 Your paranoid android

Re: cmd: Disable Ctrl-C interrupt

2013-06-05 Thread Jason Edmeades
Hi Hugh, Thanks for looking at this issue with wine's cmd I do not think this patch is enough - From memory (I once tried something similar) the problem with resolving it the way you have is you then lose the ability of breaking out of a batch program. I think the right solution needs an actual h

Re: ole32: Add a basic OLE client/server test suite. Take 2.

2013-06-05 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > If it's a test app meant to investigate the behavior, that's fine, but > then there's no reason to put it in the test suite. > > Just use it to figure out the behavior, and then write a proper test > that checks for that behavior using ok() and the like. At that point

Re: ole32: Add a basic OLE client/server test suite. Take 2.

2013-06-05 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> >> Launching the server in responce to say CoCreateInstance is out of our >> >> control, happens behind the scene, and the server runs in its own console, >> >> so it's impossible make a simple redirection by passing in/out handles to >>

Re: ole32: Add a basic OLE client/server test suite. Take 2.

2013-06-05 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > >> Launching the server in responce to say CoCreateInstance is out of our > >> control, happens behind the scene, and the server runs in its own console, > >> so it's impossible make a simple redirection by passing in/out handles to > >> CreateProcess. So using a pipe

Re: [PATCH 3/5] wined3d: Pass a wined3d_resource_desc structure to wined3d_texture_create_cube().

2013-06-05 Thread Henri Verbeet
On 5 June 2013 11:22, Stefan Dösinger wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 2013-06-05 11:06, schrieb Henri Verbeet: >> +desc.width = edge_length; +desc.height = edge_length; + >> desc.depth = 1; > Wouldn't it make sense to either set desc.height = 1 or desc.depth

Re: ole32: Add a basic OLE client/server test suite. Take 2.

2013-06-05 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Dmitry Timoshkov wrote: > >> Alexandre Julliard wrote: >> >> > It seems to be awfully complicated. In particular I don't think you need >> > a shared mapping plus a pipe plus a mutex just to log tracing >> > output. Redefining standard macros is also not a good idea.

Re: [PATCH] d3dx9_36: Implement ID3DXSkinInfoImpl_UpdateSkinnedMesh.

2013-06-05 Thread Christian Costa
2013/6/5 Rico Schüller > On 05.06.2013 08:48, Christian Costa wrote: > >> bone = &This->bones[bone_num]; >> +/* Decrement refcounts of vertices previously influenced */ >> +for (i = 0; i < bone->num_influences; i++) >> +if (bone->vertices[i] < This->num_vertices) /* Ignore o

Re: [PATCH 3/5] wined3d: Pass a wined3d_resource_desc structure to wined3d_texture_create_cube().

2013-06-05 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-06-05 11:06, schrieb Henri Verbeet: > +desc.width = edge_length; +desc.height = edge_length; + > desc.depth = 1; Wouldn't it make sense to either set desc.height = 1 or desc.depth = edge_length? -BEGIN PGP SIGNATURE- Version: G

Re: [PATCH 1/2] server: Don't create new handle when DUP_HANDLE_CLOSE_SOURCE is used if possible (try2)

2013-06-05 Thread Piotr Caban
On 06/04/13 21:56, Alexandre Julliard wrote: Piotr Caban writes: @@ -890,6 +890,7 @@ struct rawinput_device obj_handle_t handle; /* duplicated handle in dst process */ int self; /* is the source the current process? */ int closed; /* whet

Re: ole32: Add a basic OLE client/server test suite. Take 2.

2013-06-05 Thread Dmitry Timoshkov
Dmitry Timoshkov wrote: > Alexandre Julliard wrote: > > > It seems to be awfully complicated. In particular I don't think you need > > a shared mapping plus a pipe plus a mutex just to log tracing > > output. Redefining standard macros is also not a good idea. > > Launching the server in respo

Re: [PATCH] d3dx9_36: Implement ID3DXSkinInfoImpl_UpdateSkinnedMesh.

2013-06-05 Thread Rico Schüller
On 05.06.2013 08:48, Christian Costa wrote: bone = &This->bones[bone_num]; +/* Decrement refcounts of vertices previously influenced */ +for (i = 0; i < bone->num_influences; i++) +if (bone->vertices[i] < This->num_vertices) /* Ignore out of range value */ +This