Re: ole32: Add a basic OLE client/server test suite. Take 2.

2013-05-31 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > It seems to be awfully complicated. In particular I don't think you need > a shared mapping plus a pipe plus a mutex just to log tracing > output. Redefining standard macros is also not a good idea. Launching the server in responce to say CoCreateInstance is out of ou

Re: [1/2] DWrite: Implemented functions regarding text alignment. (try 3)

2013-05-31 Thread Nikolay Sivov
On Fri, May 31, 2013 at 9:07 PM, Fabian Müntefering wrote: > Implemented functions of text format and text layout regarding text > alignment. > > Try 3: Used proper enum value to set the enum variables. > > > > > +if(alignment!=DWRITE_TEXT_ALIGNMENT_CENTER && alignment!=DWRITE_TEXT_ALIGNMENT_L

Re: ole32: Add a basic OLE client/server test suite. Take 2.

2013-05-31 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Dmitry Timoshkov wrote: > >> With minor clean ups and with increased timeout to wait for server >> termination >> to please some really slow VMs (that allowed to remove broken() statements). > > It would be helpful to provide some feedback and explain the 'pending' st

Re: ole32: Add a basic OLE client/server test suite. Take 2.

2013-05-31 Thread Dmitry Timoshkov
Dmitry Timoshkov wrote: > With minor clean ups and with increased timeout to wait for server termination > to please some really slow VMs (that allowed to remove broken() statements). It would be helpful to provide some feedback and explain the 'pending' state of the patch which adds a test. --

Re: [PATCH] slc: Fix return type

2013-05-31 Thread Christian Costa
2013/5/31 Detlef Riekenberg > Christian wrote at Wednesday, 29. Mai 2013 at 23:12 Uhr > > > > + */ > > > +HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR name, DWORD > *pvalue) > > > +{ > > > > > > -SLCAPI DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR > lpszValueName, LPDWORD pdwValue); >

Re: [PATCH] winmm/tests: Fix test that fails on NT4

2013-05-31 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25788 Your paranoid android

Re: [1/2] explorer: Initial implementation of desktop launchers.

2013-05-31 Thread Hans Leidekker
On Fri, 2013-05-31 at 03:30 +0800, Qian Hong wrote: > On Tue, May 28, 2013 at 6:42 PM, Hans Leidekker wrote: > > +hr = SHGetKnownFolderPath( &FOLDERID_Desktop, 0, NULL, &desktop_folder > > ); > > +if (FAILED( hr )) > > +{ > > +WINE_ERR("Could not get user desktop folder\n"); >