Re: [PATCH] slc: Fix return type

2013-05-30 Thread Detlef Riekenberg
Christian wrote at Wednesday, 29. Mai 2013 at 23:12 Uhr > > + */ > > +HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR name, DWORD *pvalue) > > +{ > > > > -SLCAPI DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR lpszValueName, > > LPDWORD pdwValue); > > +SLCAPI HRESULT WINAPI SLGetWindowsIn

Re: [1/2] explorer: Initial implementation of desktop launchers.

2013-05-30 Thread Qian Hong
Hello Hans, On Tue, May 28, 2013 at 6:42 PM, Hans Leidekker wrote: > +hr = SHGetKnownFolderPath( &FOLDERID_Desktop, 0, NULL, &desktop_folder ); > +if (FAILED( hr )) > +{ > +WINE_ERR("Could not get user desktop folder\n"); > +return; > +} > +hr = SHGetKnownFolde

Re: [PATCH 2/4] d3dxof: Move list type and list nb elements into the parse context.

2013-05-30 Thread Alexandre Julliard
Christian Costa writes: > --- > dlls/d3dxof/d3dxof_private.h |2 ++ > dlls/d3dxof/parsing.c| 23 ++- > 2 files changed, 12 insertions(+), 13 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so me

Re: [2/2] advpack: Handle quoted arguments to rundll exports.

2013-05-30 Thread Alexandre Julliard
Vincent Povirk writes: > @@ -205,13 +205,24 @@ static HRESULT run_setup_commands_callback(HINF hinf, > PCWSTR field, const void * > > /* sequentially returns pointers to parameters in a parameter list > * returns NULL if the parameter is empty, e.g. one,,three */ > -LPWSTR get_parameter(LP

Re: [2/3] DWrite: Implemented functions regarding text alignment. (try 2)

2013-05-30 Thread Fabian Müntefering
Am 30.05.2013 19:49, schrieb Alexandre Julliard: > Fabian Müntefering writes: > >> @@ -1023,6 +1034,9 @@ HRESULT create_textformat(const WCHAR *family_name, >> IDWriteFontCollection *colle >> This->format.size = size; >> This->format.stretch = stretch; >> >> +/*Default values.*/ >

Re: [2/3] DWrite: Implemented functions regarding text alignment. (try 2)

2013-05-30 Thread Alexandre Julliard
Fabian Müntefering writes: > @@ -1023,6 +1034,9 @@ HRESULT create_textformat(const WCHAR *family_name, > IDWriteFontCollection *colle > This->format.size = size; > This->format.stretch = stretch; > > +/*Default values.*/ > +This->format.text_align = 0; Please use proper enum

Re: [1/4] kernel32: Add more GlobalReAlloc/LocalReAlloc tests.

2013-05-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25773 Your paranoid android

Re: [4/4] kernel32: Don't move fixed memory area in GlobalReAlloc. (try 3)

2013-05-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25774 Your paranoid android

Re: msvcrt: remove hack

2013-05-30 Thread Henri Verbeet
On 30 May 2013 07:23, Austin English wrote: > and no modern gcc/other compiler that I can find cares. > It does if you add -Wunused-parameter, but then you'll get a lot of other warnings as well. IMO the "action = action;" line is pretty pointless and best just removed, though if people are just l

Re: msvcrt: remove hack

2013-05-30 Thread Joel Holdsworth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 30/05/13 12:56, Dmitry Timoshkov wrote: > Christian Costa wrote: > >> and no modern gcc/other compiler that I can find cares. > It was probably added because of a tool that warned of the > unused parameter ... So it all goes in circles

Re: msvcrt: remove hack

2013-05-30 Thread Christian Costa
Le 30/05/2013 13:56, Dmitry Timoshkov a écrit : Christian Costa wrote: and no modern gcc/other compiler that I can find cares. It was probably added because of a tool that warned of the unused parameter ... So it all goes in circles. ;) Ciao, Marcus So what about action = NULL instead?

Re: msvcrt: remove hack

2013-05-30 Thread Dmitry Timoshkov
Christian Costa wrote: > and no modern gcc/other compiler that I can find cares. > >>> It was probably added because of a tool that warned of the unused > >>> parameter ... So it all goes in circles. ;) > >>> > >>> Ciao, Marcus > >>> > >>> > >>> > >> So what about action = NULL instead? > >

Re: msvcrt: remove hack

2013-05-30 Thread Christian Costa
Le 30/05/2013 10:59, Dmitry Timoshkov a écrit : Christian Costa wrote: and no modern gcc/other compiler that I can find cares. It was probably added because of a tool that warned of the unused parameter ... So it all goes in circles. ;) Ciao, Marcus So what about action = NULL instead?

Re: msvcrt: remove hack

2013-05-30 Thread Dmitry Timoshkov
Christian Costa wrote: > >> and no modern gcc/other compiler that I can find cares. > > It was probably added because of a tool that warned of the unused > > parameter ... So it all goes in circles. ;) > > > > Ciao, Marcus > > > > > > > So what about action = NULL instead? A checker tool should

Re: msvcrt: remove hack

2013-05-30 Thread Christian Costa
Le 30/05/2013 09:54, Marcus Meissner a écrit : On Wed, May 29, 2013 at 10:23:29PM -0700, Austin English wrote: This was added 12 years ago in 1db20bfd33f9c1486a1a662c2f78f45d00caf24b but clang doesn't like it: clang -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_MT -D_REENTRA

Re: msvcrt: remove hack

2013-05-30 Thread Marcus Meissner
On Wed, May 29, 2013 at 10:23:29PM -0700, Austin English wrote: > This was added 12 years ago in 1db20bfd33f9c1486a1a662c2f78f45d00caf24b > > but clang doesn't like it: > clang -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ > -D_MT -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasin