Re: GSoC 2013 has begun!

2013-05-29 Thread Austin English
On Tue, May 28, 2013 at 2:50 PM, Austin English wrote: > Howdy, > > Wine has accepted 4 student proposals for Google Summer of Code 2013: > George Stephanos, "Registry - implement merging between HKCR and > HKCU\Software\Classes" mentored by Detlef Riekenberg > Jactry Zeng, "Implement ITextDocumen

re: [PATCH (try 2)] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode

2013-05-29 Thread Maarten Lankhorst
NAK. + HeapFree(GetProcessHeap(), 0, device->primary_pwfx); + device->primary_pwfx = DSOUND_CopyFormat(passed_fmt); Copy to a tmp buffer first and return E_OUTOFMEMORY instead of reassigning primary_pwfx to NULL? ~Maarten

Re: Christian Costa : d3dx9_36: Implement skin mesh loading.

2013-05-29 Thread gurketsky
Hi, just saw that a bit late. Is there a reason for the rewrite of hr? Could any call return anything other than D3D_OK and succeed (maybe S_FALSE)? It may be possible to drop "if (FAILED(hr)) goto end;" (for both cases) and "hr = D3D_OK"... Also the function (parse_mesh) seems to overwrite t

Re: dinput: Update existing joystick values after setting the range property

2013-05-29 Thread Austin English
On Sun, Apr 14, 2013 at 2:25 PM, Bassi, Gurmail wrote: > ePSXe polls the joystick immediately after setting the axis range property, > and uses the returned values as its 'centered' calibrated values - therefore > the existing joystick state values must be remapped to the new range (or else > t

Re: [PATCH] slc: Fix return type

2013-05-29 Thread Christian Costa
Le 29/05/2013 12:06, Detlef Riekenberg a écrit : -- By by ... Detlef --- dlls/slc/slc.c | 31 +++ include/slpublic.h |2 +- 2 files changed, 24 insertions(+), 9 deletions(-) diff --git a/dlls/slc/slc.c b/dlls/slc/slc.c index e7416f1..7fc9b93 100644 --- a

Re: (try 2)macdrv: rework the way we handle cursor position and composition text

2013-05-29 Thread Ken Thomases
On May 29, 2013, at 1:11 PM, Aric Stewart wrote: > --- > dlls/winemac.drv/cocoa_window.m | 9 + > dlls/winemac.drv/event.c| 5 --- > dlls/winemac.drv/ime.c | 85 + > dlls/winemac.drv/macdrv.h | 1 - > dlls/winemac.drv/macdrv_cocoa.h

Re: macdrv: rework the way we handle cursor position and composition text

2013-05-29 Thread Aric Stewart
ok, resent. -aric On 5/29/13 12:38 PM, Ken Thomases wrote: > On May 29, 2013, at 10:37 AM, Aric Stewart wrote: > >> --- >> dlls/winemac.drv/cocoa_window.m | 9 + >> dlls/winemac.drv/event.c| 3 -- >> dlls/winemac.drv/ime.c | 85 >> + >

Re: macdrv: rework the way we handle cursor position and composition text

2013-05-29 Thread Ken Thomases
On May 29, 2013, at 10:37 AM, Aric Stewart wrote: > --- > dlls/winemac.drv/cocoa_window.m | 9 + > dlls/winemac.drv/event.c| 3 -- > dlls/winemac.drv/ime.c | 85 + > dlls/winemac.drv/macdrv.h | 1 - > dlls/winemac.drv/macdrv_cocoa.h

Re: [1/3] DWrite: Added missing JUSTIFIED text alignment mode.

2013-05-29 Thread Nikolay Sivov
Hi, Fabian. You forgot to attach patches 2 and 3.

Re: [PATCH (try 2)] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode

2013-05-29 Thread Andrew Eikum
On Wed, May 29, 2013 at 01:10:56PM +0200, Maarten Lankhorst wrote: > NAK. > > + HeapFree(GetProcessHeap(), 0, device->primary_pwfx); > + device->primary_pwfx = DSOUND_CopyFormat(passed_fmt); > Copy to a tmp buffer first and return E_OUTOFMEMORY instead of reassigning > pri

Re: Christian Costa : d3dx9_36: Implement skin mesh loading.

2013-05-29 Thread Christian Costa
Hi, You're right. This can be simplified. Will send a patch. Thanks. Christian 2013/5/29 gurketsky > Hi, > > just saw that a bit late. Is there a reason for the rewrite of hr? > > Could any call return anything other than D3D_OK and succeed (maybe > S_FALSE)? It may be possible to drop "if (FA

Re: Increment, Decrement, and Assignment Operators

2013-05-29 Thread Alexandre Julliard
Stephen Leibowitz writes: > Hello: > > This is my first patch. The changes are minor. If it works out, I may > attempt something more substantial. Doing cosmetic changes like this across the code base is not a good idea. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH] gdi32: Ask for a newer FreeType version

2013-05-29 Thread Alexandre Julliard
Detlef Riekenberg writes: > @@ -3686,7 +3686,8 @@ static BOOL init_freetype(void) > WINE_MESSAGE( >"Wine cannot find the FreeType font library. To enable Wine to\n" >"use TrueType fonts please install a version of FreeType greater > than\n" > - "or equal to 2.0.5.\

GSoC 2013 has begun!

2013-05-29 Thread Austin English
Howdy, Wine has accepted 4 student proposals for Google Summer of Code 2013: George Stephanos, "Registry - implement merging between HKCR and HKCU\Software\Classes" mentored by Detlef Riekenberg Jactry Zeng, "Implement ITextDocument in Richedit" mentored by Huw Davies John Chadwick, "MSXML - Imple