Re: server: Always redraw children when parent's pos/size changed in any way (Try 2).

2013-05-08 Thread Sergey Guralnik
On 2013-05-06 13:24, Sergey Guralnik wrote: Alexandre Julliard writes: ... It doesn't make sense to have all these complicated tests if we are going to always repaint anyway, which is essentially what your patch does. There has to be more to it than that. This version uses the same logic as us

Re: [PATCH 3/3] iphlpapi: Implement CancelIPChangeNotify.

2013-05-08 Thread Erich E. Hoover
On Tue, May 7, 2013 at 12:26 PM, Hans Leidekker wrote: > ... > It's a system-wide event so the server seems to be a pretty good candidate > to handle it, and it wouldn't need any extra threads. > ... Ok, how about something like the attached? (I assume the first patch is OK) Best, Erich 0002-

Re: [Patch 1/2] user32/tests: Added test to show EnableWindow cause wrong ReleaseCapture

2013-05-08 Thread Qian Hong
Hi orzhvs, Thanks for your work on it, however, it seems gmail's line wrap 'feature' (hmm, isn't that a bug...) breaks your patch, you could try fight with that feature or send your patch as attachment instead.

Re: [Patch 1/2] user32/tests: Added test to show EnableWindow cause wrong ReleaseCapture

2013-05-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25486 Your paranoid android

Re: [PATCH] d3dx9_36: Fix typo in ID3DXFileDataImpl_GetName.

2013-05-08 Thread Christian Costa
Le 08/05/2013 19:19, Dmitry Timoshkov a écrit : Christian Costa wrote: -if (!name || !size) +if (!name && !size) return E_POINTER; dxfile_size = *size; So, what happens if name is not NULL, but size is? Indeed I missed this type conversion line and expected IDirec

Re: [PATCH] d3dx9_36: Fix typo in ID3DXFileDataImpl_GetName.

2013-05-08 Thread Dmitry Timoshkov
Christian Costa wrote: > -if (!name || !size) > +if (!name && !size) > return E_POINTER; > > dxfile_size = *size; So, what happens if name is not NULL, but size is? -- Dmitry.

Re: [PATCH] msi: Specify in FIXME that functions are semi-stub as for MsiMessageBoxEx. (resend)

2013-05-08 Thread Alexandre Julliard
Christian Costa writes: > Le 08/05/2013 12:43, Alexandre Julliard a écrit : >> Christian Costa writes: >> >>> { >>> -FIXME("%p %s %s %u %08x %08x\n", hWnd, debugstr_w(lpText), >>> debugstr_w(lpCaption), >>> - uType, wLanguageId, f); >>> -return MessageBoxExW(hWnd,lpText,lpCap

Re: gdi32: Simplify font->aveWidth sanity-checking to fix possible division by zero. (try 2)

2013-05-08 Thread Christian Costa
Le 08/05/2013 11:45, Sam Edwards a écrit : After feedback from Dmitry (thanks!), I redid this patch with the following changes: * I misunderstood before what the test did; I initially thought this was just a workaround to get aveWidth to behave, but as it turns out, Windows has the same "maxi

Re: [PATCH] msi: Specify in FIXME that functions are semi-stub as for MsiMessageBoxEx. (resend)

2013-05-08 Thread Christian Costa
Le 08/05/2013 12:43, Alexandre Julliard a écrit : Christian Costa writes: { -FIXME("%p %s %s %u %08x %08x\n", hWnd, debugstr_w(lpText), debugstr_w(lpCaption), - uType, wLanguageId, f); -return MessageBoxExW(hWnd,lpText,lpCaption,uType,wLanguageId); +FIXME("(%p, %s, %s,

Re: [PATCH] msi: Specify in FIXME that functions are semi-stub as for MsiMessageBoxEx. (resend)

2013-05-08 Thread Alexandre Julliard
Christian Costa writes: > { > -FIXME("%p %s %s %u %08x %08x\n", hWnd, debugstr_w(lpText), > debugstr_w(lpCaption), > - uType, wLanguageId, f); > -return MessageBoxExW(hWnd,lpText,lpCaption,uType,wLanguageId); > +FIXME("(%p, %s, %s, %u, 0x%08x, 0x%08x): semi-stub\n", hWnd,

Re: [2/2] comdlg32: Add a test for nCopies/dmCopies returned by PrintDlg.

2013-05-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25483 Your paranoid android

Re: [PATCH] mscms: Use lcms2, when available

2013-05-08 Thread Hans Leidekker
On Tue, 2013-05-07 at 22:45 +0200, Detlef Riekenberg wrote: > lcms2 was released on 8. May 2010 and should be present in important > distributions since a while. > > lcms v1 is on the way to be phased out in the newest distribution > versions. Are there any distributions that have released withou

Re: [1/5] kernel32: Add more remote process tests.

2013-05-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25479 Your paranoid android