Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

2013-05-06 Thread Max TenEyck Woodbury
On 05/05/2013 06:27 PM, Sam Edwards wrote: So, Wine's font loader seems to be working appropriately and thus the sane thing to do is to make sure tmHeight=0 is handled gracefully. Just to make this clear, the most recent version of this patch is such a graceful handling, right?

Re: d3dx9 [patch 2 / 3]: Avoid useless computations in D3DXMatrixAffineTransformation

2013-05-06 Thread Rico Schüller
On 05.05.2013 23:01, Nozomi Kodama wrote: +FLOAT xw, xx, xy, xz, yw, yy, yz, zw, zz; I'm not very happy with the additional amount of variables... Please have a look at the attached patches. I think something like the first one (d3dx9: Apply rotationcenter only when a rotation is don

Re: d3dx9 [patch 1 / 3]: Avoid useless computations in D3DXMatrixAffineTransformation2D

2013-05-06 Thread Rico Schüller
On 05.05.2013 23:00, Nozomi Kodama wrote: +FLOAT tmp1, tmp2; +tmp1 = cosf(rotation); +tmp2 = sinf(rotation); As of it is really clear what's in those variables, we may name them with a better name instead of tmp1/tmp2 ... but I'm fine with either version. Cheers Rico

Re: [1/3] server: Add a process flag indicating whether the process is terminating, use it to block thread creation in a bei

2013-05-06 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25445 Your paranoid android

Re: [1/3] server: Add a process flag indicating whether the process is terminating, use it to block thread creation in a bei

2013-05-06 Thread Dmitry Timoshkov
Marvin wrote: > === W7PROX64 (64 bit loader) === > loader.c:1638: Test failed: expected WAIT_OBJECT_0, got 0x102 > loader.c:1648: Test failed: expected thread exit code 196, got 259 > loader.c:1210: Test failed: expected thread exit code 196, got 259 > loader.c:1220: Test failed: expected WAIT_AB