Re: user32: SetTimer should respect the minimum and maximum timeout limits (try 2).

2013-04-26 Thread Alexandre Julliard
"Erich E. Hoover" writes: > So, this particular patch fixes the minimum and maximum timeout limits > for SetTimer, which has a significant impact on any application using > SetTimer to render video (Bug #32489). The old minimum timeout (55 > ms) is nowhere near short enough to render video at 24

Re: msvcrt.h: Use inline function to forward hypot to _hypot.

2013-04-26 Thread Jacek Caban
On 04/26/13 16:18, Alexandre Julliard wrote: > Jacek Caban writes: > >> On 04/26/13 14:46, Alexandre Julliard wrote: >>> Jacek Caban writes: >>> This fixes compiling msvcp* DLLs with recent mingw-w64 trunk version. Previous versions had a separated library that contained forwards from >

Re: msvcrt.h: Use inline function to forward hypot to _hypot.

2013-04-26 Thread Alexandre Julliard
Jacek Caban writes: > On 04/26/13 14:46, Alexandre Julliard wrote: >> Jacek Caban writes: >> >>> This fixes compiling msvcp* DLLs with recent mingw-w64 trunk version. >>> Previous versions had a separated library that contained forwards from >>> underscored functions to non-underscored, which I

Re: [PATCH 1/2] gdi32: Clip font glyphs to fit within text metrics. (try 2)

2013-04-26 Thread Michael Stefaniuc
On 04/26/2013 05:54 AM, Sam Edwards wrote: On 04/25/2013 12:28 PM, Alexandre Julliard wrote: It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so ../../../../wine/dlls/comctl32/tests/listview.c && touch listview.ok wine: Unhandled

Re: msvcrt.h: Use inline function to forward hypot to _hypot.

2013-04-26 Thread Jacek Caban
On 04/26/13 14:46, Alexandre Julliard wrote: > Jacek Caban writes: > >> This fixes compiling msvcp* DLLs with recent mingw-w64 trunk version. >> Previous versions had a separated library that contained forwards from >> underscored functions to non-underscored, which I believe made using >> hypot w

Re: msvcrt.h: Use inline function to forward hypot to _hypot.

2013-04-26 Thread Alexandre Julliard
Jacek Caban writes: > This fixes compiling msvcp* DLLs with recent mingw-w64 trunk version. > Previous versions had a separated library that contained forwards from > underscored functions to non-underscored, which I believe made using > hypot work. Those were currently moved directly to msvcr* i

[PATCH v6 7/7] locks: Disable LOCK_MAND support for MS_SHARELOCK mounts

2013-04-26 Thread Pavel Shilovsky
Signed-off-by: Pavel Shilovsky --- fs/locks.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/locks.c b/fs/locks.c index 25c3a49..7d67e0e 100644 --- a/fs/locks.c +++ b/fs/locks.c @@ -1756,6 +1756,12 @@ SYSCALL_DEFINE2(flock, unsigned int, fd, unsigned int, cmd) goto

[PATCH v6 4/7] CIFS: Add O_DENY* open flags support

2013-04-26 Thread Pavel Shilovsky
Construct share_access value from O_DENY* flags and send it to the server. Use NTCreateAndX command rather than Trans2 all the time we have any of O_DENY* flags regardless of unix extensions support. Also change smb error mapping of NT_STATUS_SHARING_VIOLATION to -ESHAREDENIED. Signed-off-by: Pave

[PATCH v6 0/7] Add O_DENY* support for VFS and CIFS/NFS

2013-04-26 Thread Pavel Shilovsky
Main changes from v5: 1) O_DENYDELETE is now supported by VFS. 2) ESHAREDENIED erro code is introduced to be returned on sharelock conflicts. 3) forcemand dependancy is removed. CIFS module detects if it should use NTCreateAndX command according to existence of O_DENY flags. 4) Term 'deny lock' is

[PATCH v6 6/7] NFSD: Pass share reservations flags to VFS

2013-04-26 Thread Pavel Shilovsky
that maps them into O_DENY* flags and make them visible for applications on mounts with sharelock option. Signed-off-by: Pavel Shilovsky --- fs/locks.c | 1 + fs/nfsd/nfs4state.c | 46 +- fs/nfsd/nfsproc.c | 1 + 3 files changed, 47 insert

[PATCH v6 5/7] NFSv4: Add O_DENY* open flags support

2013-04-26 Thread Pavel Shilovsky
by passing these flags to NFSv4 open request. Make it return -ESHAREDENIED on share conflicts with other opens and disable O_DENYDELETE support since NFSv4 doesn't support it. Signed-off-by: Pavel Shilovsky --- fs/nfs/dir.c | 4 fs/nfs/internal.h | 3 ++- fs/nfs/nfs4file.c | 4 ++

[PATCH v6 3/7] CIFS: Add share_access parm to open request

2013-04-26 Thread Pavel Shilovsky
and simplify CIFSSMBOpen params. Signed-off-by: Pavel Shilovsky --- fs/cifs/cifsacl.c | 8 fs/cifs/cifsglob.h | 2 +- fs/cifs/cifsproto.h | 8 fs/cifs/cifssmb.c | 50 +++--- fs/cifs/dir.c | 12 ++-- fs/cifs/file.

[PATCH v6 2/7] VFS: Add O_DENYDELETE support for VFS

2013-04-26 Thread Pavel Shilovsky
Introduce new LOCK_DELETE flock flag that is suggested to be used internally only to map O_DENYDELETE open flag: !O_DENYDELETE -> LOCK_DELETE | LOCK_MAND. Signed-off-by: Pavel Shilovsky --- fs/locks.c | 53 +--- fs/namei.c

[PATCH v6 1/7] VFS: Introduce new O_DENY* open flags

2013-04-26 Thread Pavel Shilovsky
This patch adds 3 flags: 1) O_DENYREAD that doesn't permit read access, 2) O_DENYWRITE that doesn't permit write access, 3) O_DENYDELETE that doesn't permit delete or rename. Network filesystems CIFS, SMB2.0, SMB3.0 and NFSv4 have such flags - this change can benefit cifs and nfs modules as well a

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

2013-04-26 Thread Henri Verbeet
On 26 April 2013 12:41, Jacek Caban wrote: > On 04/26/13 12:02, Henri Verbeet wrote: >> On 26 April 2013 10:27, Jacek Caban wrote: >>> - round is not portable. As I mentioned you before, Wine needs to be C89 >>> compatible. If we need some features that are not part of C89, we need >>> to be care

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

2013-04-26 Thread Jacek Caban
On 04/26/13 12:02, Henri Verbeet wrote: > On 26 April 2013 10:27, Jacek Caban wrote: >> - round is not portable. As I mentioned you before, Wine needs to be C89 >> compatible. If we need some features that are not part of C89, we need >> to be careful about that and it often requires things like c

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

2013-04-26 Thread Henri Verbeet
On 26 April 2013 10:27, Jacek Caban wrote: > - round is not portable. As I mentioned you before, Wine needs to be C89 > compatible. If we need some features that are not part of C89, we need > to be careful about that and it often requires things like configure > checks. In case of round, replacin

Names with particles on South Africa and Namibia should be in the particle on the AUTHORS file.

2013-04-26 Thread Tae Wong
You have posted a message to show how surnames with particles of South Africa and Namibia show in the credits, like van Schayck listed in S and not under V: For example, van Schayck is under S and not in V. Note that the name of the file is in all capitals. Here is a correction of the va section, w

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

2013-04-26 Thread Jacek Caban
Hi Zhan, It's better, thanks, but still needs more work. On 04/25/13 23:37, Zhan Jianyu wrote: > } > > + > + While we're at this, please put more attention into whitespace changes, esp. useless ones. > static HRESULT to_double(VARIANT *v, double *ret) > { > switch(V_VT(v)) { > @@ -217