Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics.

2013-04-18 Thread Dmitry Timoshkov
Sam Edwards wrote: > This change only affects malformed fonts that have glyphs with splines > that go above the maximum ascent as specified in the font's hhea/os2 > table. For that reason, any tests for this change would have to include > a malformed font, so I did not write tests. If we want

Re: GetKeyboardState problems in Age of Empires II

2013-04-18 Thread Stevie Trujillo
I tried to make a test case now. It's tested on wine-1.5.27 since I don't have enough battery to compile new wine. $ winegcc test.c -o test Issue1, the 0x40 bit: $ ./test.exe 00 00 00 00 00 00 00 00 *press LEFT arrow* 81 00 00 00 *release LEFT arrow* 01 00 00 00 *ALTTAB* 41 00 00 00 Issue2, LE

Re: GetKeyboardState problems in Age of Empires II

2013-04-18 Thread Stevie Trujillo
On Thu, 18 Apr 2013 17:39:33 +0900 Dmitry Timoshkov wrote: > [please don't omit wine-devel when replying] > > Stevie Trujillo wrote: > > > > Stevie Trujillo wrote: > > > > Another (minor) problem raised in the bugzilla entry is that, > > > > if a key is pressed when changing window, and relea

Clang static analyzer results / wine-1.5.28-66-g6899279

2013-04-18 Thread Austin English
With wine-1.5.20 and clang 3.2, the test suite is in the same state on my Fedora 18 machine as gcc-4.7.2 llvm version: git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@17976891177308-0d34-0410-b5e6-96231b3b80d8 clang version: git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@1797

Re: Fun with GCC 4.8

2013-04-18 Thread Austin English
On Thu, Apr 18, 2013 at 1:32 AM, James Eder wrote: > > > > On Mon, Apr 15, 2013 at 3:58 PM, Marcus Meissner wrote: > >> On Mon, Apr 15, 2013 at 02:37:27PM -0600, James Eder wrote: >> > As many of you no doubt know, GCC recently released 4.8.0. This new >> > version introduces a new optimization

Re: winex11.drv: Transmit WM_DEADCHAR messages to applications

2013-04-18 Thread Alexandre Julliard
Simon Lipp writes: > @@ -389,6 +389,10 @@ static int process_events( Display *display, Bool > (*filter)(Display*, XEvent*,XP > count++; > if (XFilterEvent( &event, None )) > { > +KeySym keysym = 0; > +XLookupString(&event.xkey, NULL, 0, &keysym,

Re: gdi32/tests: Use if(0) instead of #if 0 to make sure the code still compiles.

2013-04-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25164 Your paranoid android

Re: testbot: Default set of VMs to run the tests

2013-04-18 Thread Francois Gouget
On Wed, 17 Apr 2013, Dmitry Timoshkov wrote: [...] > I still need to manually enable WXPX64 and WXPPROSP2 when I send a test > to testbot. I thought I had switched them to base already but maybe not. I did so again yesterday and rechecked today and it looks like it's ok now. -- Francois Gouget

Re: [PATCH 3/3]vbscript: Implemented builtin function CBool

2013-04-18 Thread Zhan Jianyu
On Thu, Apr 18, 2013 at 6:24 PM, Jacek Caban wrote: > > I don't think converting to double is a good idea here. Why don't you do > conversions directly to BOOL for all cases? > My fisrt thought on this is to convert all type to double, and then at last I just do one-time comparision, to avoid

Re: Application for GSoC 2013

2013-04-18 Thread Jacek Caban
On 04/18/13 12:06, larmbr zhan wrote: >> You're going to have to be (much) more specific with your application, what >> modules do you plan to implement, what applications does this help (if you >> know of any), etc. > Actually I am a huge fan of underlying stuff like OS, programming > language int

Re: [PATCH 3/3]vbscript: Implemented builtin function CBool

2013-04-18 Thread Jacek Caban
On 04/17/13 18:18, larmbr zhan wrote: > +double tmp; > +WCHAR trueW[] = {'T','r','u','e','\0'}; > +WCHAR falseW[] = {'F','a','l','s','e','\0'}; > + > +TRACE("%s\n", debugstr_variant(arg)); > + > +assert(args_cnt == 1); > + > +switch(V_VT(arg)) { > +case VT_I2: > +

Re: [PATCH 2/3]vbscript: Implemented builtin function CInt

2013-04-18 Thread Jacek Caban
On 04/17/13 18:17, larmbr zhan wrote: > +static HRESULT to_int_banker_rounding(VARIANT *v, int *ret) > +{ I wonder if this conversion is used in any other place as well. I think this does not need a helper function until we find other use cases as well, esp. since you could simplify that to: if(V

Re: Application for GSoC 2013

2013-04-18 Thread Jacek Caban
On 04/17/13 18:38, larmbr zhan wrote: > Hi all, > > I'm a junior student from a non-famous college, > I apply to parcitipate in GSoC , to help do some > vbscript module implementation. I've just submitted > a patchset on this. No worries, no collage name can give you as much as a patch. That's a

Re: Application for GSoC 2013

2013-04-18 Thread larmbr zhan
Hi, Austin. On Thu, Apr 18, 2013 at 3:00 AM, Austin English wrote: > While your college may not be famous, it's still nice information to have > (and let's us get to know you better). Well, I am a student from Defence Industry Staff College of GuangDong, China, and major in electric automatizati

Re: [2/3] mountmgr.sys: Remove an artificial limitation for removable drive letters.

2013-04-18 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Under Windows removable drives (USB sticks) can have drive letters such > as J: or K:. They are not considered floppy devices though. -- Alexandre Julliard julli...@winehq.org

Re: [2/2] kernel32: Count precise amount of child process failures.

2013-04-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25160 Your paranoid android

Re: [2/2] kernel32: Count precise amount of child process failures.

2013-04-18 Thread Dmitry Timoshkov
Marvin wrote: > === W2K8SE (32 bit loader) === > lloader.c:1686: Test failed: expected exit code 0, got 196 This patch is not supposed to change anything in test results. Looks like a spurious test failure in the VM, and I have no idea what version of Windows is that. -- Dmitry.

Re: GetKeyboardState problems in Age of Empires II

2013-04-18 Thread Dmitry Timoshkov
[please don't omit wine-devel when replying] Stevie Trujillo wrote: > > Stevie Trujillo wrote: > > > Another (minor) problem raised in the bugzilla entry is that, if a > > > key is pressed when changing window, and released before returning, > > > GetKeyboardState() will claim the key is still

Re: Fun with GCC 4.8

2013-04-18 Thread James Eder
On Mon, Apr 15, 2013 at 3:58 PM, Marcus Meissner wrote: > On Mon, Apr 15, 2013 at 02:37:27PM -0600, James Eder wrote: > > As many of you no doubt know, GCC recently released 4.8.0. This new > > version introduces a new optimization level enabled by -Og with the > > following description (from th

Re: msvcr110: forward __crtSetUnhandledExceptionFilter to kernel32.SetUnhandledExceptionFilter (try 3)

2013-04-18 Thread Austin English
On Wed, Apr 17, 2013 at 6:06 PM, Dmitry Timoshkov wrote: > Austin English wrote: > > > +LPTOP_LEVEL_EXCEPTION_FILTER > MSVCR110__crtSetUnhandledExceptionFilter(LPTOP_LEVEL_EXCEPTION_FILTER > filter) > > +{ > > +return SetUnhandledExceptionFilter(filter); > > +} > > msvcrt APIs need an explic