Re: testbot: Default set of VMs to run the tests

2013-04-16 Thread Dmitry Timoshkov
Francois Gouget wrote: > On Sat, 13 Apr 2013, Dmitry Timoshkov wrote: > [...] > > As I've pointed out, 64-bit XP and Vista VMs do exist and work just fine, > > please include at least them in the default VM set. > > I see. I have moved WXPX64 and WVISTAX64 to the base set of VMs. I still need t

Re: [PATCH 5/5] wined3d: Enable GL_ARB_texture_rectangle in GLSL ffp fragment shaders

2013-04-16 Thread Henri Verbeet
On 16 April 2013 17:10, Stefan Dösinger wrote: > fixme:d3d_shader:print_glsl_info_log Info log received from GLSL > shader #21: > fixme:d3d_shader:print_glsl_info_log Fragment info > fixme:d3d_shader:print_glsl_info_log - > fixme:d3d_shader:print_glsl_info_log 0(5) : error

Re: [PATCH 5/5] wined3d: Enable GL_ARB_texture_rectangle in GLSL ffp fragment shaders

2013-04-16 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-04-16 17:01, schrieb Henri Verbeet: > On 16 April 2013 14:48, Stefan Dösinger > wrote: >> +if (gl_info->supported[ARB_TEXTURE_RECTANGLE]) + >> shader_addline(buffer, "#extension GL_ARB_texture_rectangle : >> enable\n"); + > This may be a g

Re: [PATCH 2/5] d3d9/tests: Test NPOT texture creation

2013-04-16 Thread Henri Verbeet
On 16 April 2013 14:48, Stefan Dösinger wrote: > - * Copyright (C) 2006 Chris Robinson > + * Copyright (C) 2006 Chris Robinsontes This looks unintentional. > +UINT refcount; Technically refcounts are ULONGs, although I suppose it doesn't matter a whole lot.

Re: [PATCH 5/5] wined3d: Enable GL_ARB_texture_rectangle in GLSL ffp fragment shaders

2013-04-16 Thread Henri Verbeet
On 16 April 2013 14:48, Stefan Dösinger wrote: > +if (gl_info->supported[ARB_TEXTURE_RECTANGLE]) > +shader_addline(buffer, "#extension GL_ARB_texture_rectangle : > enable\n"); > + This may be a good idea anyway, but is this strictly required? IIRC ARB_texture_rectangle is the one spec

Re: d3dx9: Implement D3DXSHMultilpy5

2013-04-16 Thread Matteo Bruni
2013/4/15 Nozomi Kodama : > Hello > > thanks for the review. > I don't think that calling defines is the way to go. Indeed, I tested my > patch and yours. Yours is about 12% slower than mine in my computer. > And now, we try to take care of efficiency of this dll. So, it is not the > time to incre

Re: winex11.drv: Transmit WM_DEADCHAR messages to applications

2013-04-16 Thread Simon Lipp
> > > Wine should never generate WM_DEADCHAR message, it relies in the > > > driver to handle dead keys and generate final events. > > > > I’m sorry but I fail to see any incompatibility between the two > > alternatives. Wine can generate WM_DEADCHAR messages AND let X/input > > method handle the

Re: ieframe: Added DISPID_WINDOWCLOSING tests.

2013-04-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25096 Your paranoid android

Re: kernel32: Add a test to check event and mutex states during process termination.

2013-04-16 Thread Alexandre Julliard
Dmitry Timoshkov writes: > --- > dlls/kernel32/tests/loader.c | 40 +--- > 1 file changed, 33 insertions(+), 7 deletions(-) That's not a very meaningful test if nobody holds the mutex. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 6/6] ieframe: Added DISPID_WINDOWCLOSING tests.

2013-04-16 Thread Jacek Caban
On 04/15/13 18:08, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/

Re: winex11.drv: Transmit WM_DEADCHAR messages to applications

2013-04-16 Thread Dmitry Timoshkov
Simon Lipp wrote: > > That's how it's supposed to work. > > But it doesn’t work that way under Windows. Shouldn’t Wine try to stick > to Windows behavior as close as possible ? It depends. > > Wine should never generate WM_DEADCHAR message, it relies in the > > driver to handle dead keys and

Re: winex11.drv: Transmit WM_DEADCHAR messages to applications

2013-04-16 Thread Ken Thomases
On Apr 16, 2013, at 3:43 AM, Simon Lipp wrote: >> That's how it's supposed to work. > > But it doesn’t work that way under Windows. Shouldn’t Wine try to stick > to Windows behavior as close as possible ? > >> Wine should never generate WM_DEADCHAR message, it relies in the >> driver to handle

Re: winex11.drv: Transmit WM_DEADCHAR messages to applications

2013-04-16 Thread Simon Lipp
> That's how it's supposed to work. But it doesn’t work that way under Windows. Shouldn’t Wine try to stick to Windows behavior as close as possible ? > Wine should never generate WM_DEADCHAR message, it relies in the > driver to handle dead keys and generate final events. I’m sorry but I fail