Re: Fresh WineWiki Theme, Straight from the Farm

2013-04-11 Thread Kyle Auble
On Sun, Apr 7, 2013 at 8:43 AM, André Hentschel wrote: > First: Wow! You did a great job! Finally our Wiki theme is up to date :) > I had a look at some Pages already and they look perfect here with FF 20.0 > What i wonder is how we want to proceed with tables, i've seen different > tables already

Re: user32: SetTimer should respect the minimum and maximum timeout limits.

2013-04-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25036 Your paranoid android

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

2013-04-11 Thread Ken Thomases
On Apr 11, 2013, at 8:49 AM, Jacek Caban wrote: > On 04/10/13 16:16, Ken Thomases wrote: >> However, Apple's guidance on using weak linking says that you must >> explicitly compare against NULL. They don't quite say that testing the >> symbol as a standalone boolean expression won't work, but t

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

2013-04-11 Thread Jacek Caban
Hi Ken, On 04/10/13 16:16, Ken Thomases wrote: > Hi Jacek, > > On Apr 10, 2013, at 4:24 AM, Jacek Caban wrote: > >> On 3/28/13 8:31 PM, Ken Thomases wrote: >>> Mac OS X 10.8 introduced support for TLS 1.1 and 1.2. >> Can someone with Mac OS X 10.8 test the attached patch for me, please. All I >>

Re: [2/5] include/wine/test.h: Report child process failures using shared memory.

2013-04-11 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> The standard test code should be kept as simple as possible. Also >> creating extra mappings can potentially influence other tests. > > I still think that this code can be used on a general base, and if needed > mapping name could be made

Re: [2/5] include/wine/test.h: Report child process failures using shared memory.

2013-04-11 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > The standard test code should be kept as simple as possible. Also > creating extra mappings can potentially influence other tests. I still think that this code can be used on a general base, and if needed mapping name could be made more unlikely to dulicate. Especiall

Re: [2/5] include/wine/test.h: Report child process failures using shared memory.

2013-04-11 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> >> > As far as I can see ExitProcess returns 'failures' as the child process >> >> > exit >> >> > code, but variable 'failures' is not visible from the tests. Do you >> >> > have a >> >> > suggestion how to fix that? >> >> >> >> You nee

Re: [2/5] include/wine/test.h: Report child process failures using shared memory.

2013-04-11 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > >> > As far as I can see ExitProcess returns 'failures' as the child process > >> > exit > >> > code, but variable 'failures' is not visible from the tests. Do you have > >> > a > >> > suggestion how to fix that? > >> > >> You need to report the status a different wa

Re: [PATCH 1/2] wined3d: Use the np2_fixup to find out if a RECT texture is used

2013-04-11 Thread Henri Verbeet
On 11 April 2013 11:32, Stefan Dösinger wrote: > @@ -1069,17 +1069,17 @@ static void shader_generate_glsl_declarations(const > struct wined3d_context *cont > shader_addline(buffer, "uniform sampler1D > %s_sampler%u;\n", prefix, i); > break; >

Re: [PATCH 2/2] wined3d: Store ps 1.4 texture types in ps_compile_args

2013-04-11 Thread Henri Verbeet
On 11 April 2013 11:40, Stefan Dösinger wrote: > +for (i = 0; i < 6; ++i) > +{ This could probably do with an appropriate constant. > +enum shader_tex_types > +{ > +shader_tex_2d = 0, > +shader_tex_3d = 1, > +shader_tex_cube = 2, > +}; Please use upperc

Re: GSoC 2013 proposal: Implement XPath from scratch

2013-04-11 Thread Nikolay Sivov
On 4/11/2013 05:52, John Chadwick wrote: Hello, I am a student of computer science interested in entering Wine development via GSoC 2013. Upon looking at the various suggested proposals, the project of reimplementing XPath without libxml2 looked particularly interesting. I am familiar with

Re: [2/5] include/wine/test.h: Report child process failures using shared memory.

2013-04-11 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> > As far as I can see ExitProcess returns 'failures' as the child process >> > exit >> > code, but variable 'failures' is not visible from the tests. Do you have a >> > suggestion how to fix that? >> >> You need to report the status a di