Re: [PATCH] winspool.drv: Check the value of pDeviceName.(try 2)

2013-04-03 Thread Tatyana Fokina
Nikolay Sivov писал 03.04.2013 15:56: > On Wed, Apr 3, 2013 at 1:31 PM, Tatyana Fokina wrote: > >> Function DocumentPropertiesA calling GDI_CallExtDeviceMode16: If value pDeviceName is "", from GDI_CallExtDeviceMode16 return -1. > > Is it possible to add a test for that? Yes, it is... I ha

Re: msvcr110: forward __crtSetUnhandledExceptionFilter to kernel32.SetUnhandledExceptionFilter (try 2)

2013-04-03 Thread Dmitry Timoshkov
Austin English wrote: > Try 2: use cdecl calling convention > -@ stub __crtSetUnhandledExceptionFilter > +@ cdecl __crtSetUnhandledExceptionFilter(ptr) > kernel32.SetUnhandledExceptionFilter It's not acceptable to mix calling conventions when forwarding an API with number of arguments != 0. -

Re: cmd: Remove a pointless linefeed in an error message.

2013-04-03 Thread Julian Rüger
Sorry for nagging ;) Wasn't the convention to assume an 80-character wide terminal? This line would wrap, then. So the linefeed is not totally pointless here. Please correct me, if I'm mistaken. Best regards, Julian Am Mittwoch, den 03.04.2013, 16:07 +0200 schrieb Francois Gouget: > --- > prog

Re: [PATCH 1/2] winspool.drv/tests: Add DocumentProperties test with empty pDeviceName.

2013-04-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24941 Your paranoid android

Re: [PATCH 2/2] winspool.drv: Check the value of pDeviceName.(try 2, resend)

2013-04-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24942 Your paranoid android

Re: [PATCH 8/8] configure: Get rid of no longer needed OpenSSL checks.

2013-04-03 Thread Marcus Meissner
On Wed, Apr 03, 2013 at 02:33:06PM +0200, Marcus Meissner wrote: > Hi, > > I have one concern ... > > Licensing. > > GNUTLS is (L)GPLv3+ these days. > Wine will now turn into a LPGLv3+ licensed binary (not the sources, just > the binaries will turn into it implicitly by linking against gnutls 3)

Re: [PATCH 8/8] configure: Get rid of no longer needed OpenSSL checks.

2013-04-03 Thread Marcus Meissner
Hi, I have one concern ... Licensing. GNUTLS is (L)GPLv3+ these days. Wine will now turn into a LPGLv3+ licensed binary (not the sources, just the binaries will turn into it implicitly by linking against gnutls 3). Ciao, Marcus On Wed, Apr 03, 2013 at 02:06:09PM +0200, Jacek Caban wrote: > ---

Re: [PATCH] winspool.drv: Check the value of pDeviceName.(try 2)

2013-04-03 Thread Nikolay Sivov
On Wed, Apr 3, 2013 at 1:31 PM, Tatyana Fokina wrote: > Function DocumentPropertiesA calling GDI_CallExtDeviceMode16: If value > pDeviceName is "", from GDI_CallExtDeviceMode16 return -1. > > Is it possible to add a test for that?

Re: ieframe: Added GoForward tests.

2013-04-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24939 Your paranoid android

Re: Hi Res Icons

2013-04-03 Thread Alexandre Julliard
Joel Holdsworth writes: > As you can see here, scaling the iexplore icons really shows the > limits of this artwork. The line caps are wrong in several places. The > worst being in the highlight of the yellow swoosh at the bottom - you > see the highlight doesn't line up with the border. A lot of

Hi Res Icons

2013-04-03 Thread Joel Holdsworth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Alexandre (+ Others), I notice you've been working on hi-res icons. I just have a couple of comments to chip in. So 2 years ago when I was doing the wine icon refresh, I decided not to try and tackle the problem of hi-res icons. Just getting th

Re: [PATCH 1/5] wined3d: Make fullscreen windows use HWND_TOPMOST instead of HWND_TOP. (try 3)

2013-04-03 Thread Henri Verbeet
I think this series looks good.