Re: [PATCH v3 0/7] Add O_DENY* support for VFS and CIFS/NFS

2013-02-28 Thread Andy Lutomirski
[possible resend -- sorry] On 02/28/2013 07:25 AM, Pavel Shilovsky wrote: > This patchset adds support of O_DENY* flags for Linux fs layer. These flags > can be used by any application that needs share reservations to organize a > file access. VFS already has some sort of this capability - now i

GSoC 2013 guidelines.

2013-02-28 Thread Tejas Nikumbh
Hi, I am Tejas Nikumbh, an undergrad at Indian Institute of Technology Bombay. I will be participating in GSoC this year. [GSoC 2013]. In order to imporve my chances for getting selected this year, I would like to start contributing early on to Open Source development via Wine. Here's a little ba

Re: [PATCH v3 0/7] Add O_DENY* support for VFS and CIFS/NFS

2013-02-28 Thread Pavel Shilovsky
2013/3/1 Andy Lutomirski : > [possible resend -- sorry] > > On 02/28/2013 07:25 AM, Pavel Shilovsky wrote: >> This patchset adds support of O_DENY* flags for Linux fs layer. These flags >> can be used by any application that needs share reservations to organize a >> file access. VFS already has s

Re: d3dx9 [patch 1/2]: Implement D3DXSHEvalConeLight

2013-02-28 Thread Nozomi Kodama
Why is this patch marked as "not applied" by the testbot? In my computer, with the latest git, it applies fine. Is there a problem with testbot? Nozomi De : Marvin À : nozomi.kod...@yahoo.com Cc : wine-devel@winehq.org Envoyé le : Jeudi 28 février 2013 18

Re: d3dx9 [patch 1/2]: Implement D3DXSHEvalConeLight

2013-02-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24560 Your paranoid android

Re: [PATCH 2/2] winmm: MCI_BREAK_HWND handling now matches Wine's 1999 MCI_DefYieldProc.

2013-02-28 Thread Alexandre Julliard
writes: > @@ -2063,9 +2063,10 @@ static DWORD MCI_Break(UINT wDevID, DWORD dwFlags, > LPMCI_BREAK_PARMS lpParms) > switch (dwFlags & (MCI_BREAK_KEY | MCI_BREAK_OFF)) { > case MCI_BREAK_KEY: > wmd->lpfnYieldProc = MCI_DefYieldProc; > - wmd->dwYieldData = lpParms->nVirtKey; >

Re: gdiplus: GdipDrawString should handle alignment in both directions same way.

2013-02-28 Thread Vincent Povirk
> How are you handling the case where format is NULL? Never mind, I see what you're doing. But since the block where you now handle the horizontal alignment is inside an if (format->vertalign != StringAlignmentNear), this will break horizontal alignment when a vertical alignment is not set.

Re: gdiplus: GdipDrawString should handle alignment in both directions same way.

2013-02-28 Thread Vincent Povirk
> -if (format) halign = format->align; > -else halign = StringAlignmentNear; > - How are you handling the case where format is NULL?

[PATCH v3 7/7] NFSD: Pass share reservations flags to VFS

2013-02-28 Thread Pavel Shilovsky
that maps them into O_DENY flags and make them visible for applications that use O_DENYMAND opens. Signed-off-by: Pavel Shilovsky --- fs/locks.c | 1 + fs/nfsd/nfs4state.c | 46 +- 2 files changed, 46 insertions(+), 1 deletion(-) diff --git

[PATCH v3 6/7] NFSv4: Add O_DENY* open flags support

2013-02-28 Thread Pavel Shilovsky
by passing these flags to NFSv4 open request. Signed-off-by: Pavel Shilovsky --- fs/nfs/nfs4xdr.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c index 26b1439..58ddc74 100644 --- a/fs/nfs/nfs4xdr.c +++ b/fs/nfs/nf

[PATCH v3 5/7] CIFS: Translate SHARING_VIOLATION to -ETXTBSY error code for SMB2

2013-02-28 Thread Pavel Shilovsky
to make it match CIFS and VFS variants. Signed-off-by: Pavel Shilovsky --- fs/cifs/smb2maperror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/smb2maperror.c b/fs/cifs/smb2maperror.c index 494c912..11e589e 100644 --- a/fs/cifs/smb2maperror.c +++ b/fs/cifs/smb2maper

[PATCH v3 4/7] CIFS: Use NT_CREATE_ANDX command for forcemand mounts

2013-02-28 Thread Pavel Shilovsky
forcemand mount option now lets us use Windows mandatory style of byte-range locks even if server supports posix ones - switches on Windows locking mechanism. Share flags is another locking mehanism provided by Windows semantic that can be used by NT_CREATE_ANDX command. This patch combines all Win

[PATCH v3 3/7] CIFS: Add O_DENY* open flags support

2013-02-28 Thread Pavel Shilovsky
Make CIFSSMBOpen take share_flags as a parm that allows us to pass new O_DENY* flags to the server. Signed-off-by: Pavel Shilovsky --- fs/cifs/cifsacl.c | 6 -- fs/cifs/cifsglob.h | 12 +++- fs/cifs/cifsproto.h | 9 + fs/cifs/cifssmb.c | 47 +---

[PATCH v3 2/7] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-28 Thread Pavel Shilovsky
If O_DENYMAND flag is specified, O_DENYREAD/WRITE/MAND flags are translated to flock's flags: !O_DENYREAD -> LOCK_READ !O_DENYWRITE -> LOCK_WRITE O_DENYMAND -> LOCK_MAND and set through flock_lock_file on a file. This change affects opens that use O_DENYMAND flag - all other native Linux open

[PATCH v3 1/7] fcntl: Introduce new O_DENY* open flags

2013-02-28 Thread Pavel Shilovsky
This patch adds 4 flags: 1) O_DENYREAD that doesn't permit read access, 2) O_DENYWRITE that doesn't permit write access, 3) O_DENYDELETE that doesn't permit delete or rename, 4) O_DENYMAND that enables O_DENY* flags checks. Network filesystems CIFS, SMB2.0, SMB3.0 and NFSv4 have such flags - this

[PATCH v3 0/7] Add O_DENY* support for VFS and CIFS/NFS

2013-02-28 Thread Pavel Shilovsky
This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This

Re: ieframe: Fixed QI tests on IE10, where IStdMarshalInfo is supported by WebBrowser object.

2013-02-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24550 Your paranoid android