Re: [1/3] wininet: Remember that headers were not received.

2013-02-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24535 Your paranoid android

Re: d3dx9: Avoid expensive computations

2013-02-26 Thread Rico Schüller
Hi Nozomi, this is pretty fast. Just some numbers (run time on my machine, so it might not be that representative)... before: 43s previous patch: 27s this patch: 21s native: 16s So from the speed point of view, it's a lot closer than the rest. Though, I would split this into 2 patches, one f

Re: gdi32: Fix the GdiGetCodePage() support ANSI_CHARSET font associated charset

2013-02-26 Thread Akihiro Sagawa
On Tue, 26 Feb 2013 10:42:14 +0900, Byeongsik Jeon wrote: > > This condition should be rewritten. buf is not initialized when > > RegQueryValueExA is failed in line 3542. And strcmp(buf, cpbuf) has > > already done in line 3544. > > > I wanted to update in registry when codepages changed, not logp

Re: riched20: Remove redundant 'return;' statements.

2013-02-26 Thread Alexandre Julliard
Dmitry Timoshkov writes: > This patch is marked as 'Rejected', and I can't find an e-mail to wine-devel > with an explanation why. It's a matter of taste, so you can't change other people's code. -- Alexandre Julliard julli...@winehq.org

Re: d3dx9: Avoid expensive computations

2013-02-26 Thread David Laight
On Mon, Feb 25, 2013 at 11:08:02AM +0100, Henri Verbeet wrote: > On 25 February 2013 10:24, Rico Sch?ller wrote: > > I did some small tests for speed with the following results. You may also > > avoid such a lot of variable assignments like *pout = out and you may use 4 > > vecs instead. This shou