Re: advapi32: Report administrator ownership by default for registry objects (try 3).

2013-02-19 Thread Alexandre Julliard
"Erich E. Hoover" writes: > The attached patch fixes an issue where the Opera installer expects > registry keys to return ownership information (Bug #32904), concluding > the cleanup of [Get|Set]NamedSecurityInfo. This patch addresses the > issue by ensuring that NULL owner and group information

Re: [14/14] gdiplus: Reimplement GdipDrawPath.

2013-02-19 Thread Vincent Povirk
> Well, GdipWidenPath is actually good enough for the things I've tested > so far, so it's basically working. What are the possible problems with > it you are aware of? It doesn't implement dashed lines and most line cap styles. I think it also mishandles pen->width == 0. It doesn't have to be pe

Re: [14/14] gdiplus: Reimplement GdipDrawPath.

2013-02-19 Thread Dmitry Timoshkov
Vincent Povirk wrote: > > Please don't apply this [14/14] patch, it causes a test failure. I'm sending > > it to show how this is going to look like eventually. > > Yeah, GdipWidenPath isn't good enough for this yet. But I agree this > is the way to go, and the rest of the series looks good. We

Re: [14/14] gdiplus: Reimplement GdipDrawPath.

2013-02-19 Thread Vincent Povirk
> Please don't apply this [14/14] patch, it causes a test failure. I'm sending > it to show how this is going to look like eventually. Yeah, GdipWidenPath isn't good enough for this yet. But I agree this is the way to go, and the rest of the series looks good.

Re: [PATCH 5/8] vbscript: Added RegExp.Execute tests

2013-02-19 Thread Piotr Caban
On 02/19/13 12:47, Marvin wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.

Re: [PATCH 7/8] vbscript: Added tests for invalid parameters in regular expression functions

2013-02-19 Thread Piotr Caban
On 02/19/13 12:48, Marvin wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.

Re: [PATCH 7/8] vbscript: Added tests for invalid parameters in regular expression functions

2013-02-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24455 Your paranoid android

Re: [PATCH 5/8] vbscript: Added RegExp.Execute tests

2013-02-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24454 Your paranoid android

Re: [PATCH 5/8] vbscript: Added RegExp.Execute tests

2013-02-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24454 Your paranoid android