Re: IE 6 related urlmon:protocol failures

2013-02-18 Thread Francois Gouget
On Mon, 18 Feb 2013, Jacek Caban wrote: [...] > > wininet:http has the exact same problem. > > http://wiki.winehq.org/WineTestBotVMs#wininet > > > It seems to me like those tests could be simply removed. The part that > is failing is just a preparation for tests reading from cache. I'm not parti

Re: Failing tests in the Japanese and Hebrew languages

2013-02-18 Thread Francois Gouget
On Mon, 18 Feb 2013, Akihiro Sagawa wrote: > Did you change ANSI codepage? As you may know, Japanese (codepage > 932) is not compatible with Windows 1252 except for 7-bit ASCII > characters. So you have to change codepage settings, Language for > Non-Unicode Programs, in the Control Panel. Not sp

Re: [PATCH 1/2] wininet: Address string should never be converted to UNICODE in status notifications

2013-02-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24441 Your paranoid android

Re: [PATCH 1/2] wininet: Address string should never be converted to UNICODE in status notifications

2013-02-18 Thread Jacek Caban
On 02/18/13 15:50, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/

Re: IE 6 related urlmon:protocol failures

2013-02-18 Thread Jacek Caban
On 02/18/13 12:49, Francois Gouget wrote: > On Sat, 16 Feb 2013, Jacek Caban wrote: > >> On 2/16/13 1:28 AM, Francois Gouget wrote: >>> However I think the test should still not fail. So I'm looking for a >>> volunteer to either get the test to succeed with urlmon 6.0, or find a >>> way to detect i

Re: Failing tests in the Japanese and Hebrew languages

2013-02-18 Thread Akihiro Sagawa
Did you change ANSI codepage? As you may know, Japanese (codepage 932) is not compatible with Windows 1252 except for 7-bit ASCII characters. So you have to change codepage settings, Language for Non-Unicode Programs, in the Control Panel. Most of wine test try to run ANSI version of APIs. Languag

Re: msi: Don't ignore failure to remove an existing product.

2013-02-18 Thread Alexandre Julliard
Hans Leidekker writes: > --- > dlls/msi/action.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) It fails here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c && touch action.ok action.c:6397: Test failed: Expected ERROR_SUCCESS, got 2 acti

Re: IE 6 related urlmon:protocol failures

2013-02-18 Thread Francois Gouget
On Sat, 16 Feb 2013, Jacek Caban wrote: > On 2/16/13 1:28 AM, Francois Gouget wrote: > > However I think the test should still not fail. So I'm looking for a > > volunteer to either get the test to succeed with urlmon 6.0, or find a > > way to detect it and skip these three tests. > > I believe i

winmm: More compatible waveIn/Out[Un]Prepare WHDR_* flag handling.

2013-02-18 Thread Joerg-Cyril.Hoehle
Hi, One thing to note is a slight change when Prepare is called twice in a row. When the ACM is used, the former Wine code would prepare the ACM again, leaking the memory of the previous preparation. Now that code is by-passed as the header is prepared exactly once, the first time. What if the

Re: Failing tests in the Japanese and Hebrew languages

2013-02-18 Thread Yaron Shahrabani
On Mon, Feb 18, 2013 at 12:48 PM, Francois Gouget wrote: > On Sun, 17 Feb 2013, Yaron Shahrabani wrote: > > > Looks like both encoding and RTL checks. > > Did you mean that for a specific test? > No I was talking about all the Hebrew test in general. > > > > I think the translation is non-UTF-8

Re: Failing tests in the Japanese and Hebrew languages

2013-02-18 Thread Francois Gouget
On Sun, 17 Feb 2013, Yaron Shahrabani wrote: > Looks like both encoding and RTL checks. Did you mean that for a specific test? > I think the translation is non-UTF-8 (At least it was like that when I was > working with .rc files). > > Nowadays I believe that the PO should be UTF-8 so it should

Re: [PATCH 1/2] wined3d: Make (wined3d_)surface_depth_blt_fbo handle locations other than SFLAG_INTEXTURE.

2013-02-18 Thread Henri Verbeet
On 18 February 2013 01:24, Matteo Bruni wrote: > to date already. You're right that it doesn't make sense to call > surface_load_ds_location() (in its current form, anyway) at all here, > so what about this instead? Yeah, I think that makes more sense.