Re: [3/4] gdi32: IntersectClipRect should update actual clipping region for a EMF DC.

2013-02-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24396 Your paranoid android

Re: [2/4] gdi32: OffsetClipRgn should update actual clipping region for a EMF DC.

2013-02-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24395 Your paranoid android

Re: [1/4] gdi32: Add more EMF clipping tests.

2013-02-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24394 Your paranoid android

winealsa: Have the MIDI recorder wait in poll(), not snd_seq_event_input().

2013-02-13 Thread Joerg-Cyril.Hoehle
Johannes Kroll wrote: >It is in the log line that you deleted. Oops. >No, I don't have wineOSS. Does it require a proper OSSv4? Currently, yes. You'd have to try out wine-1.3.24 or older. I'll try and see how to use virtual MIDI devices to dump data without using a serial port. Anyway, I'll star

Re: [PATCH] dsound: copy program parameters in SetFormat

2013-02-13 Thread Andrew Eikum
On Mon, Feb 11, 2013 at 02:06:42PM +0100, Maarten Lankhorst wrote: > Fixes bug #32312, apparently some programs depend on the format it specifies > being returned. > > Just set wBitsPerSample, nSamplesPerSec and nChannels to make those > applications happy. > The patch seems fine, but can you

Re: winmm: More compatible waveIn/Out[Un]Prepare WHDR_* flag handling.

2013-02-13 Thread Andrew Eikum
These two patches look fine to me. Thanks! On Mon, Feb 11, 2013 at 01:28:09PM +0100, joerg-cyril.hoe...@t-systems.com wrote: > Hi, > > This completes my winmm Prepare Header changes on the wave side. > > XyzPrepare: > +header->dwFlags &= ~(WHDR_DONE|WHDR_INQUEUE); /* flags cleared since w2k

Re: kernel32: Indicate that HeapValidate called by GlobalHandle is not the sign of heap corruption.

2013-02-13 Thread Alexandre Julliard
Dmitry Timoshkov writes: > This helps to distinguish this one from real signs of heap corruption, > and saves quite a bit of effort analysing +heap or warn+heap logs. Avoiding HeapValidate would probably be a better approach. -- Alexandre Julliard julli...@winehq.org

Re: advapi32: Report world-access ownership by default for registry objects (try 2).

2013-02-13 Thread Alexandre Julliard
"Erich E. Hoover" writes: > The attached patch fixes an issue where the Opera installer expects > registry keys to return ownership information (Bug #32904), concluding > the cleanup of [Get|Set]NamedSecurityInfo. This patch addresses the > issue by ensuring that NULL owner and group information

Re: [PATCH] netstat: Clarify labels in UDP statistics.

2013-02-13 Thread Lauri Kenttä
On 2013-02-13 11:03, Frédéric Delanoy wrote: On Tue, Feb 12, 2013 at 7:56 PM, Lauri Kenttä wrote: On 2013-02-09 23:15, Frédéric Delanoy wrote: "Invalid Datagrams" is too vague. It could mean datagrams sent or received. I think it's pretty obvious. Nobody should send invalid datagrams anywa

Re: msi/tests: Move a couple of tests from install.c to msi.c.

2013-02-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24381 Your paranoid android

Re: winealsa: Have the MIDI recorder wait in poll(), not snd_seq_event_input().

2013-02-13 Thread Johannes Kroll
On Wed, 13 Feb 2013 09:29:19 +0100 wrote: > Hi, > > Johannes Kroll wrote: > > 9.532:003a:trace:midi:modLongData dwBufferLength=88 ! > f0 42 41 00 01 11 01 7f 4b 40 7a 01 7f 02 7f 7f .BA.K@z. > 7f 7f 71 7f 40 01 7f 7f 7f 7f 03 7f 7f 01 01 00 ..q.@... > 00 7f 06 02 7f 7f 01 40 0

Re: gdi32: Make sure that actual clipping region is updated for a EMF DC.

2013-02-13 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > >> > This patch not only fixes a todo_wine in the tests, but also makes print > >> > preview and printing work in a pretty large application. > >> > >> You would most likely have to do that for all the clipping functions then. > > > > Do you prefer a separate patch or

Re: gdi32: Make sure that actual clipping region is updated for a EMF DC.

2013-02-13 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> > This patch not only fixes a todo_wine in the tests, but also makes print >> > preview and printing work in a pretty large application. >> >> You would most likely have to do that for all the clipping functions then. > > Do you prefer a

Re: gdi32: Make sure that actual clipping region is updated for a EMF DC.

2013-02-13 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > This patch not only fixes a todo_wine in the tests, but also makes print > > preview and printing work in a pretty large application. > > You would most likely have to do that for all the clipping functions then. Do you prefer a separate patch or resend this one?

Re: gdi32: Make sure that actual clipping region is updated for a EMF DC.

2013-02-13 Thread Alexandre Julliard
Dmitry Timoshkov writes: > This patch not only fixes a todo_wine in the tests, but also makes print > preview and printing work in a pretty large application. You would most likely have to do that for all the clipping functions then. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH] netstat: Clarify labels in UDP statistics.

2013-02-13 Thread Frédéric Delanoy
On Tue, Feb 12, 2013 at 7:56 PM, Lauri Kenttä wrote: > On 2013-02-09 23:15, Frédéric Delanoy wrote: >> >> "Invalid Datagrams" is too vague. It could mean datagrams sent or >> received. > > I think it's pretty obvious. Nobody should send invalid datagrams anyway, > especially not using any actual d

winealsa: Have the MIDI recorder wait in poll(), not snd_seq_event_input().

2013-02-13 Thread Joerg-Cyril.Hoehle
Hi, Johannes Kroll wrote: 9.532:003a:trace:midi:modLongData dwBufferLength=88 ! f0 42 41 00 01 11 01 7f 4b 40 7a 01 7f 02 7f 7f .BA.K@z. 7f 7f 71 7f 40 01 7f 7f 7f 7f 03 7f 7f 01 01 00 ..q.@... 00 7f 06 02 7f 7f 01 40 00 00 7c 7f 00 7f 7f 7f ...@..|. 7f 7f 7f 7f 7f 7f 7f