Re: winspool.drv: There is no need to speculate about wineps.drv default DEVMODE.

2013-02-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24350 Your paranoid android

Re: make_xftmpl: Explicitly use signed char when appropriate

2013-02-11 Thread Alexandre Julliard
André Hentschel writes: > For platforms where char is expected to be unsigned (e.g. it fixes a warning > on ARM) There's no reason to make it signed. Please fix the bug correctly instead. -- Alexandre Julliard julli...@winehq.org

winealsa: Have the MIDI recorder wait in poll(), not snd_seq_event_input().

2013-02-11 Thread Joerg-Cyril.Hoehle
Johannes Kroll asked: >Did this patch get through? I don't see it on >http://source.winehq.org/patches/ ... It did. You looked too late in patches/. Committed patches are deleted sooner than rejected ones that are in turn deleted sooner than new/pending patches. I'm still interested in your testi

Re: windowscodecsext: Implement WICCreateColorTransform_Proxy and IWICColorTransform_Initialize_Proxy.

2013-02-11 Thread Vincent Povirk
OK, I'm about to say something weird, and I'll understand if everyone else decides to ignore it. I don't think WICCreateColorTransform_Proxy, or any of the Proxy functions, should initialize or make use of COM. Instead, I think it should work by calling WICCreateImagingFactory_Proxy. I suspect t

Re: winealsa: Have the MIDI recorder wait in poll(), not snd_seq_event_input().

2013-02-11 Thread Johannes Kroll
On Thu, 24 Jan 2013 10:33:58 +0100 wrote: > Compare with wineoss which uses poll <= 0 already... > > Johannes Kroll mentioned that MIDIIn takes a long time to end. > Indeed, our testsuite ran 3 times into the "kill after 5s" timeout due to > this bug. > Now the tests execute much faster. > > R

Re: windowscodecsext: Implement WICCreateColorTransform_Proxy and IWICColorTransform_Initialize_Proxy.

2013-02-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24341 Your paranoid android

Re: winspool.drv: Fallback to cupsGetPPD if cupsGetPPD3 is missing or failed.

2013-02-11 Thread Huw Davies
On Mon, Feb 11, 2013 at 06:12:57PM +0800, Dmitry Timoshkov wrote: > Huw Davies wrote: > > Under what conditions does cupsGetPPD succeed if cupsGetPPD3 fails? > > I don't have full understanding of what is going on, but sometimes (!) > cupsGetPPD3 returns 404, while cupsGetPPD works just fine here

Re: winspool.drv: Fallback to cupsGetPPD if cupsGetPPD3 is missing or failed.

2013-02-11 Thread Dmitry Timoshkov
Huw Davies wrote: > On Mon, Feb 11, 2013 at 02:03:26PM +0800, Dmitry Timoshkov wrote: > > -if (pcupsGetPPD3) return pcupsGetPPD3( http, name, modtime, buffer, > > bufsize ); > > +if (pcupsGetPPD3) > > +{ > > +http_status_t status; > > + > > +TRACE( "Calling cupsGetPPD

Re: winspool.drv: Fallback to cupsGetPPD if cupsGetPPD3 is missing or failed.

2013-02-11 Thread Huw Davies
On Mon, Feb 11, 2013 at 02:03:26PM +0800, Dmitry Timoshkov wrote: > -if (pcupsGetPPD3) return pcupsGetPPD3( http, name, modtime, buffer, > bufsize ); > +if (pcupsGetPPD3) > +{ > +http_status_t status; > + > +TRACE( "Calling cupsGetPPD3\n" ); > +status = pcupsGet