Re: Re: [PATCH 1/2] shell32: Add a basic implementation for SHGetStockIconInfo

2013-02-08 Thread Henri Verbeet
On 8 February 2013 11:11, Detlef Riekenberg wrote: > I prefer typedef to reduce a bit of typing. > Typedefs aren't meant to be a tool for obfuscation. (Though if you're into that, there are some interesting things you can make the preprocessor do as well.)

Re: [PATCH] Support a protection scheme which reset the GS selector - v2

2013-02-08 Thread Sergey Guralnik
On 2013-02-07 17:00, Alessandro Pignotti wrote: +opcode=(unsigned char*)context->Eip; +if (*opcode==0x65 && /* GS segment instruction prefix */ +context->SegGs!=ntdll_get_thread_data()->gs) Segment-override prefix may be preceded by repeat or operand-size override prefixes. So

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-08 Thread J. Bruce Fields
On Thu, Feb 07, 2013 at 08:50:16PM +0400, Pavel Shilovsky wrote: > 2013/2/7 J. Bruce Fields : > > That would be a bug, I think. E.g. "man 3posix open": > > > > No files shall be created or modified if the function returns > > -1. > > > > Looking at the code... See the reference

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-08 Thread J. Bruce Fields
On Thu, Feb 07, 2013 at 08:00:13PM +0400, Pavel Shilovsky wrote: > 2013/2/7 J. Bruce Fields : > > On Thu, Feb 07, 2013 at 06:32:38PM +0400, Pavel Shilovsky wrote: > >> 2013/2/7 J. Bruce Fields : > >> > On Thu, Feb 07, 2013 at 01:53:46PM +0400, Pavel Shilovsky wrote: > >> >> Nothing prevents it. If

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-08 Thread J. Bruce Fields
On Thu, Feb 07, 2013 at 01:53:46PM +0400, Pavel Shilovsky wrote: > 2013/2/5 J. Bruce Fields : > > On Tue, Feb 05, 2013 at 03:45:31PM +0400, Pavel Shilovsky wrote: > >> 2013/1/31 J. Bruce Fields : > >> > On Thu, Jan 17, 2013 at 08:52:59PM +0400, Pavel Shilovsky wrote: > >> >> If O_DENYMAND flag is s

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-08 Thread J. Bruce Fields
On Thu, Feb 07, 2013 at 06:32:38PM +0400, Pavel Shilovsky wrote: > 2013/2/7 J. Bruce Fields : > > On Thu, Feb 07, 2013 at 01:53:46PM +0400, Pavel Shilovsky wrote: > >> Nothing prevents it. If somebody grabbed a share mode lock on a file > >> before we call deny_lock_file, we simply close this file

Aw: Re: [PATCH 1/2] shell32: Add a basic implementation for SHGetStockIconInfo

2013-02-08 Thread Detlef Riekenberg
Dimitry wrote: >> +/ >> + * helper for SHGetStockIconInfo >> + */ >> +typedef struct stockiconentry_t { >> + SHSTOCKICONID id; >> + DWORD iconid; >> +} stockiconentry; >Why bother with a typedef? I prefer typedef to red

Re: [PATCH] winebuild: Use $CCAS to assemble if found

2013-02-08 Thread Alexandre Julliard
Charles Davis writes: >> But it's probably better to avoid this penalty altogether. For example, >> by checking in configure whether CCAS is Clang or GAS, and defining an >> appropriate flag. > Go for it. Can't speak for AJ though; he has the final word on anything that > goes in. Like I alread