Re: [PATCH v2 0/8] Add O_DENY* support for VFS and CIFS/NFS

2013-02-05 Thread J. Bruce Fields
On Tue, Feb 05, 2013 at 03:33:21PM +0400, Pavel Shilovsky wrote: > 2013/1/31 J. Bruce Fields : > > On Thu, Jan 17, 2013 at 08:52:09PM +0400, Pavel Shilovsky wrote: > >> This patchset adds support of O_DENY* flags for Linux fs layer. These > >> flags can be used by any application that needs share

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-05 Thread J. Bruce Fields
On Tue, Feb 05, 2013 at 03:45:31PM +0400, Pavel Shilovsky wrote: > 2013/1/31 J. Bruce Fields : > > On Thu, Jan 17, 2013 at 08:52:59PM +0400, Pavel Shilovsky wrote: > >> If O_DENYMAND flag is specified, O_DENYREAD/WRITE/MAND flags are > >> translated to flock's flags: > >> > >> !O_DENYREAD -> LOCK_

Re: [2/5] windowscodecs: Basic tests for tiff encoder options (try2)

2013-02-05 Thread Vincent Povirk
> @Vincent: I thought about adding the properties one at a time but it seemed > a bit like overkill for the tiff encoder, which has only two options. But I > will defenitly do this for the jpeg encoder, which has much more options. Well, actually, on further consideration I can understand why you

Re: [2/5] windowscodecs: Basic tests for tiff encoder options

2013-02-05 Thread Vincent Povirk
+{ wszTiffCompressionMethod, VT_UI1, VT_UI1, {.iVal=WICTiffCompressionDontCare} }, This .field=value initialization syntax is not acceptable for Wine (not in C89). I don't know another way to initialize unions. +if (clsid_encoder == &CLSID_WICTiffEncoder) +todo_wine test_s

Re: [PATCH v2 4/8] CIFS: Add O_DENY* open flags support

2013-02-05 Thread Pavel Shilovsky
2013/1/31 J. Bruce Fields : > On Thu, Jan 17, 2013 at 08:53:00PM +0400, Pavel Shilovsky wrote: >> Make CIFSSMBOpen take share_flags as a parm that allows us >> to pass new O_DENY* flags to the server. >> >> Signed-off-by: Pavel Shilovsky >> --- >> fs/cifs/cifsacl.c | 10 ++ >> fs/cifs/c

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-05 Thread Pavel Shilovsky
2013/1/31 J. Bruce Fields : > On Thu, Jan 17, 2013 at 08:52:59PM +0400, Pavel Shilovsky wrote: >> If O_DENYMAND flag is specified, O_DENYREAD/WRITE/MAND flags are >> translated to flock's flags: >> >> !O_DENYREAD -> LOCK_READ >> !O_DENYWRITE -> LOCK_WRITE >> O_DENYMAND -> LOCK_MAND >> >> and set

Re: [PATCH v2 0/8] Add O_DENY* support for VFS and CIFS/NFS

2013-02-05 Thread Pavel Shilovsky
2013/1/31 J. Bruce Fields : > On Thu, Jan 17, 2013 at 08:52:09PM +0400, Pavel Shilovsky wrote: >> This patchset adds support of O_DENY* flags for Linux fs layer. These flags >> can be used by any application that needs share reservations to organize a >> file access. VFS already has some sort of