Re: [2/6] windowscodecs: Implement ComponentFactory::CreateEncoderPropertyBag

2013-01-29 Thread Alexandre Julliard
Ludger Sprenker writes: > Previous "[2/5]" should have been "[3/6]" ... It doesn't build on Mac: gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DENTRY_PREFIX=WIC_ -DPROXY_DELEGATION -DWINE_REGISTER_DLL -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-afte

Re: gdiplus: Avoid not necessary memory allocation for BITMAPINFO.

2013-01-29 Thread Vincent Povirk
Did you try running the tests in valgrind with this change? You're essentially reverting 0ecd8daa16e4aa3df157a1175c611cdffc66d6fe which I think was done to make valgrind happy.

Re: kernel32: dstlen < 0 causes error in codepage conversion

2013-01-29 Thread Alexandre Julliard
Alex Henrie writes: > This is a pretty straightforward patch to resolve a couple of test > failures marked todo_wine. Hopefully it's not controversial, but if it > is, I am willing to make any reasonable modifications that are > communicated to me. If it was that easy it would have been done alr

Re: winealsa: Have the MIDI recorder wait in poll(), not snd_seq_event_input().

2013-01-29 Thread Johannes Kroll
On Thu, 24 Jan 2013 10:33:58 +0100 wrote: > Compare with wineoss which uses poll <= 0 already... > > Johannes Kroll mentioned that MIDIIn takes a long time to end. > Indeed, our testsuite ran 3 times into the "kill after 5s" timeout due to > this bug. > Now the tests execute much faster. Just

Re: riched20: ME_StrDup() is no longer used so remove it.

2013-01-29 Thread Huw Davies
On Tue, Jan 29, 2013 at 07:05:13AM +0100, Francois Gouget wrote: > --- > dlls/riched20/editor.h |1 - > dlls/riched20/string.c |5 - > 2 files changed, 6 deletions(-) I'm about to send in a patch that uses this again, so please hold off on this one. Huw.

Re: winemenubuilder: Try to wait for creating icon files (try 2).

2013-01-29 Thread Sergey Guralnik
On 2013-01-23 16:34, Sergey Guralnik wrote: It supersedes next patch: From 4ca51cf16c5be2bcf34dddb7f33fe043c1d777c4 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik Date: Tue, 22 Jan 2013 15:58:20 +0200 Subject: winemenubuilder: Use only existing file for icon creating. The logic is the same a