Re: [PATCH] gdi32: Adjust a fixed-pitch full-width character has double advance of a half-width character. (try 5)

2013-01-25 Thread Akihiro Sagawa
On Fri, 25 Jan 2013 12:07:14 +0100, Alexandre Julliard wrote: > This is still failing here: ... > font.c:3756: Test failed: expected 19, got 0 (@IPAGothic:128) > make[1]: *** [font.ok] Error 1 Could you let me know IPAGothic font file's version or MD5 value? I guess this caused by font file (*.ttf

Why 0.1.0.0 as local socket address instead of 127.0.0.1?

2013-01-25 Thread Francois Gouget
The ws2_32:sock fails on some of my machines with the following error: sock.c:4794: Test failed: Local socket address is different 0.1.0.0 != 127.0.0.1 Does anyone know why we GetAcceptExSockaddrs() would return 0.1.0.0 instead of 127.0.0.1? Looking at the Windows 7 winetest results it does no

Re: [PATCH] winebuild: Use Clang to assemble if found. (try 4)

2013-01-25 Thread Alexandre Julliard
Charles Davis writes: > @@ -346,13 +352,26 @@ struct strarray *get_as_command(void) > struct strarray *args = strarray_init(); > > if (!as_command) > +as_command = find_tool( "clang", NULL ); > + > +if (!as_command) > { > static const char * const commands[]

Re: [PATCH 2/2] jscript: Fixed a leak in regexp_match function

2013-01-25 Thread Piotr Caban
On 01/25/13 16:30, Marcus Meissner wrote: On Fri, Jan 25, 2013 at 04:26:59PM +0100, Piotr Caban wrote: @@ -3466,10 +3466,15 @@ static HRESULT regexp_match(script_ctx_t *ctx, jsdisp_t *dispex, jsstr_t *str, B break; if(ret_size == i) { -if(ret) -

Re: [PATCH 2/2] jscript: Fixed a leak in regexp_match function

2013-01-25 Thread Marcus Meissner
On Fri, Jan 25, 2013 at 04:26:59PM +0100, Piotr Caban wrote: > --- > dlls/jscript/regexp.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > > diff --git a/dlls/jscript/regexp.c b/dlls/jscript/regexp.c > index 0d66551..fa2668c 100644 > --- a/dlls/jscript/regexp.c > +++ b/d

Re: [PATCH] gdi32: Adjust a fixed-pitch full-width character has double advance of a half-width character. (try 5)

2013-01-25 Thread Alexandre Julliard
Akihiro Sagawa writes: > Hi, > > This patch enhances full-width character glyph advance when we choose > fixed-pitch font. > > Windows 2000 (or XP for Japanese) and later adjust fixed-pitch > full-width character glyph advances so that two half-width characters' > advance equals to one full-width

Re: [1/5] comctl32/tests: more tests for icon spacing calculation

2013-01-25 Thread Nikolay Sivov
On 1/25/2013 12:47, Daniel Jelinski wrote: Hello, Thanks for reviewing. What's the preferred way of checking whether the code is compiled for 32 or 64bit? Regards, Daniel Check for pointer size. 2013/1/24 Alexandre Julliard : Daniel Jelinski writes: +#ifdef _WIN64 +/* NOTE: -1 is not t

Re: [1/5] comctl32/tests: more tests for icon spacing calculation

2013-01-25 Thread Daniel Jelinski
Hello, Thanks for reviewing. What's the preferred way of checking whether the code is compiled for 32 or 64bit? Regards, Daniel 2013/1/24 Alexandre Julliard : > Daniel Jelinski writes: > >> +#ifdef _WIN64 >> +/* NOTE: -1 is not treated the same as (DWORD)-1 by 64bit listview */ >> +ret =