Re: Wine Wiki needs your help!

On Wed, Jan 16, 2013 at 12:19 AM, Juan Lang wrote: > Could the password hashes be excluded from the regular tarball? E.g. using > --exclude in the tar command? Sorry I didn't reply sooner, been a little busy the past week. I don't have a copy of the Wine Wiki data in front of me, but if I remembe

Re: [1/6] windowscodecs: Add tests for IPropertyBag2

Other than the 6/6, this series looks good to me. Thanks for breaking this up. It makes it much easier to review.

Re: [6/6] windowscodecs: Implement IPropertyBag2::Read

+if (idx > -1) +{ +VariantInit(pvarValue+i); +res = VariantCopy(pvarValue+i, This->values+idx); +phrError[i] = res; +if (FAILED(res)) +break; +} This looks wrong to me. We have an array of error values to set f

Re: [5/6] windowscodecs: Implement IPropertyBag2::Write

if (This->properties[i].pstrName) { HeapFree(GetProcessHeap(), 0, This->properties[i].pstrName); +VariantClear( This->values+i ); /* Not initialized if pstrName not initialized */ } ... { This->properties = Heap

Re: [4/6] windowscodecs: Implement IPropertyBag2::GetPropertyInfo

+if (This->properties[i].pstrName) +{ +HeapFree(GetProcessHeap(), 0, This->properties[i].pstrName); +} HeapFree already checks for NULL, so there's no need for an if statement here.

Re: [PATCH] ieframe/tests: Don't convert to long path name until the file exists

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24128 Your paranoid android

Re: [1/5] comctl32/tests: more tests for icon spacing calculation

Daniel Jelinski writes: > +#ifdef _WIN64 > +/* NOTE: -1 is not treated the same as (DWORD)-1 by 64bit listview */ > +ret = SendMessage(hwnd, LVM_SETICONSPACING, 0, (DWORD)-1); > +todo_wine { > +expect(100, LOWORD(ret)); > +expect(0x, HIWORD(ret)); > +} > +ret = SendMessage

Re: ws2_32: Use assignment instead of memcpy to copy structs.

Forgot to add the credit for this patch series as I didn't wrote this coccinelle script: Found using the memcpy-assign.cocci script submitted for inclusion into the Linux kernel: https://systeme.lip6.fr/pipermail/cocci/2013-January/000121.html bye michael On 01/24/2013 02:21 PM, Michael S

Re: ieframe: Fixed a race in tests

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24121 Your paranoid android

Re: [PATCH 2/2] vbscript: Added GetObject tests

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24115 Your paranoid android

Please perform MIDI test with MS OS

Hi, if you can, please download the test executable from https://testbot.winehq.org/JobDetails.pl?Key=24107 and run it on a native MS machine (32 and 64 bit). Please send me the results, no need to post. I particularly welcome test results from old w9k machines! Thank you, Jörg Höhle

Re: [PATCH] kernel32: implement condition variables (try 5)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24106 Your paranoid android