Re: [PATCH 5/5] d3d*/tests: Add simple DrawRectPatch tests

2013-01-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24105 Your paranoid android

Re: [PATCH 5/5] d3d*/tests: Add simple DrawRectPatch tests

2013-01-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24104 Your paranoid android

Re: po: Update Lithuanian translation

2013-01-23 Thread Lauri Kenttä
I don't really read Lithuanian, but just in case: "No Ports" means "number of ports" or more exactly "number of datagrams which were rejected because the port in the datagram was invalid". Reference: http://msdn.microsoft.com/en-us/library/windows/desktop/aa366929%28v=vs.85%29.aspx André, any

Re: [PATCH 1/8] winhttp: Use schannel in netconn_secure_connect if OpenSSL is not available

2013-01-23 Thread Jacek Caban
On 01/22/13 20:21, Alexandre Julliard wrote: > Jacek Caban writes: > >> The following patch makes winhttp use schannel instead of OpenSSL for >> SSL (HTTPS) connections. It is made to be as minimal change as possible >> (but complete enough to replace all OpenSSL functionality) to limit the >> sco

Re: [PATCH] wined3d: Ignore clears if count = 0 and rects != NULL

2013-01-23 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-01-23 13:36, schrieb Stefan D￶singer: > I was under the assumption that we already had a test for that - > those interfaces expect both count and rectangle to be non-zero, > otherwise they return an error. > > I can't find the test right now,

Re: [PATCH] wined3d: Ignore clears if count = 0 and rects != NULL

2013-01-23 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-01-23 13:28, schrieb Henri Verbeet: > Although I don't expect a difference in behaviour, it probably > wouldn't hurt to add tests for the other ddraw versions as well > (i.e. through the viewport interface). I was under the assumption that we

Re: [PATCH] wined3d: Ignore clears if count = 0 and rects != NULL

2013-01-23 Thread Henri Verbeet
On 23 January 2013 13:14, Stefan Dösinger wrote: > dlls/d3d8/tests/visual.c | 17 + > dlls/d3d9/tests/visual.c | 16 > dlls/ddraw/tests/ddraw7.c | 36 > dlls/wined3d/device.c | 6 ++ > 4 files changed, 75 insertions(

Re: [PATCH] advapi32: Use the lower 32bit of the special HKEYs on 64bit.

2013-01-23 Thread Alexandre Julliard
Rico Schüller writes: > @@ -228,9 +228,9 @@ static NTSTATUS open_key( HKEY *retkey, ACCESS_MASK > access, OBJECT_ATTRIBUTES *a > static HKEY create_special_root_hkey( HKEY hkey, DWORD access ) > { > HKEY ret = 0; > -int idx = (UINT_PTR)hkey - (UINT_PTR)HKEY_SPECIAL_ROOT_FIRST; > +

Re: [PATCH] advapi32: Use the lower 32bit of the special HKEYs on 64bit.

2013-01-23 Thread Rico Schüller
Hi, please don't apply this one, I somehow garbled the rebase ... Cheers Rico On 23.01.2013 12:24, Rico Schüller wrote: --- dlls/advapi32/registry.c | 18 +++--- dlls/advapi32/tests/registry.c | 54 -- 2 files changed, 61 insertions

Re: [1/2] wineps.drv: Implement GetGlyphIndices.

2013-01-23 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> >> >> ExtTextOutW calls GetTextExtentExPointI for the (char_extra || >> >> >> dc->breakExtra) >> >> >> case, and one of its helpers unconditionally calls dc->GetGlyphIndices >> >> >> and >> >> >> dc->GetTextExtentExPointI which crashes

Re: [1/2] wineps.drv: Implement GetGlyphIndices.

2013-01-23 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > >> >> ExtTextOutW calls GetTextExtentExPointI for the (char_extra || > >> >> dc->breakExtra) > >> >> case, and one of its helpers unconditionally calls dc->GetGlyphIndices > >> >> and > >> >> dc->GetTextExtentExPointI which crashes for a wineps.drv device. > >> >> >

Re: [1/2] wineps.drv: Implement GetGlyphIndices.

2013-01-23 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> >> ExtTextOutW calls GetTextExtentExPointI for the (char_extra || >> >> dc->breakExtra) >> >> case, and one of its helpers unconditionally calls dc->GetGlyphIndices and >> >> dc->GetTextExtentExPointI which crashes for a wineps.drv devic

Re: [1/2] wineps.drv: Implement GetGlyphIndices.

2013-01-23 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Dmitry Timoshkov wrote: > >> ExtTextOutW calls GetTextExtentExPointI for the (char_extra || >> dc->breakExtra) >> case, and one of its helpers unconditionally calls dc->GetGlyphIndices and >> dc->GetTextExtentExPointI which crashes for a wineps.drv device. >> >> Thes

Re: [1/2] wineps.drv: Implement GetGlyphIndices.

2013-01-23 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > >> ExtTextOutW calls GetTextExtentExPointI for the (char_extra || > >> dc->breakExtra) > >> case, and one of its helpers unconditionally calls dc->GetGlyphIndices and > >> dc->GetTextExtentExPointI which crashes for a wineps.drv device. > >> > >> These 2 patches make