Re: include: flesh out d3d11.idl (try 4)

2013-01-22 Thread Dmitry Timoshkov
Austin English wrote: > try 4: only include enough to add a stub for D3D11CreateDevice, You could also try to make it work for compilers that don't suppport anonymous unions. -- Dmitry.

Re: [1/2] wineps.drv: Implement GetGlyphIndices.

2013-01-22 Thread Dmitry Timoshkov
Dmitry Timoshkov wrote: > ExtTextOutW calls GetTextExtentExPointI for the (char_extra || dc->breakExtra) > case, and one of its helpers unconditionally calls dc->GetGlyphIndices and > dc->GetTextExtentExPointI which crashes for a wineps.drv device. > > These 2 patches make ExtTextOutW work in th

Re: macdrv: implement getting and setting the screen saver state, version 6

2013-01-22 Thread Ken Thomases
On Jan 22, 2013, at 5:33 PM, C.W. Betts wrote: > Yet another fix. Looks good to me. Thanks for doing this and for putting up with me. Cheers, Ken

Re: macdrv: implement getting and setting the screen saver state. if(Style)

2013-01-22 Thread Ken Thomases
On Jan 22, 2013, at 6:38 AM, wrote: > Ken Thomases wrote: >>> +if(success != kIOReturnSuccess) >> Another style nitpick: please put a space between "if" and the condition. >> That applies to the "if(count2)" above, too. > > I find this over the top. Well, I phrased it as a

Re: macdrv: implement getting and setting the screen saver state, version 5

2013-01-22 Thread Ken Thomases
On Jan 22, 2013, at 12:22 PM, C.W. Betts wrote: > This version should fix the problems you mentioned Sorry about this – I should have thought about this last time – but I think you shouldn't fall through in the SPI_SETSCREENSAVEACTIVE case. It's asking for trouble in the future, if anybody add

Re: usp10: add ShapeCharGlyphProp_Latin to properly handle invalid and zero width character properties for Latin

2013-01-22 Thread Aric Stewart
Ah, yes we are presently using the wrong glyph for control characters, which causes this test to fail. I will work on fixes. -aric On 1/22/13 1:41 PM, Alexandre Julliard wrote: > Aric Stewart writes: > >> --- >> dlls/usp10/shape.c | 33 +++-- >> 1 files change

Re: usp10: add ShapeCharGlyphProp_Latin to properly handle invalid and zero width character properties for Latin

2013-01-22 Thread Alexandre Julliard
Aric Stewart writes: > --- > dlls/usp10/shape.c | 33 +++-- > 1 files changed, 27 insertions(+), 6 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p usp10_test.exe.so usp10.c && touch usp10.ok usp10.c:1407: Test fail

Re: dbghelp: Implement rudimentary stack walk for ARM64

2013-01-22 Thread André Hentschel
Am 22.01.2013 20:26, schrieb Eric Pouech: > Le 21/01/2013 20:26, André Hentschel a écrit : >> Am 21.01.2013 10:50, schrieb Eric Pouech: +if ((frame->AddrPC.Mode == AddrModeFlat) && +(frame->AddrFrame.Mode != AddrModeFlat)) >>> this looks strange to me. >>> I guess, you

Re: dbghelp: Implement rudimentary stack walk for ARM64

2013-01-22 Thread Eric Pouech
Le 21/01/2013 20:26, André Hentschel a écrit : Am 21.01.2013 10:50, schrieb Eric Pouech: +if ((frame->AddrPC.Mode == AddrModeFlat) && +(frame->AddrFrame.Mode != AddrModeFlat)) this looks strange to me. I guess, you want to check that both mode address modes are AddrModeFlat

Re: [PATCH 1/8] winhttp: Use schannel in netconn_secure_connect if OpenSSL is not available

2013-01-22 Thread Alexandre Julliard
Jacek Caban writes: > The following patch makes winhttp use schannel instead of OpenSSL for > SSL (HTTPS) connections. It is made to be as minimal change as possible > (but complete enough to replace all OpenSSL functionality) to limit the > scope for potential regressions. Further changes and im

Re: RFC: Remove auto-scan of ALSA devices from winealsa.drv (and get repeatable behaviour)

2013-01-22 Thread Alexandre Julliard
writes: > Alexandre Julliard wrote: >>If PulseAudio can't provide good enumeration, then we can detect >>that case and handle it differently. > We don't ask PA to enumerate, we ask ALSA to enumerate. I know that. It doesn't mean we can't use a heuristic to detect broken PA enumeration. >>My us

RFC: Remove auto-scan of ALSA devices from winealsa.drv (and get repeatable behaviour)

2013-01-22 Thread Joerg-Cyril.Hoehle
Alexandre Julliard wrote: >If PulseAudio can't provide good enumeration, then we can detect >that case and handle it differently. We don't ask PA to enumerate, we ask ALSA to enumerate. Remembers me of the difficulties of enumerating /dev in Linux from user space: The problem is similar: open an

Re: RFC: Remove auto-scan of ALSA devices from winealsa.drv (and get repeatable behaviour)

2013-01-22 Thread Alexandre Julliard
writes: > Alexandre Julliard wrote: >>At least on my setup, the current code is working just fine, and offering >>the devices I expect, without any manual configuration. > Are you using PulseAudio? > I believe that *every* user with PulseAudio is bound to see the flakiness > that happened on Fra

Re: RFC: Remove auto-scan of ALSA devices from winealsa.drv (and get repeatable behaviour)

2013-01-22 Thread Francois Gouget
On Tue, 22 Jan 2013, joerg-cyril.hoe...@t-systems.com wrote: [...] > We see 3 types of results > 2x: 2 devices, no ALSA "default" device(!), one HDA-An, one HDA-HDMI > 1x: 3 devices incl. ALSA "default", all tests successful > 1x: 3 devices incl. ALSA "default", dev. 1 HDA-An yields MMSYSERR_ALLOCA

Re: [PATCH 6/8] winhttp: Added schannel-based netconn_get_cipher_strength implementation

2013-01-22 Thread Jacek Caban
On 01/22/13 17:22, Hans Leidekker wrote: > On Tue, 2013-01-22 at 16:49 +0100, Jacek Caban wrote: >> @@ -1460,6 +1460,13 @@ int netconn_get_cipher_strength( netconn_t *conn ) >> pSSL_CIPHER_get_bits( cipher, &bits ); >> return bits; >> #else >> -return 0; >> +SecPkgContext_Connect

Re: [PATCH 6/8] winhttp: Added schannel-based netconn_get_cipher_strength implementation

2013-01-22 Thread Hans Leidekker
On Tue, 2013-01-22 at 16:49 +0100, Jacek Caban wrote: > @@ -1460,6 +1460,13 @@ int netconn_get_cipher_strength( netconn_t *conn ) > pSSL_CIPHER_get_bits( cipher, &bits ); > return bits; > #else > -return 0; > +SecPkgContext_ConnectionInfo conn_info; > +SECURITY_STATUS res; >

Re: winmm/tests: Allow more margin in the test_asyncWAVE() playback check.

2013-01-22 Thread Joerg-Cyril.Hoehle
>> I suggest adding a todo_wine plus an additional >> ok(0Ok. I think this can still be narrower, 400-1000ms for instance I meant to have 2 tests ok(0

Re: RFC: Remove auto-scan of ALSA devices from winealsa.drv (and get repeatable behaviour)

2013-01-22 Thread Joerg-Cyril.Hoehle
Alexandre Julliard wrote: >At least on my setup, the current code is working just fine, and offering >the devices I expect, without any manual configuration. Are you using PulseAudio? I believe that *every* user with PulseAudio is bound to see the flakiness that happened on Francois' machine. So

Re: winmm/tests: Allow more margin in the test_asyncWAVE() playback check.

2013-01-22 Thread Francois Gouget
On Tue, 22 Jan 2013, joerg-cyril.hoe...@t-systems.com wrote: [...] > I believe you forgot to test your patch in Wine(!). The test > +ok(400 <= p2 && p2 <= 600, "%ums is not in the expected 400-600ms > range\n", p2); > should fail in every version of Wine. [...] > IIRC, the first non-null posit

Re: RFC: Remove auto-scan of ALSA devices from winealsa.drv (and get repeatable behaviour)

2013-01-22 Thread Alexandre Julliard
Andrew Eikum writes: > On Tue, Jan 22, 2013 at 11:15:59AM +0100, joerg-cyril.hoe...@t-systems.com > wrote: >> Andrew Eikum was in favour of this too and since implemented winmm >> device notification upon change. Remember the December thread: >> http://www.winehq.org/pipermail/wine-devel/2012-D

Re: RFC: Remove auto-scan of ALSA devices from winealsa.drv (and get repeatable behaviour)

2013-01-22 Thread Andrew Eikum
On Tue, Jan 22, 2013 at 11:15:59AM +0100, joerg-cyril.hoe...@t-systems.com wrote: > Andrew Eikum was in favour of this too and since implemented winmm > device notification upon change. Remember the December thread: > http://www.winehq.org/pipermail/wine-devel/2012-December/098114.html > Yeah,

Re: macdrv: implement getting and setting the screen saver state. if(Style)

2013-01-22 Thread Christian Costa
Well, 'grep "if(" * -r | wc -l' and 'grep "if (" * -r | wc -l'. :) 2013/1/22 Bruno Jesus <00cp...@gmail.com>: > Out of curiosity can you explain the shell wizardry you used to get the > stats? > > Thanks, > Bruno > > > On Tue, Jan 22, 2013 at 10:52 AM, Christian Costa > wrote: >> >> 2013/1/22 :

Re: macdrv: implement getting and setting the screen saver state. if(Style)

2013-01-22 Thread Christian Costa
2013/1/22 : > Hi, > > Ken Thomases wrote: >>> +if(success != kIOReturnSuccess) >>Another style nitpick: please put a space between "if" and the condition. >> That applies to the "if(count2)" above, too. > > I find this over the top. Where is the rule? > Andrew Eikum's mmdevap

macdrv: implement getting and setting the screen saver state. if(Style)

2013-01-22 Thread Joerg-Cyril.Hoehle
Hi, Ken Thomases wrote: >> +if(success != kIOReturnSuccess) >Another style nitpick: please put a space between "if" and the condition. > That applies to the "if(count2)" above, too. I find this over the top. Where is the rule? Andrew Eikum's mmdevapi code -- which I don't co

RFC: Remove auto-scan of ALSA devices from winealsa.drv (and get repeatable behaviour)

2013-01-22 Thread Joerg-Cyril.Hoehle
Hi, please view the winmm:wave test results from Francois Gouget's machines fg-acer64-t32 fg-acer64-wow32 fg-acer64-t64 fg-acer64-wow64 http://test.winehq.org/data/dabde6a04f6d02233bc5074a8eba613b2c4adc68/index_Linux.html#winmm:wave Is their configuration the same except for 32/64bit? We see 3 t

winmm/tests: Allow more margin in the test_asyncWAVE() playback check.

2013-01-22 Thread Joerg-Cyril.Hoehle
Francois, thank you for helping remove timing-caused flakiness from the tests. I believe you forgot to test your patch in Wine(!). The test +ok(400 <= p2 && p2 <= 600, "%ums is not in the expected 400-600ms range\n", p2); should fail in every version of Wine. Ironically, the reason is menti