Sergey Guralnik wrote:
> Subject: user32/tests: Test standard scrollbar's initialization (try 2).
If it matters the test looks good to me.
--
Dmitry.
Hi,
On Jan 21, 2013, at 6:21 PM, C.W. Betts wrote:
> This version falls through in SPI_SETSCREENSAVEACTIVE.
Sadly, you used C++ style for the fall-through comment. :-/
Also, you have some trailing whitespace and the patch no longer applies cleanly
after today's commits of mine. It should be e
Vincent Povirk wrote:
> Yes, it is possible that I wrote more code than was necessary to
> support TGA because I knew WIC better and because I thought it'd be
> cool (in theory the decoder can now be used outside the context of
> d3dx9, for instance on windows with the builtin image viewer - not
>> > TGA is the simplest format I've ever seen, CreateBitmapFromMemory is
>> > the straight way to handle it. I haven't looked at ICNS support, but
>> > probably it could be implemented using public APIs as well.
>>
>> The main reason I put the TGA decoder in WIC is that I know nothing
>> about d3d
wrote:
> there are some places in Wine where I believe atomic access to 32bit entities
> is expected by the programmer, yet I see little or no measures to ensure this.
Then it's a bug, and should be fixed by adding appropriate locking.
--
Dmitry.
Vincent Povirk wrote:
> > TGA is the simplest format I've ever seen, CreateBitmapFromMemory is
> > the straight way to handle it. I haven't looked at ICNS support, but
> > probably it could be implemented using public APIs as well.
>
> The main reason I put the TGA decoder in WIC is that I know
Perhaps a comment should be added so new people will know about it?
On Jan 21, 2013, at 4:24 AM, Alexandre Julliard wrote:
> "C.W. Betts" writes:
>
>> I noticed in my research that the X11 driver doesn't return true in
>> SystemParametersInfo when handling SPI_SETSCREENSAVEACTIVE. This patch
>>
On Mon, Jan 21, 2013 at 06:52:23PM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
> Hi,
>
> there are some places in Wine where I believe atomic access to 32bit entities
> is expected by the programmer, yet I see little or no measures to ensure this.
>
> DWORD-Alignment is essential when several
On Jan 21, 2013, at 11:50 AM, C.W. Betts wrote:
> This version gets rid of redundant comments.
According to Alexandre's comment on your X11 driver patch, you should be
returning FALSE from the "SET" case so that user32 will update the registry.
Otherwise, looking good.
-Ken
Am 21.01.2013 10:50, schrieb Eric Pouech:
>> +if ((frame->AddrPC.Mode == AddrModeFlat) &&
>> +(frame->AddrFrame.Mode != AddrModeFlat))
> this looks strange to me.
> I guess, you want to check that both mode address modes are AddrModeFlat
> A+
>
it's the same as for the other a
>> If there's really a demand for using native windowscodecs without
>> breaking d3dx9 (which already happens because of the TGA decoder), I
>> can supply a win32 build of our WIC extensions that winetricks could
>> install with it. I can't do anything about ICNS.
>
> TGA is the simplest format I'v
Charles Davis writes:
> @@ -319,26 +341,27 @@ char *find_tool( const char *name, const char * const
> *names )
> names = alt_names;
> }
>
> -while (*names)
> +/* If we have a target triple, we really need to try the list of names
> + * twice: once with the triple, and
Hi,
there are some places in Wine where I believe atomic access to 32bit entities
is expected by the programmer, yet I see little or no measures to ensure this.
DWORD-Alignment is essential when several threads can access
the same DWORD variable outside of a mutex (or within the implementation of
Vincent Povirk wrote:
> If there's really a demand for using native windowscodecs without
> breaking d3dx9 (which already happens because of the TGA decoder), I
> can supply a win32 build of our WIC extensions that winetricks could
> install with it. I can't do anything about ICNS.
TGA is the si
If there's really a demand for using native windowscodecs without
breaking d3dx9 (which already happens because of the TGA decoder), I
can supply a win32 build of our WIC extensions that winetricks could
install with it. I can't do anything about ICNS.
>> Yes, there are other ways we could do this
Vincent Povirk wrote:
> > I'd suggest to use public APIs instead of inventing "extenstions".
> > CreateBitmapFromMemory should work for this purpose if you really need
> > to do it using windowscodecs, otherwise GDI APIs may work as well.
>
> I've been of the opinion that we should have a separa
On Jan 21, 2013, at 9:31 AM, C.W. Betts wrote:
> On Jan 20, 2013, at 11:06 PM, Ken Thomases wrote:
>
>> I'm not sure it's correct that these are two different names for roughly the
>> same thing. I think the two assertion types do slightly different things.
>> "NoDisplaySleep" seeks to preve
> I'd suggest to use public APIs instead of inventing "extenstions".
> CreateBitmapFromMemory should work for this purpose if you really need
> to do it using windowscodecs, otherwise GDI APIs may work as well.
I've been of the opinion that we should have a separate dll for Wine
extensions to WIC,
On Jan 20, 2013, at 11:06 PM, Ken Thomases wrote:
> Hi,
>
> On Jan 20, 2013, at 2:00 PM, C.W. Betts wrote:
>
>> This version implements changes and advice from Ken Thomases, including
>> using kIOPMAssertionTypePreventUserIdleDisplaySleep on Lion and later. Also,
>> some comments were added.
Damjan Jovanovic writes:
> @@ -676,6 +676,22 @@ AC_CHECK_HEADERS([linux/videodev.h linux/videodev2.h
> libv4l1.h],,,
> #include
> #endif])
>
> +dnl Check for libv4l1.h
> +if test "x$with_v4l" != "xno"
> +then
> +ac_save_CPPFLAGS="$CPPFLAGS"
> +if test "$PKG_CONFIG" != "fal
"C.W. Betts" writes:
> I noticed in my research that the X11 driver doesn't return true in
> SystemParametersInfo when handling SPI_SETSCREENSAVEACTIVE. This patch
> fixes this.
That's on purpose, it also needs to update the registry entry.
--
Alexandre Julliard
julli...@winehq.org
Oupsss. I forgot to explain.
No it's not it native windowscodecs. It's a wine extension to support
DIB files used in d3dx9_36.
Everything was already in place. I just had to hook things up.
I asked to Vincent who told to do this way. At least it's what I understood.
Christian
2013/1/21 Dmitry Tim
Christian Costa wrote:
> Oupsss. I forgot to explain.
> No it's not it native windowscodecs. It's a wine extension to support
> DIB files used in d3dx9_36.
> Everything was already in place. I just had to hook things up.
> I asked to Vincent who told to do this way. At least it's what I understoo
> +if ((frame->AddrPC.Mode == AddrModeFlat) &&
> +(frame->AddrFrame.Mode != AddrModeFlat))
this looks strange to me.
I guess, you want to check that both mode address modes are AddrModeFlat
A+
--
Eric Pouech
On Sun, Jan 20, 2013 at 8:09 PM, André Hentschel wrote:
> ---
> + IDS_TCP_SEGM_RECV, "Segments Recieved"
Typo here: should be "Received"
(same issue on the 2nd patch)
Frédéric
Christian Costa wrote:
> cpp_quote("DEFINE_GUID(CLSID_WICBmpDecoder,
> 0x6b462062,0x7cbf,0x400d,0x9f,0xdb,0x81,0x3d,0xd1,0x0f,0x27,0x78);")
> +cpp_quote("DEFINE_GUID(CLSID_WICDibDecoder,
> 0x6b462062,0x7cbf,0x400d,0x9f,0xdb,0x81,0x3d,0xd1,0x0f,0x27,0x79);")
> cpp_quote("DEFINE_GUID(CLSID_WIC
26 matches
Mail list logo
