Re: macdrv: implement getting and setting the screen saver state.

2013-01-19 Thread Ken Thomases
Hi, On Jan 19, 2013, at 4:08 PM, C.W. Betts wrote: > This implements getting and setting the screen saver state on the Mac Wine > driver. Thanks for your contribution to the Mac driver. There are some issues with the patch: > +CFDictionaryRef assertsionStats = NULL; That va

Re: [3/6] windowscodecs: Implement tiff encoder options (TiffCompressionMethod and CompressionQuality)

2013-01-19 Thread Dmitry Timoshkov
Ludger Sprenker wrote: > +read_hr = IPropertyBag2_Read(pIEncoderOptions, 2, pb, NULL, v, hr); > +if (SUCCEEDED(hr)) Looks like a typo. -- Dmitry.

Re: [3/5] comctl32/listview: always use large icon size when calculating icon spacing

2013-01-19 Thread Daniel Jelinski
Looks like the testbot is still having problems... 2013/1/20 Marvin : > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can b

Re: [3/5] comctl32/listview: always use large icon size when calculating icon spacing

2013-01-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24024 Your paranoid android

Re: [4/5] comctl32/listview: do not touch icon spacing if set explicitly

2013-01-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24025 Your paranoid android

Re: [5/5] comctl32/listview: fix LVM_SETICONSPACING on 64bit machines

2013-01-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24026 Your paranoid android

Re: User driver function conventions

2013-01-19 Thread C.W. Betts
Although, looking through the X11 Driver, there is a function that does check for the screen saver activity, it's just not two functions: SystemParametersInfo. I'll see if I can't get a patch put out. Also, what would be a good way to do this? Should I split the code into a new file or put it i

Re: User driver function conventions

2013-01-19 Thread C.W. Betts
I'm sorry if my intention was not clear: I want to implement this on vanilla Wine, I just did the initial work on CodeWeaver's code. But if the functions aren't on Vanilla, I guess there's no use pushing the patch here. On Jan 19, 2013, at 1:23 PM, Charles Davis wrote: > > On Jan 19, 2013, at

Re: User driver function conventions

2013-01-19 Thread Charles Davis
On Jan 19, 2013, at 1:09 PM, C.W. Betts wrote: > I'm wondering what the user driver functions GetScreenSaveActive and > SetScreenSaveActive are supposed to do. I have an implementation against > CodeWeaver's changes to Wine and I just want to make sure that I'm making the > functions properly.

User driver function conventions

2013-01-19 Thread C.W. Betts
I'm wondering what the user driver functions GetScreenSaveActive and SetScreenSaveActive are supposed to do. I have an implementation against CodeWeaver's changes to Wine and I just want to make sure that I'm making the functions properly. First is GetScreenStateActive. Does it check for if the

Re: [1/6] windowscodecs: Implementation of IPropertyBag2

2013-01-19 Thread Vincent Povirk
You'll probably have to split this into smaller patches. +return E_FAIL; /* FIXME: Function is not atomar on error, but MSDN does not say anything about it */ I don't understand. Are you saying native leaks memory on error, and if so how do you know this? +FIXME("Appl

winetestbot back online, for now

2013-01-19 Thread Maarten Lankhorst
Hey, It looks like the vmware licensing issues are resolved, so all testbot vm's are online again. I hope the replacement testbot is coming along nicely, because winetestbot is still scheduled to go permanently offline in may. ~Maarten