Re: [PATCH v2 0/8] Add O_DENY* support for VFS and CIFS/NFS

2013-01-17 Thread Stephen Rothwell
Hi Pavel, On Thu, 17 Jan 2013 20:52:09 +0400 Pavel Shilovsky wrote: > > This patchset adds support of O_DENY* flags for Linux fs layer. These flags > can be used by any application that needs share reservations to organize a > file access. VFS already has some sort of this capability - now it's

Re: user32/tests: Test standard scrollbar's initialization (try 2).

2013-01-17 Thread Sergey Guralnik
On 2013-01-15 12:27, Sergey Guralnik wrote: I have no feedback yet. Is it not clear enough? -- Sergey

Re: [PATCH v2 0/8] Add O_DENY* support for VFS and CIFS/NFS

2013-01-17 Thread Pavel Shilovsky
2013/1/18 Stephen Rothwell : > Hi Pavel, > > On Thu, 17 Jan 2013 20:52:09 +0400 Pavel Shilovsky > wrote: >> >> This patchset adds support of O_DENY* flags for Linux fs layer. These flags >> can be used by any application that needs share reservations to organize a >> file access. VFS already ha

Re: po: Update Russian translation

2013-01-17 Thread Dmitry Timoshkov
Nikolay Sivov wrote: > #: jscript.rc:40 > msgid "Can't have 'break' outside of loop" > -msgstr "Выражение 'break' не может находится вне цикла" > +msgstr "Оператор 'break' не может находится вне цикла" > > #: jscript.rc:41 > msgid "Can't have 'continue' outside of loop" > -msgstr "Выражение

Re: qcap: Fix compilation on older systems.

2013-01-17 Thread Francois Gouget
On Tue, 15 Jan 2013, Damjan Jovanovic wrote: > What does this patch do? libv4l1.h includes libv4l1-videodev.h which > is a copy of linux/videodev.h. You should only need the one or the > other. Are you saying there is a system where libv4l1.h is present but > incomplete, and you need to include li

Re: ws2_32/tests: Add SO_ERROR [set|get]sockopt tests

2013-01-17 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23986 Your paranoid android

Re: [PATCH 1/3] kernel32/path : use code from copyfileW to implement copyfileexW

2013-01-17 Thread Alexandre Julliard
Patrick Rudolph writes: > From 6ff3329003b6b9001ad608f802f235f5433b1c5d Mon Sep 17 00:00:00 2001 > From: Patrick Rudolph > Date: Fri, 11 Jan 2013 15:55:32 +0100 > Subject: a > > --- > dlls/kernel32/path.c | 91 > +++--- > 1 file changed, 86 inserti

Re: kernel32/tests : added tests for copyfileex try4

2013-01-17 Thread Alexandre Julliard
Patrick Rudolph writes: > +if(!GetTempPathA( MAX_PATH,tmppath )) > +{ > +win_skip("GetTempPathA failed\n"); > +return; > +} > + > +if(!GetTempFileNameA( tmppath,"CopyFileExAin",0,source_name )) > +{ > +win_skip("GetTempFileNameA failed\n"); > +r

[PATCH v2 6/8] CIFS: Translate SHARING_VIOLATION to -ETXTBSY error code for SMB2

2013-01-17 Thread Pavel Shilovsky
to make it match CIFS and VFS variants. Signed-off-by: Pavel Shilovsky --- fs/cifs/smb2maperror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/smb2maperror.c b/fs/cifs/smb2maperror.c index 494c912..11e589e 100644 --- a/fs/cifs/smb2maperror.c +++ b/fs/cifs/smb2maper

[PATCH v2 7/8] NFSv4: Add O_DENY* open flags support

2013-01-17 Thread Pavel Shilovsky
by passing these flags to NFSv4 open request. Signed-off-by: Pavel Shilovsky --- fs/nfs/nfs4xdr.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c index 40836ee..0a0cd1e 100644 --- a/fs/nfs/nfs4xdr.c +++ b/fs/nfs/nf

[PATCH v2 8/8] NFSD: Pass share reservations flags to VFS

2013-01-17 Thread Pavel Shilovsky
that maps them into O_DENY flags and make them visible for applications that use O_DENYMAND opens. Signed-off-by: Pavel Shilovsky --- fs/locks.c | 1 + fs/nfsd/nfs4state.c | 46 +- 2 files changed, 46 insertions(+), 1 deletion(-) diff --git

[PATCH v2 5/8] CIFS: Use NT_CREATE_ANDX command for forcemand mounts

2013-01-17 Thread Pavel Shilovsky
forcemand mount option now lets us use Windows mandatory style of byte-range locks even if server supports posix ones - switches on Windows locking mechanism. Share flags is another locking mehanism provided by Windows semantic that can be used by NT_CREATE_ANDX command. This patch combines all Win

[PATCH v2 4/8] CIFS: Add O_DENY* open flags support

2013-01-17 Thread Pavel Shilovsky
Make CIFSSMBOpen take share_flags as a parm that allows us to pass new O_DENY* flags to the server. Signed-off-by: Pavel Shilovsky --- fs/cifs/cifsacl.c | 10 ++ fs/cifs/cifsglob.h | 12 +++- fs/cifs/cifsproto.h | 9 + fs/cifs/cifssmb.c | 47

[PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-01-17 Thread Pavel Shilovsky
If O_DENYMAND flag is specified, O_DENYREAD/WRITE/MAND flags are translated to flock's flags: !O_DENYREAD -> LOCK_READ !O_DENYWRITE -> LOCK_WRITE O_DENYMAND -> LOCK_MAND and set through flock_lock_file on a file. This change only affects opens that use O_DENYMAND flag - all other native Linux

[PATCH v2 2/8] fcntl: Introduce new O_DENY* open flags

2013-01-17 Thread Pavel Shilovsky
This patch adds 4 flags: 1) O_DENYREAD that doesn't permit read access, 2) O_DENYWRITE that doesn't permit write access, 3) O_DENYDELETE that doesn't permit delete or rename, 4) O_DENYMAND that enables O_DENY* flags checks. Network filesystems CIFS, SMB2.0, SMB3.0 and NFSv4 have such flags - this

[PATCH v2 1/8] locks: make flock_lock_file take is_conflict callback parm

2013-01-17 Thread Pavel Shilovsky
This parm demetermines how to check if locks have conflicts. This let us use flock_lock_file funtions further to add O_DENY* flags support through flocks. Signed-off-by: Pavel Shilovsky --- fs/locks.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/fs/locks.c

[PATCH v2 0/8] Add O_DENY* support for VFS and CIFS/NFS

2013-01-17 Thread Pavel Shilovsky
This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This

Re: [PATCH] gdi32: Ensure a fixed-pitch full-width character has double width of a half-width character. (try 4)

2013-01-17 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23979 Your paranoid android

Re: [PATCH] winealsa.drv: Cleanup modLongData and Fix F0 and F7 byte insertion + memory leak.

2013-01-17 Thread Alexandre Julliard
Christian Costa writes: > @@ -927,12 +927,12 @@ static DWORD modData(WORD wDevID, DWORD dwParam) > } > > /** > - * modLongData [internal] > + * modLongData

Re: [2/5] wmiutils: Implement IWbemPath::GetNamespaceAt.

2013-01-17 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23975 Your paranoid android

Re: [4/5] wmiutils: Implement IWbemPath::RemoveNamespaceAt.

2013-01-17 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23977 Your paranoid android

Re: [1/5] wmiutils: Implement IWbemPath::SetClassName.

2013-01-17 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23974 Your paranoid android