Re: [PATCH 4/5] ddraw: Only modify the ddraw destination window at the end of ddraw7_SetCooperativeLevel().

2013-01-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23930 Your paranoid android

Re: [PATCH 2/5] d3d9/tests: Allow the creation of SWVP devices

2013-01-14 Thread Henri Verbeet
On 15 January 2013 00:13, Stefan Dösinger wrote: > -static IDirect3DDevice9 *create_device(IDirect3D9 *d3d9, HWND device_window, > HWND focus_window, BOOL windowed) > +static IDirect3DDevice9 *create_device(IDirect3D9 *d3d9, HWND device_window, > HWND focus_window, BOOL windowed, > +DWOR

Re: Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun
On 13-01-14 11:11 PM, Dmitry Timoshkov wrote: Hi Dimi, Dimi Paun wrote: I've cleanup the deleted pages, were down to about 740 pages, mostly good stuff: https://docs.google.com/a/lattica.com/spreadsheet/ccc?key=0AmY-Kp_Ihu3idFNEOUt0UkVGUko4elhkOHVoaWx2OWc#gid=5 Please check it out, lemme kn

Re: Wine Wiki needs your help!

2013-01-14 Thread Dmitry Timoshkov
Hi Dimi, Dimi Paun wrote: > I've cleanup the deleted pages, were down to about 740 pages, > mostly good stuff: > > https://docs.google.com/a/lattica.com/spreadsheet/ccc?key=0AmY-Kp_Ihu3idFNEOUt0UkVGUko4elhkOHVoaWx2OWc#gid=5 > > Please check it out, lemme know if any spam is still left standing

Re: Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun
Hi guys, I've cleanup the deleted pages, were down to about 740 pages, mostly good stuff: https://docs.google.com/a/lattica.com/spreadsheet/ccc?key=0AmY-Kp_Ihu3idFNEOUt0UkVGUko4elhkOHVoaWx2OWc#gid=5 Please check it out, lemme know if any spam is still left standing. Any ideas on how we can att

Re: Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun
Yes it is done. Ill update the spreadsheet bit later... André Hentschel wrote: >Am 14.01.2013 21:40, schrieb Andrew Eikum: >> On Mon, Jan 14, 2013 at 03:32:40PM -0500, Dimi Paun wrote: >>> OK, we might be onto something. I've wrote a script >>> to determine the deleted pages: 20162. >>> >>> Shou

Re: Wine Wiki needs your help!

2013-01-14 Thread André Hentschel
Am 14.01.2013 21:40, schrieb Andrew Eikum: > On Mon, Jan 14, 2013 at 03:32:40PM -0500, Dimi Paun wrote: >> OK, we might be onto something. I've wrote a script >> to determine the deleted pages: 20162. >> >> Should I just go ahead and nuke those? >> > > Probably, yes. > > One common way for spamme

Re: Reload a DLL and _getptd returns zero

2013-01-14 Thread Michael Ost
On 01/12/2013 05:21 PM, Dan Kegel wrote: The library in question is using static vc runtime linkage, so _getptd() is linked in That's somewhat worrisome. So you have multiple instances of the C runtime library active in the same app? Maybe you're not unloading that dll gracefully enough. Mig

Re: [PATCH 3/5] d3d9/tests: Add a software vertexprocessing buffer discard test

2013-01-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23926 Your paranoid android

Re: [PATCH 5/5] d3d8/tests: Add a software vertexprocessing buffer discard test

2013-01-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23928 Your paranoid android

Re: [PATCH 2/5] d3d9/tests: Allow the creation of SWVP devices

2013-01-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23925 Your paranoid android

Re: comctl32/listview: fix icon spacing calculation [try 2]

2013-01-14 Thread Daniel Jelinski
2013/1/14 Nikolay Sivov : > It's a way it's used in ListView_SetIconSpacing() (which could be broken in > its own way of course). > I think it's ok to ignore this 64 bit case for now, especially while we > don't get daily test runs. Are you saying that I should drop this? -return LISTVIEW_SetI

Re: comctl32/listview: fix icon spacing calculation [try 2]

2013-01-14 Thread Nikolay Sivov
On 1/15/2013 01:53, Daniel Jelinski wrote: 2013/1/14 Nikolay Sivov : This message actually is supposed to be used with MAKELONG(), so it's not truncated in such way. Probably (MSDN doesn't say a word about the preferred macro for this function, unless you count user comments), however if any ap

Re: comctl32/listview: fix icon spacing calculation [try 2]

2013-01-14 Thread Daniel Jelinski
2013/1/14 Nikolay Sivov : > This message actually is supposed to be used with MAKELONG(), so it's not > truncated in such way. Probably (MSDN doesn't say a word about the preferred macro for this function, unless you count user comments), however if any app actually calls MAKELPARAM, at least it w

Re: comctl32/listview: fix icon spacing calculation [try 2]

2013-01-14 Thread Nikolay Sivov
On 1/15/2013 01:43, Daniel Jelinski wrote: 2013/1/14 Nikolay Sivov : So on 64bit you want to distinguish two cases: - ~0 value of lParam - you use it to reset to default values; - all other values including 0x that will result in the same call with both args being -1. Unless I got somet

Patches for winspool.drv and other locations

2013-01-14 Thread Detlef Riekenberg
Hi Tatyana Welcome to Wine. Wine has a test suite to make sure, that new code is correct. Example, what you never tested: > -if(!pDeviceName) { > +if(!pDeviceName && !*pDeviceName) { Your code will crash, when pDeviceName is NULL. I expect, you want to use a logical OR, but i did not t

Re: comctl32/listview: fix icon spacing calculation [try 2]

2013-01-14 Thread Daniel Jelinski
2013/1/14 Nikolay Sivov : > So on 64bit you want to distinguish two cases: > - ~0 value of lParam - you use it to reset to default values; > - all other values including 0x that will result in the same call > with both args being -1. Unless I got something wrong, all other values including

Re: user32/tests: Add test for SetScrollInfo().

2013-01-14 Thread Alexandre Julliard
Sergey Guralnik writes: > +static void test_setscrollinfo ( HWND hwnd, INT nBar ) > +{ > +SCROLLINFO cur, expected; > +char ok_format[] = "unexpected state: (bar: %d)\n" > +" expected: min: %d, max: %d, page: %d, pos: %d\n" > +" got: m

Re: comctl32/listview: fix icon spacing calculation [try 2]

2013-01-14 Thread Nikolay Sivov
On 1/15/2013 01:15, Daniel Jelinski wrote: 2013/1/14 Nikolay Sivov : On 1/15/2013 00:53, Daniel Jelinski wrote: +if(lParam == -1) + return LISTVIEW_SetIconSpacing(infoPtr, -1, -1); +return LISTVIEW_SetIconSpacing(infoPtr, LOWORD(lParam), HIWORD(lParam)); Why do you need to handle

testbot

2013-01-14 Thread Daniel Jelinski
Hello, the testbot does not revert patches submitted through testbot.winehq.org after testing. As a result it is almost impossible to test another patch affecting the same area in code as a previous one. Could anyone please fix it? Or at least add git reset to cron... Regards, Daniel

Re: comctl32/listview: fix icon spacing calculation [try 2]

2013-01-14 Thread Daniel Jelinski
2013/1/14 Nikolay Sivov : > On 1/15/2013 00:53, Daniel Jelinski wrote: > >> +if(lParam == -1) >> + return LISTVIEW_SetIconSpacing(infoPtr, -1, -1); >> +return LISTVIEW_SetIconSpacing(infoPtr, LOWORD(lParam), >> HIWORD(lParam)); > > Why do you need to handle this case specially? If it's

Re: comctl32/listview: fix icon spacing calculation [try 2]

2013-01-14 Thread Nikolay Sivov
On 1/15/2013 00:53, Daniel Jelinski wrote: +if(lParam == -1) + return LISTVIEW_SetIconSpacing(infoPtr, -1, -1); +return LISTVIEW_SetIconSpacing(infoPtr, LOWORD(lParam), HIWORD(lParam)); Why do you need to handle this case specially? If it's -1 for 64bit comctl32 it should give you

Re: comctl32/listview: fix icon spacing calculation [try 2]

2013-01-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23921 Your paranoid android

Re: Wine Wiki needs your help!

2013-01-14 Thread Andrew Eikum
On Mon, Jan 14, 2013 at 03:32:40PM -0500, Dimi Paun wrote: > OK, we might be onto something. I've wrote a script > to determine the deleted pages: 20162. > > Should I just go ahead and nuke those? > Probably, yes. One common way for spammers to abuse wikis is to intentionally get the pages dele

Re: Wine Wiki needs your help!

2013-01-14 Thread André Hentschel
Am 14.01.2013 20:00, schrieb Dimi Paun: > Hm, it doesn't seem to be so simple. > Each page maintains an edit-log file with all the changes. > > grep-ing for -i spam in the edit-log yields less than 400 hits. > > Maybe we should look for deleted pages? > Simple idea: Make a backup of the current

Re: Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun
OK, we might be onto something. I've wrote a script to determine the deleted pages: 20162. Should I just go ahead and nuke those? Dimi. On 01/14/2013 01:35 PM, Francois Gouget wrote: On Mon, 14 Jan 2013, Dimi Paun wrote: MoinMoin creates a dir for every page. I simply got the list by listing

Re: Truncate MIDI SysEx messages after termination byte

2013-01-14 Thread Christian Costa
Le 14/01/2013 19:04, Christian Costa a écrit : 2013/1/14 Christian Costa : 2013/1/14 : Hi, Christian Costa wrote: I took a look at the alsa code and this code simply does not do what it is supposed to. I also looked at it today and noted those bogus lines you quote. Needs a patch (+ fix mem

Re: include: flesh out d3d11.idl (try 2)

2013-01-14 Thread Austin English
On Fri, Jan 11, 2013 at 8:42 PM, Dmitry Timoshkov wrote: > Austin English wrote: > >> >> +/* Forward declarations */ >> > >> > You've copied too much from the PSDK version, better leave it to someone >> > else, and do it step by step when particular functionality gets >> > implemented. >> >> The

Re: Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun
Hm, it doesn't seem to be so simple. Each page maintains an edit-log file with all the changes. grep-ing for -i spam in the edit-log yields less than 400 hits. Maybe we should look for deleted pages? Dimi. On 01/14/2013 01:35 PM, Francois Gouget wrote: On Mon, 14 Jan 2013, Dimi Paun wrote:

Re: Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun
OK, that's a fair point. Lemme quickly go through that and I'll report back. Dimi. On 01/14/2013 01:35 PM, Francois Gouget wrote: On Mon, 14 Jan 2013, Dimi Paun wrote: MoinMoin creates a dir for every page. I simply got the list by listing these directories. (This is the problem -- there is a

Re: Wine Wiki needs your help!

2013-01-14 Thread Francois Gouget
On Mon, 14 Jan 2013, Dimi Paun wrote: > MoinMoin creates a dir for every page. I simply got the list > by listing these directories. (This is the problem -- there is a > limit of 2^15 subdirectories, and this is what we were hitting > a few days ago). > > Does that answer the question? It feels

Re: Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun
MoinMoin creates a dir for every page. I simply got the list by listing these directories. (This is the problem -- there is a limit of 2^15 subdirectories, and this is what we were hitting a few days ago). Does that answer the question? Dimi. On 01/14/2013 12:51 PM, Francois Gouget wrote: On M

Re: Truncate MIDI SysEx messages after termination byte

2013-01-14 Thread Christian Costa
2013/1/14 Christian Costa : > 2013/1/14 : >> Hi, >> >> Christian Costa wrote: >>>I took a look at the >>>alsa code and this code simply does not do what it is supposed to. >> I also looked at it today and noted those bogus lines you quote. Needs >> a patch (+ fix memory leak). > > I will take a lo

Re: Truncate MIDI SysEx messages after termination byte

2013-01-14 Thread Christian Costa
2013/1/14 : > Hi, > > Christian Costa wrote: >>I took a look at the >>alsa code and this code simply does not do what it is supposed to. > I also looked at it today and noted those bogus lines you quote. Needs > a patch (+ fix memory leak). I will take a look at it and send a patch unless someone

Re: Wine Wiki needs your help!

2013-01-14 Thread Francois Gouget
On Mon, 14 Jan 2013, Dimi Paun wrote: [...] > https://docs.google.com/a/lattica.com/spreadsheet/ccc?key=0AmY-Kp_Ihu3idFNEOUt0UkVGUko4elhkOHVoaWx2OWc#gid=5 I'm not clear on how this is supposed to work. For instance I see a ton of pages containing 'joyal' or 'crusher' in their Page Name. For insta

Truncate MIDI SysEx messages after termination byte

2013-01-14 Thread Joerg-Cyril.Hoehle
Hi, Christian Costa wrote: >I took a look at the >alsa code and this code simply does not do what it is supposed to. I also looked at it today and noted those bogus lines you quote. Needs a patch (+ fix memory leak). However, Johannes' change is presumably different, as he wants to scan the buffe

Re: Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun
On 01/14/2013 11:43 AM, Erich E. Hoover wrote: On Mon, Jan 14, 2013 at 9:38 AM, Dimi Paun wrote: ... Please let me know if we can do this any simpler or if there are any problems. Do you want us to move marked items up to the top of the spreadsheet or will you do that for us? I don't think we

Re: vbscript: Added support for more constants

2013-01-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23911 Your paranoid android

Re: Wine Wiki needs your help!

2013-01-14 Thread Erich E. Hoover
On Mon, Jan 14, 2013 at 9:38 AM, Dimi Paun wrote: > ... > Please let me know if we can do this any simpler or if there are > any problems. Do you want us to move marked items up to the top of the spreadsheet or will you do that for us? Erich

Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun
Folks, As we all know, through the years spam has been an ongoing problem. We dealt with it OK, as we valued the openness of our wiki. That's good. However, all this churn has accumulated a lot of garbage on the system, as orphaned pages and dummy users. These have accumulated to such an extent

Re: [2/2] xmllite: Support whitespace nodes reporting

2013-01-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23910 Your paranoid android

Re: Truncate MIDI SysEx messages after termination byte

2013-01-14 Thread Christian Costa
> Still, I'm not persuaded that your patch is at the right place. > I believe the midi* functions should be tiny wrappers around MODM_* > messages, same for the wave* functions. Every time I see somebody > attempt to violate this 1:1 mapping, I'm suspicious. Perhaps the > logic that you're adding

Re: [PATCH 1/2] d3d9: Return D3D_OK from the palette setters (try 3)

2013-01-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23904 Your paranoid android

Re: [PATCH 1/2] d3d9: Return D3D_OK from the palette setters (try 3)

2013-01-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23904 Your paranoid android

Truncate MIDI SysEx messages after termination byte

2013-01-14 Thread Joerg-Cyril.Hoehle
Hi, Johannes Kroll wrote: >+for(i = 0; i < lpMidiOutHdr->dwBufferLength; i++) >+if((unsigned char)lpMidiOutHdr->lpData[i] == 0xF7 && i < >lpMidiOutHdr->dwBufferLength-1) What about for(i = 0; i+1 < lpMidiOutHdr->dwBufferLength, i++) without the redundant second if(&&) half?

Re: [1/2] wmiutils: Implement IWbemPath::GetClassName.

2013-01-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23902 Your paranoid android

Re: [PATCH] kernel32: implement condition variables

2013-01-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23900 Your paranoid android