Re: windowscodecs: Implement CreateBitmapFromHICON. Take 2.

2013-01-13 Thread Vincent Povirk
Looks good to me.

Re: windowscodecs: Implement CreateBitmapFromHICON. Take 2.

2013-01-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23899 Your paranoid android

Re: Reload a DLL and _getptd returns zero

2013-01-13 Thread Nikolay Sivov
On 1/14/2013 01:59, Michael Ost wrote: On 1/13/13 1:17 PM, Marcus Meissner wrote: On Fri, Jan 11, 2013 at 11:24:55AM -0800, Michael Ost wrote: Hi list, Does anyone know why _getptd() calls would return zero on a DLL that has been reloaded? Does something happen to the TLS used by _getptd? At

Re: Reload a DLL and _getptd returns zero

2013-01-13 Thread Michael Ost
On 1/13/13 1:17 PM, Marcus Meissner wrote: On Fri, Jan 11, 2013 at 11:24:55AM -0800, Michael Ost wrote: Hi list, Does anyone know why _getptd() calls would return zero on a DLL that has been reloaded? Does something happen to the TLS used by _getptd? At Muse Research we have been struggling wi

Re: Reload a DLL and _getptd returns zero

2013-01-13 Thread Marcus Meissner
On Fri, Jan 11, 2013 at 11:24:55AM -0800, Michael Ost wrote: > Hi list, > > Does anyone know why _getptd() calls would return zero on a DLL that > has been reloaded? Does something happen to the TLS used by _getptd? > > At Muse Research we have been struggling with a deep bug for years > where th

Re: comctl32/listview: fix icon spacing calculation

2013-01-13 Thread Nikolay Sivov
On 1/14/2013 00:00, Daniel Jelinski wrote: -static DWORD LISTVIEW_SetIconSpacing(LISTVIEW_INFO *infoPtr, INT cx, INT cy) +static DWORD LISTVIEW_SetIconSpacing(LISTVIEW_INFO *infoPtr, WORD cx, WORD cy) I don't really like it as WORD, what it really is a int value with special meaning reserved for

Re: comctl32/listview: fix icon spacing calculation

2013-01-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23897 Your paranoid android

Re: [PATCH] advapi32: add RegSetKeyValue{A,W}

2013-01-13 Thread Nikolay Sivov
On 1/13/2013 09:27, danielfsan...@att.net wrote: Adds RegSetKeyValue{A,W} to advapi32.dll Refactors RegSetValue{A,W} to call RegSetKeyValue{A,W} Fixes bug #32711 --- dlls/advapi32/advapi32.spec |4 +- dlls/advapi32/registry.c| 81 +-- 2 files